From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 227ADC43381 for ; Thu, 28 Feb 2019 23:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D320020850 for ; Thu, 28 Feb 2019 23:39:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RMg7Xw+4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727876AbfB1XjW (ORCPT ); Thu, 28 Feb 2019 18:39:22 -0500 Received: from mail-it1-f193.google.com ([209.85.166.193]:54844 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbfB1XjW (ORCPT ); Thu, 28 Feb 2019 18:39:22 -0500 Received: by mail-it1-f193.google.com with SMTP id w18so17446478itj.4 for ; Thu, 28 Feb 2019 15:39:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xl/VHkISQds30MIGHXhz8zWSd8eWLcUqDd8bDu0FSX0=; b=RMg7Xw+4t9QRTuf9FotF0lZctWyKUOLgG64u8skhmieVdFpIRZBhQAHZa0m8WsDe9I wdVQMuEDw2q3TpdKJvFtRXG4LFDUx/crMpWN5AR9rPPTPtB8nW2yaWD45+WID0UnZmgm w68vM1nVxr5cvvwRZriKCqTeOfKSZKaSFUCkU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xl/VHkISQds30MIGHXhz8zWSd8eWLcUqDd8bDu0FSX0=; b=ZwbBlby/e8rMuLjmQlkSy/cs0R0FEo+RGjmt8Y8sDekrvguD2dOQDd0+BDX+IuoAfF EhWbX1AIqGzYXY+03wLOmQmQeXLxyNst2zq08c5VLpOw29Ufk74l8a4kRbjWffEk11+w +ZDOSS6T1l2z9gJY/Cbs70Tb7bNCtfSpYe02JA3id/JChv3sBr95Kl7y/d9Y6aEyuwTg 67P7kizVd4nsVTM2R0PGIewQxZiF4VexHsblYi/Caa89PjLloN34EDO6ExTIkm9vn2WT GciW48hCPdjzpkxnXSzwoNwOGIKDpJO6Yk5TRilhD0v8eTIiXdpB3ybKwpxYC1KI0Z2D Ffiw== X-Gm-Message-State: AHQUAubf3tLj4x4eytetwIAzzqP3jotDdCd0meWQDAZxJA9NGIgaJJ6O HRUFkx7rAV0Kf0l0XNNycr6/yfOE5Jh2Ekk9pwa+QQ== X-Google-Smtp-Source: AHgI3Ibl/NifKmtLTTiz2V0lEfdzQgZb1fwjmD/Pc2ndKKjjogcakyM8WJb2ybQ16BCwaYArZp+Y2c3c4sk5FslIlVE= X-Received: by 2002:a24:328c:: with SMTP id j134mr1698032ita.71.1551397161184; Thu, 28 Feb 2019 15:39:21 -0800 (PST) MIME-Version: 1.0 References: <1550999629-31791-1-git-send-email-rushikesh.s.kadam@intel.com> <39dc9be2-808e-4800-b4bb-605d5bf94e12@collabora.com> <3959820e-cf43-2370-7cea-7afd01b2933c@collabora.com> <20190228075656.GA9224@smile.fi.intel.com> In-Reply-To: From: Gwendal Grignou Date: Thu, 28 Feb 2019 15:39:10 -0800 Message-ID: Subject: Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device To: Enric Balletbo Serra Cc: Andy Shevchenko , Enric Balletbo i Serra , Jett Rink , Guenter Roeck , Rushikesh S Kadam , Lee Jones , Benson Leung , Guenter Roeck , linux-kernel , Aaron Durbin , Duncan Laurie Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 28, 2019 at 4:18 AM Enric Balletbo Serra wrote: > > Hi Andy, > Missatge de Andy Shevchenko del dia dj., > 28 de febr. 2019 a les 8:57: > > > > On Thu, Feb 28, 2019 at 12:05:35AM +0100, Enric Balletbo Serra wrote: > > > Missatge de Gwendal Grignou del dia dc., 27 de > > > febr. 2019 a les 19:37: > > > > On Wed, Feb 27, 2019 at 10:08 AM Enric Balletbo i Serra > > > > wrote: > > > > > On 27/2/19 16:13, Jett Rink wrote: > > > > > > You're right, the cros_ names are based on what the EC provides. > > > > cros_ec for generic EC, fp, tp for fingerprint, touch pad > > > > respectively. > > > > ish is for standalone sensor hub [it does not have to be Intel Sensor Hub]. > > > > > > > > > > Thanks for the explanation. I didn't know that and I assumed the 'i' > > > was for 'intel', maybe would be good call cros_ssh or cros_sh to avoid > > > confusion? > > > > i is for Integrated. There is no confusion. > > Ok, thanks for the clarification. Now that is clear to me I'll send > some reviews of this patch in a minute. Regarding cros_scp, it may coexist with cros_ec or be standalone. It is not clear yet. Gwendal. > > Best regards, > Enric > > > It seems you misread what was written in [] above. > > > > -- > > With Best Regards, > > Andy Shevchenko > > > >