From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A97C433E6 for ; Sun, 24 Jan 2021 20:43:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E2A522C7B for ; Sun, 24 Jan 2021 20:43:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726563AbhAXUnw (ORCPT ); Sun, 24 Jan 2021 15:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbhAXUns (ORCPT ); Sun, 24 Jan 2021 15:43:48 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F064CC061574 for ; Sun, 24 Jan 2021 12:43:07 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id n2so22543621iom.7 for ; Sun, 24 Jan 2021 12:43:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xvqt0wMUCgaJb2QCjgNdTwtimCxgRvZpl4rRhVBBS5I=; b=LmhOmYVIGy5XQClncUyexrRr2nyzzZ80LyVKXYcHeogY3kQlq9h27lGRCLlVKS6A2G /e2O5eXC1MYyJC0kVerfiTBR+g8dtlGlF2ydWCk8tPr6+F3H6zXaeDWJvYTf4Fyh7pJH oVnnUoS/qcenGu5Z0Sp8nk4fx5LOKw81YU+wY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xvqt0wMUCgaJb2QCjgNdTwtimCxgRvZpl4rRhVBBS5I=; b=Y8btBypopLJ5MXXGbQSnFuafLIba5+0dST+Gthzvh5DR2q6ANevjvbNatTRyhdZ4bC DX+sGZx9gTm9CEaiM352NJwNbwBtMXXueCYKEviaRjwLe5jCdvDFrzykukcjjaGAxNRE hjUEU0iHBDuIIlOtWBwPRUwD6PGAO8z0B6ILS4TVXzbSOkBC4t4NRc8jJoM0gZuWhu0H 3anxFNfqyh/+apqEUDP40RdhLqUixS0g8FKOtj1TAg0Jo1cMfJaCoMI2UeX/9MarXeFN Uvqx1WynYGq0jO+TxKmnL4R1q3fZQA18nRlRvqxD388HDkA/Z0Fz2uwLsgs3GHWrW1Jy q0kQ== X-Gm-Message-State: AOAM532/Zg/BR/lCj9D6FslSsfyBbHHttRXu9XriIGKXvWPYPqfskKNr tm0QePLX815bqYtLF+4KZkB9/SqqJcXJ4e+NuxRqDQ== X-Google-Smtp-Source: ABdhPJwype5xvCWqyKuPey1tYYGsPyFxF6WSVIwdk/KUZElF0gzRHJBgBfVCZ07FNu5ZO2JirfBz7bUG63o1LmxkCA8= X-Received: by 2002:a05:6638:1b6:: with SMTP id b22mr623152jaq.52.1611520987222; Sun, 24 Jan 2021 12:43:07 -0800 (PST) MIME-Version: 1.0 References: <20210122225443.186184-1-swboyd@chromium.org> <20210122225443.186184-3-swboyd@chromium.org> <20210124172756.69ef7c5a@archlinux> In-Reply-To: <20210124172756.69ef7c5a@archlinux> From: Gwendal Grignou Date: Sun, 24 Jan 2021 12:42:56 -0800 Message-ID: Subject: Re: [PATCH 2/3] dt-bindings: iio: Add cros ec proximity yaml doc To: Jonathan Cameron Cc: Stephen Boyd , linux-kernel , linux-iio , Dmitry Torokhov , Benson Leung , Guenter Roeck , Douglas Anderson , devicetree@vger.kernel.org, Rob Herring Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 24, 2021 at 9:28 AM Jonathan Cameron wrote: > > On Fri, 22 Jan 2021 14:54:42 -0800 > Stephen Boyd wrote: > > > Some cros ECs support a front proximity MKBP event via > > 'EC_MKBP_FRONT_PROXIMITY'. Add a DT binding to document this feature via > > a node that is a child of the main cros_ec device node. Devices that > > have this ability will describe this in firmware. > > > > Cc: Dmitry Torokhov > > Cc: Benson Leung > > Cc: Guenter Roeck > > Cc: Douglas Anderson > > Cc: Gwendal Grignou > > Cc: > > Cc: Rob Herring > > Signed-off-by: Stephen Boyd > > --- > > .../proximity/google,cros-ec-proximity.yaml | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml > > new file mode 100644 > > index 000000000000..c0a34bdfe4fd > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/proximity/google,cros-ec-proximity.yaml > > @@ -0,0 +1,37 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/iio/proximity/google,cros-ec-proximity.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ChromeOS EC MKBP Proximity Sensor > > + > > +maintainers: > > + - Stephen Boyd > > + - Benson Leung > > + - Enric Balletbo i Serra > > + > > +description: | > > + Google's ChromeOS EC sometimes has the ability to detect user proximity. > > + This is implemented on the EC as near/far logic and exposed to the OS > > + via an MKBP switch bit. > > + > > +properties: > > + compatible: > > + const: google,cros-ec-proximity Given we have proximity detection in cros_ec via specific sensor (si 1141) or algorithm (on-body/off-body via MOTIONSENSE_ACTIVITY_BODY_DETECTION), can we name the property cros-ec-mkbp-proximity? > > + > > + label: > > + description: Name for proximity sensor > > + > > +required: > > + - compatible > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + proximity { > > Can we at least have the example making it clear this is a child of the > cros_ec device? > > > + compatible = "google,cros-ec-proximity"; > > + label = "proximity-wifi-lte"; > > + }; >