From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97CC2C83000 for ; Tue, 28 Apr 2020 12:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7872D206D6 for ; Tue, 28 Apr 2020 12:49:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="pq7NBpxA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726904AbgD1Mt5 (ORCPT ); Tue, 28 Apr 2020 08:49:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726804AbgD1Mt5 (ORCPT ); Tue, 28 Apr 2020 08:49:57 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB038C03C1AB for ; Tue, 28 Apr 2020 05:49:56 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id u127so2724078wmg.1 for ; Tue, 28 Apr 2020 05:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T0akXOU/T+phx4piiDIHlJgC6bgR8WnmW0DHmvs0oaU=; b=pq7NBpxAJ0utSOg3DDUGFHb3Py1QF/TuUxV3wtcBYvHUb8VThifcz9Z5awmC1SD870 aErrSQ6QaOPEk8r23wMyT+m+5kbRUMfYUSMi2wd+Xrh7CuPUJ54W66YZ++IC4ASn+Ebb agjkWE2LmxPv4LzbiGz90wUMWKPR91TsYXWJlO9btYUgOmGwEe/rcmiZ1E2gWjkcMvlE qlaFki2OFS77Yv/YK5/gu4LwlOl05QLr5MnNfd8+o8y/lhbdOBRMOfukBXih4EDerVkY vKMkZQGhTVhVTh6MCCU+J/8osOYGvefcngl6bL9OLK/TceJFnFyL2LbLwNt52ktErMAf kM6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T0akXOU/T+phx4piiDIHlJgC6bgR8WnmW0DHmvs0oaU=; b=fgCIb+But1E1p+OuzUPryb4+qJNtRK+LgWdDoqHvsRHbPYeqYcPh4I4iGI1Pa4OpDq W/d7ge2Dd6VAGrplN34i2GezMv+vZ4ay8tSVo3Sw7iMd4VsqFMjrrds0DRmQE7fKWsfg J+BKeot0M5DjN/fxtMI+Uzvqb82bpX1lYlRB80NhdvtXTMJtRYLfiWYal5Kjh0hBmrpY GLb4yETzXfdHHzuCM0BolbUM87E2xkRvq9/VB0MmL1+q0SOAq/m4Ao3ncw49H9pqYPwp 84BsihrukKJJVPYPQ1ca1X15uiY9wBesFdZfEjEtxT/tZGxePqoAxm+kNjptSUJ5wANJ OVkA== X-Gm-Message-State: AGi0PubFrtstu8sAKtH4QpSrNB3RrTJY7HD33XCBWPOVAwOO96OxvE4v Aon4jj4kk9uQiC+YSpLdar0f8cVReHX+6I6o7QA/Vg== X-Google-Smtp-Source: APiQypL5Wc0x3ujuYNguZCyOPZVk5rJHty3L04qHuEpcmwL7U8Ae7z4/tG0kBt5TtWeIZhIoikLM9v+63HO10iiWf8I= X-Received: by 2002:a05:600c:1109:: with SMTP id b9mr4404814wma.116.1588078195551; Tue, 28 Apr 2020 05:49:55 -0700 (PDT) MIME-Version: 1.0 References: <20200413155134.250243-1-purisame@spuri.io> In-Reply-To: <20200413155134.250243-1-purisame@spuri.io> From: Dave Stevenson Date: Tue, 28 Apr 2020 13:49:40 +0100 Message-ID: Subject: Re: [PATCH] media: i2c: imx219: remove redundant writes To: Sameer Puri Cc: Mauro Carvalho Chehab , Linux Media Mailing List , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sameer Thanks for the patch. On Mon, 13 Apr 2020 at 16:51, Sameer Puri wrote: > > These writes to 0x162, 0x163 already appear earlier in the struct for > the 1920x1080 mode and do not need to be repeated. > > Signed-off-by: Sameer Puri Reviewed-by: Dave Stevenson If I was going to be fussy, it would be nice to have the writes to 0x162/0x163 in a consistent place in the table, which is generally the end (I'm aware that the 640x480 mode has it in the middle). Personally I'm not overly worried, but others may prefer it. > --- > drivers/media/i2c/imx219.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c > index cb03bdec1f9c..53dafb7f5f2c 100644 > --- a/drivers/media/i2c/imx219.c > +++ b/drivers/media/i2c/imx219.c > @@ -253,8 +253,6 @@ static const struct imx219_reg mode_1920_1080_regs[] = { > {0x4793, 0x10}, > {0x4797, 0x0e}, > {0x479b, 0x0e}, > - {0x0162, 0x0d}, > - {0x0163, 0x78}, > }; > > static const struct imx219_reg mode_1640_1232_regs[] = { > > base-commit: 8f3d9f354286745c751374f5f1fcafee6b3f3136 > -- > 2.26.0 > >