From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E31C5C2BBD4 for ; Fri, 18 Dec 2020 14:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABF0323AAA for ; Fri, 18 Dec 2020 14:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727938AbgLROaO (ORCPT ); Fri, 18 Dec 2020 09:30:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727376AbgLROaN (ORCPT ); Fri, 18 Dec 2020 09:30:13 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6675C0617A7 for ; Fri, 18 Dec 2020 06:29:32 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id q75so2789467wme.2 for ; Fri, 18 Dec 2020 06:29:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fQcnaVeKn76lYRwiXKR4yvTyQ/9Lgo43QJdLzaw88No=; b=dPH2ZMGlXf7qxs4VLNk1sqQ6DOFTn3EJphiLC07Hd/sKNpQ9O+b48p1oN5bMMLsNcw hUCxxdBSaWxlRLCiL9I/Tfv7Ip15ldWsKrB+y0tzx17DQZbd5X0qybJL4dS6oezkjXuL 1YSWS2M66tLqmHYc3wFa0FqObn3OYwwVpqrlVgWf01NBCJq8VBu1OVSdI4xzZvIqedxg 0eUb8r35JQVUXYis0AZPc+9VNUaDtE9dWc6DIn2A/6aZsBXFJBtRfvgj9tL/HyxINwoa hYGargZwS5AyYExBC9Pyy1MRNHD2HRaJI2tnVrHRDiAkjnG+32WYgMNbODrH25LBY6hy w3JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fQcnaVeKn76lYRwiXKR4yvTyQ/9Lgo43QJdLzaw88No=; b=DEl2svOJE7J/MijSxHxWSCXhsnfdCaCD1JSwQx9MgD1ZtrKGDGGiRbvSl86kqyk/2Y C1Zdx6LUwVFLOTVk6aSHntLhJCqNvR6L2lGEAdFl1tNy5pS51pPHFcSgIrrRDKjKIFp7 KVyDptM11Rwf/8JJL95Jb6s57ecw6F2XjI244GbfpGF2983JBPgCciyyXJ21kKjF9Q0j OuY7/t+9JFJ6TbB341m81WSsfW79XnTPchlSgqJA/HGk9LtgZxhMsqetoOfPOUmtsSwL 16v6ZADYuCPgoWNiRbYrh82Dj0GJaa2V6Sw2a9zvUz94WdvG2ZYmDZrDfaZisqYWZv9y z0oA== X-Gm-Message-State: AOAM532SgTSiopYwF32mYzeErh89iW/1Lfp5yqMyAGiSRE5zLMM25+Cu LST+ykcT6JpMKmzygg+/sX2444Rb5qwyFoNzplOPhA== X-Google-Smtp-Source: ABdhPJx1zfDnyXEmVWiw9EZm8yj56h7EPNv2EiQk8r5FgzIdRnBEqEC4Oc6xyUqbtGIHIlNzOeHBGh+HWy5KnmgE0kE= X-Received: by 2002:a1c:bc88:: with SMTP id m130mr4645539wmf.82.1608301771650; Fri, 18 Dec 2020 06:29:31 -0800 (PST) MIME-Version: 1.0 References: <20201210134648.272857-1-maxime@cerno.tech> <20201210134648.272857-13-maxime@cerno.tech> In-Reply-To: <20201210134648.272857-13-maxime@cerno.tech> From: Dave Stevenson Date: Fri, 18 Dec 2020 14:29:14 +0000 Message-ID: Subject: Re: [PATCH 12/15] drm/vc4: hdmi: Don't register the CEC adapter if there's no interrupts To: Maxime Ripard Cc: Eric Anholt , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie , Jason Cooper , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Linux Media Mailing List , Hans Verkuil , LKML , Mauro Carvalho Chehab , Thomas Gleixner , linux-rpi-kernel@lists.infradead.org, DRI Development Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Dec 2020 at 13:47, Maxime Ripard wrote: > > We introduced the BCM2711 support to the vc4 HDMI controller with 5.10, > but this was lacking any of the interrupts of the CEC controller so we > have to deal with the backward compatibility. > > Do so by simply ignoring the CEC setup if the DT doesn't have the > interrupts property. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index 327638d93032..69217c68d3a4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -1655,9 +1655,15 @@ static int vc4_hdmi_cec_init(struct vc4_hdmi *vc4_hdmi) > { > struct cec_connector_info conn_info; > struct platform_device *pdev = vc4_hdmi->pdev; > + struct device *dev = &pdev->dev; > u32 value; > int ret; > > + if (!of_find_property(dev->of_node, "interrupts", NULL)) { > + dev_warn(dev, "'interrupts' DT property is missing, no CEC\n"); > + return 0; > + } > + > vc4_hdmi->cec_adap = cec_allocate_adapter(&vc4_hdmi_cec_adap_ops, > vc4_hdmi, "vc4", > CEC_CAP_DEFAULTS | > -- > 2.28.0 >