From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Emma Anholt <emma@anholt.net>,
Hans Verkuil <hans.verkuil@cisco.com>,
Daniel Vetter <daniel@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
linux-rpi-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
Maxime Ripard <mripard@kernel.org>,
Nicolas Saenz Julienne <nsaenz@kernel.org>
Subject: Re: [PATCH 0/3] drm/vc4: hdmi: Interrupt fixes
Date: Wed, 7 Jul 2021 11:05:12 +0100 [thread overview]
Message-ID: <CAPY8ntD-fi1Zm5eDQd4JR9qOcwfQukkEbMQvYaOgdhOHcQMUDw@mail.gmail.com> (raw)
In-Reply-To: <20210707095112.1469670-1-maxime@cerno.tech>
Hi Maxime
On Wed, 7 Jul 2021 at 10:51, Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi,
>
> Those are three fixes for race conditions we currently have in the vc4 HDMI
> driver with regard to the interrupts handling.
>
> The first two are fixing an issue where the handler will be removed by devm
> after the resources it uses have been free'd already.
>
> The last one is there to deal with an interrupt coming in the window between
> the end of the driver's bind and the DRM device registration.
>
> Let me know what you think,
> Maxime
For the series
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Maxime Ripard (3):
> drm/vc4: hdmi: Drop devm interrupt handler for CEC interrupts
> drm/vc4: hdmi: Drop devm interrupt handler for hotplug interrupts
> drm/vc4: hdmi: Only call into DRM framework if registered
>
> drivers/gpu/drm/vc4/vc4_hdmi.c | 92 +++++++++++++++++++++++-----------
> 1 file changed, 62 insertions(+), 30 deletions(-)
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-07-07 10:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 9:51 [PATCH 0/3] drm/vc4: hdmi: Interrupt fixes Maxime Ripard
2021-07-07 9:51 ` [PATCH 1/3] drm/vc4: hdmi: Drop devm interrupt handler for CEC interrupts Maxime Ripard
2021-07-07 9:51 ` [PATCH 2/3] drm/vc4: hdmi: Drop devm interrupt handler for hotplug interrupts Maxime Ripard
2021-07-07 9:51 ` [PATCH 3/3] drm/vc4: hdmi: Only call into DRM framework if registered Maxime Ripard
2021-07-07 10:05 ` Dave Stevenson [this message]
2021-07-15 8:50 ` [PATCH 0/3] drm/vc4: hdmi: Interrupt fixes Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPY8ntD-fi1Zm5eDQd4JR9qOcwfQukkEbMQvYaOgdhOHcQMUDw@mail.gmail.com \
--to=dave.stevenson@raspberrypi.com \
--cc=airlied@linux.ie \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=hans.verkuil@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).