From: Dave Stevenson <dave.stevenson@raspberrypi.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>, Emma Anholt <emma@anholt.net>,
Boris Brezillon <bbrezillon@kernel.org>,
Phil Elwell <phil@raspberrypi.com>,
Tim Gover <tim.gover@raspberrypi.com>,
Dom Cobley <dom@raspberrypi.com>,
linux-rpi-kernel@lists.infradead.org,
Nicolas Saenz Julienne <nsaenz@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
LKML <linux-kernel@vger.kernel.org>,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 0/5] drm/vc4: hdmi: Fix CEC access while disabled
Date: Wed, 28 Jul 2021 14:52:24 +0100 [thread overview]
Message-ID: <CAPY8ntDXZ7ExjKvBMFjd5d3RTfrGCe2TYiXfmjF4bmE+WMFssQ@mail.gmail.com> (raw)
In-Reply-To: <20210707092257.1465109-1-maxime@cerno.tech>
Hi Maxime
On Wed, 7 Jul 2021 at 10:23, Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi,
>
> This series aims at fixing a complete and silent hang when one tries to use CEC
> while the display output is off.
>
> This can be tested with:
>
> echo off > /sys/class/drm/card0-HDMI-A-1/status
> cec-ctl --tuner -p 1.0.0.0
> cec-compliance
>
> This series addresses it by making sure the HDMI controller is powered up as
> soon as the CEC device is opened by the userspace.
>
> Let me know what you think,
> Maxime
>
> Changes from v1:
> - More fixes
> - Added a big warning if we try to access a register while the device is
> disabled.
> - Fixed the pre_crtc_configure error path
>
> Maxime Ripard (5):
> drm/vc4: hdmi: Make sure the controller is powered up during bind
> drm/vc4: hdmi: Rework the pre_crtc_configure error handling
> drm/vc4: hdmi: Split the CEC disable / enable functions in two
> drm/vc4: hdmi: Make sure the device is powered with CEC
> drm/vc4: hdmi: Warn if we access the controller while disabled
Comment made on patch 1.
Patches 2-5:
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Dave
>
> drivers/gpu/drm/vc4/vc4_hdmi.c | 123 +++++++++++++++++++---------
> drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 ++
> 2 files changed, 89 insertions(+), 40 deletions(-)
>
> --
> 2.31.1
>
prev parent reply other threads:[~2021-07-28 13:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 9:22 [PATCH v2 0/5] drm/vc4: hdmi: Fix CEC access while disabled Maxime Ripard
2021-07-07 9:22 ` [PATCH v2 1/5] drm/vc4: hdmi: Make sure the controller is powered up during bind Maxime Ripard
2021-07-28 13:50 ` Dave Stevenson
2021-07-07 9:22 ` [PATCH v2 2/5] drm/vc4: hdmi: Rework the pre_crtc_configure error handling Maxime Ripard
2021-07-07 9:22 ` [PATCH v2 3/5] drm/vc4: hdmi: Split the CEC disable / enable functions in two Maxime Ripard
2021-07-07 9:22 ` [PATCH v2 4/5] drm/vc4: hdmi: Make sure the device is powered with CEC Maxime Ripard
2021-07-07 9:22 ` [PATCH v2 5/5] drm/vc4: hdmi: Warn if we access the controller while disabled Maxime Ripard
2021-07-28 13:52 ` Dave Stevenson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPY8ntDXZ7ExjKvBMFjd5d3RTfrGCe2TYiXfmjF4bmE+WMFssQ@mail.gmail.com \
--to=dave.stevenson@raspberrypi.com \
--cc=airlied@linux.ie \
--cc=bbrezillon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.vetter@intel.com \
--cc=dom@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=nsaenz@kernel.org \
--cc=phil@raspberrypi.com \
--cc=tim.gover@raspberrypi.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).