From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731EDC4320A for ; Wed, 28 Jul 2021 13:54:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C4D261051 for ; Wed, 28 Jul 2021 13:54:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237283AbhG1NyP (ORCPT ); Wed, 28 Jul 2021 09:54:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236952AbhG1Nww (ORCPT ); Wed, 28 Jul 2021 09:52:52 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 950A2C0613CF for ; Wed, 28 Jul 2021 06:52:41 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id l11-20020a7bc34b0000b029021f84fcaf75so4388836wmj.1 for ; Wed, 28 Jul 2021 06:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuD2/cMi9v63nZZZmSBG2IaupOS/1XWwnneUf9M1k9o=; b=qcRqP641xG0vB+UDYiik9LQYbPUpon4cK820eR4sCWfADHA+T9YgUCydz8yzF5Z8gN 9ZQUEAhytwB5ZTNRpwtUWvuzeTq7kDMKRLGiRBEVaGKgpBgaJMzQzHdYwsT+ei/fzUXD tnEDngdpt/iMmL9N+uLOZBHGyiUIgar1ziPC1yNKhdps+wgFOmNmB2Bv2w4E8HKZTvBf 72i9hM0HTF4pHTf0pEs99WWodCZCQ9/x9snGUz247KYbrsT1v4M7LCB4quydvu6HYkrl oK5ypCS8Fy3yBcHA54M1L3MZ+MlQ2d4dGvvShgn5bgsDF8hmQrtKCtyrAcYa18gE4f8n mkGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuD2/cMi9v63nZZZmSBG2IaupOS/1XWwnneUf9M1k9o=; b=dVKwNJ2MtDeseoVR5rHOtZY8zNJ9pigjsGbya6vAL3GQFnkRChMEa1GJiQNVHG2hHY 4m3GFfzTVefyvgqRGFp0SjMtfQM90aFAs/wJSRaBCnOqZIoQeFzVdhJpd77Yci1uDB5V i/Ll/FsWKfJNGZtnPPCs9DWSvtw8ik5+roaNp7o+1p+l4TiawEudilauip+T9HaBa9yL 3Rr0+vnWYoSVRpOjnsrHBrx5gw4mfVLzH3DMuF7Ha6yjO6S+gaoMk5nLHI/9zL1duHwQ pVe1lcud0rBeM5Ky66WJAOLXuuLXfxX7hcQzNj3pUXa+15mkQ+qEyHXmEx7bWVDZJ810 CvWQ== X-Gm-Message-State: AOAM532eJYcJA/fxvKdoxOYKC1v6R0qTD7y6NB5gbc6HkrQjlwyd3MZo bPmoCS1wUQEAoHwBe0Lh/3o/WnHJf0N87z0rdsqMYQ== X-Google-Smtp-Source: ABdhPJyZ4wRTiW93BgBlBxE6MvcGFi57mJyOUsPHwaGo/ilO2tap+IJYgnG0mQS5pIEyDpoLfvQwlnfJlQMVP7gRGQs= X-Received: by 2002:a05:600c:354e:: with SMTP id i14mr27642677wmq.96.1627480360236; Wed, 28 Jul 2021 06:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20210707092257.1465109-1-maxime@cerno.tech> In-Reply-To: <20210707092257.1465109-1-maxime@cerno.tech> From: Dave Stevenson Date: Wed, 28 Jul 2021 14:52:24 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] drm/vc4: hdmi: Fix CEC access while disabled To: Maxime Ripard Cc: DRI Development , Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Emma Anholt , Boris Brezillon , Phil Elwell , Tim Gover , Dom Cobley , linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne , Hans Verkuil , LKML , bcm-kernel-feedback-list@broadcom.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime On Wed, 7 Jul 2021 at 10:23, Maxime Ripard wrote: > > Hi, > > This series aims at fixing a complete and silent hang when one tries to use CEC > while the display output is off. > > This can be tested with: > > echo off > /sys/class/drm/card0-HDMI-A-1/status > cec-ctl --tuner -p 1.0.0.0 > cec-compliance > > This series addresses it by making sure the HDMI controller is powered up as > soon as the CEC device is opened by the userspace. > > Let me know what you think, > Maxime > > Changes from v1: > - More fixes > - Added a big warning if we try to access a register while the device is > disabled. > - Fixed the pre_crtc_configure error path > > Maxime Ripard (5): > drm/vc4: hdmi: Make sure the controller is powered up during bind > drm/vc4: hdmi: Rework the pre_crtc_configure error handling > drm/vc4: hdmi: Split the CEC disable / enable functions in two > drm/vc4: hdmi: Make sure the device is powered with CEC > drm/vc4: hdmi: Warn if we access the controller while disabled Comment made on patch 1. Patches 2-5: Reviewed-by: Dave Stevenson Dave > > drivers/gpu/drm/vc4/vc4_hdmi.c | 123 +++++++++++++++++++--------- > drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 ++ > 2 files changed, 89 insertions(+), 40 deletions(-) > > -- > 2.31.1 >