Re: Re: [PATCH bpf-next v6 0/5] sockmap: add sockmap support for unix stream socket

From: "Jiang Wang ." <jiang.wang@bytedance.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Networking <netdev@vger.kernel.org>,
	"Cong Wang" <cong.wang@bytedance.com>,
	"Xiongchun Duan" <duanxiongchun@bytedance.com>,
	"Yongji Xie" <xieyongji@bytedance.com>,
	柴稳 <chaiwen.cc@bytedance.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jakub Sitnicki" <jakub@cloudflare.com>,
	"Lorenz Bauer" <lmb@cloudflare.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <kafai@fb.com>,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"KP Singh" <kpsingh@kernel.org>, "Shuah Khan" <shuah@kernel.org>,
	"Al Viro" <viro@zeniv.linux.org.uk>,
	"Christian Brauner" <christian.brauner@ubuntu.com>,
	"Johan Almbladh" <johan.almbladh@anyfinetworks.com>,
	"open list" <linux-kernel@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>,
	"open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>
Subject: Re: Re: [PATCH bpf-next v6 0/5] sockmap: add sockmap support for unix stream socket
Date: Fri, 13 Aug 2021 21:31:17 -0700	[thread overview]
Message-ID: <CAP_N_Z8Czh-hiKn3AwWb-Yib30805BOnVcY8urd=-2mVDctsjg@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzZe-Kmoj4HKe0oiDMq_KaSQAfdVAEqksd3d8Tx7cX+Ftw@mail.gmail.com>

On Fri, Aug 13, 2021 at 3:42 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Aug 9, 2021 at 12:47 PM Jiang Wang <jiang.wang@bytedance.com> wrote:
> >
> > This patch series add support for unix stream type
> > for sockmap. Sockmap already supports TCP, UDP,
> > unix dgram types. The unix stream support is similar
> > to unix dgram.
> >
> > Also add selftests for unix stream type in sockmap tests.
> >
>
> Hey Jiang,
>
> This patch doesn't apply cleanly to bpf-next anymore ([0]), can you
> please rebase and resubmit, adding John's and Jakub's acks along the
> way? Thanks!
>

Sure, I just rebased, added ack and sent the patch again with the same title.
Let me know if there is any problem. Thanks.

>   [0] https://github.com/kernel-patches/bpf/pull/1563#issuecomment-896128082
>
> >
> > Jiang Wang (5):
> >   af_unix: add read_sock for stream socket types
> >   af_unix: add unix_stream_proto for sockmap
> >   selftest/bpf: add tests for sockmap with unix stream type.
> >   selftest/bpf: change udp to inet in some function names
> >   selftest/bpf: add new tests in sockmap for unix stream to tcp.
> >
> >  include/net/af_unix.h                         |  8 +-
> >  net/unix/af_unix.c                            | 91 +++++++++++++++---
> >  net/unix/unix_bpf.c                           | 93 ++++++++++++++-----
> >  .../selftests/bpf/prog_tests/sockmap_listen.c | 48 ++++++----
> >  4 files changed, 187 insertions(+), 53 deletions(-)
> >
> > v1 -> v2 :
> >  - Call unhash in shutdown.
> >  - Clean up unix_create1 a bit.
> >  - Return -ENOTCONN if socket is not connected.
> >
> > v2 -> v3 :
> >  - check for stream type in update_proto
> >  - remove intermediate variable in __unix_stream_recvmsg
> >  - fix compile warning in unix_stream_recvmsg
> >
> > v3 -> v4 :
> >  - remove sk_is_unix_stream, just check TCP_ESTABLISHED for UNIX sockets.
> >  - add READ_ONCE in unix_dgram_recvmsg
> >  - remove type check in unix_stream_bpf_update_proto
> >
> > v4 -> v5 :
> >  - add two missing READ_ONCE for sk_prot.
> >
> > v5 -> v6 :
> >  - fix READ_ONCE by reading to a local variable first.
> >
> > --
> > 2.20.1
> >