From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0365C433EF for ; Mon, 18 Jul 2022 20:23:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235541AbiGRUXG (ORCPT ); Mon, 18 Jul 2022 16:23:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231248AbiGRUXE (ORCPT ); Mon, 18 Jul 2022 16:23:04 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C080931356 for ; Mon, 18 Jul 2022 13:23:03 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id w2so15014478ljj.7 for ; Mon, 18 Jul 2022 13:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J3Z3tfeKRJLdAhCCmhWHihJdksAblGizQ/tJ4Dbs+/0=; b=HD/VtTr2HeFoaOVpMcfUVs71WCVWY48z0aqcCEiLsX5857s65SH7E5Xb2GjKv3dtWy 6DmQ9EkCke2ysjQ1N8K2jZB/5gkUbhNp5W2rkR0jCyl6FPTEqwNsyR98jtzPVWJqavRr CFbToIfVeJnkjCBBMcdKNkGSveJa+L/1XBtFwxmQ/czqGrrwIW5nO1y3f4zPntYjryFn ab5+ruztb1pA9NxwVq7dkPRPKR9aEpwssmZJUyYfvcsF9vGsEJPIa8/Ogtc9yk1S7apl 2+x8Y87K+VH46qhxvdr5FouKMsKYd/DgRr0ClKYHVU/QLia2LCnSz9qTaU7UmMPfBf7n GJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J3Z3tfeKRJLdAhCCmhWHihJdksAblGizQ/tJ4Dbs+/0=; b=P4qRaIhdkdcE4g0hJnlCfsji/LIIV8L26A/5FZqWmWhim9V9W9tycSekyHXL9BICOe mXYCWmhC2CmzRKcg7Gij4svXbM35NS4ek+w4hfciYH770DWNQPJT46C4iHEWmQ0/kHI0 k8IazQBT8kDIDlcVgaJHMWx26TBCD15kj7JjNX8mapdkWqx2CJUsQ6MugHlCpGTkuZkY dQozTtjgyrU45f6L1hAmlYlP7qKL4x/6F7jsPs7+hRwr4vzuoUo2aG5YlcUROxTTrKsQ ZebgAtKxwcHRusfmz2+fJdMW3tGWi0IOu80IBVtS+q7sIbv48LhqIovBJHVsD0/Qipro +tvA== X-Gm-Message-State: AJIora+MID6kd/XPQunIUvjVuPRNNBbq/BXGUe8GfbL6ZS5GEKkyFfZI AFVqN5lOA2LXiQXtEA95kWzy+VgdVOmJdfgWrJA3Yg== X-Google-Smtp-Source: AGRyM1ucIKcIR0ILXQCLuba5IMjLqiY0xKoOhbqsIuI59lX0d0LNg307CusOi23Ffxs7aSlum+8gG33zVH2Hil+sy4M= X-Received: by 2002:a2e:3607:0:b0:25d:73a7:97b4 with SMTP id d7-20020a2e3607000000b0025d73a797b4mr14294228lja.352.1658175781963; Mon, 18 Jul 2022 13:23:01 -0700 (PDT) MIME-Version: 1.0 References: <20220629213632.3899212-1-blakejones@google.com> In-Reply-To: From: Blake Jones Date: Mon, 18 Jul 2022 13:22:50 -0700 Message-ID: Subject: Re: [PATCH v3] Add a "-m" option to "perf buildid-list". To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Mark Rutland , Alexander Shishkin , Namhyung Kim , Ian Rogers , Peter Zijlstra , Ingo Molnar , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ah yeah of course, sorry about that! On Mon, Jul 18, 2022 at 12:33 PM Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 18, 2022 at 10:07:32AM -0700, Blake Jones escreveu: > > Fabulous, thanks! > > > > On Mon, Jul 18, 2022 at 7:51 AM Arnaldo Carvalho de Melo > > wrote: > > > > > Signed-off-by: Blake Jones > > > > > > > > Acked-by: Jiri Olsa > > > > > > To clarify, b4 found v3 and that was the one applied. > > Now fixing this: > > 28 5.28 debian:experimental-x-mips : FAIL gcc version 11.2.0 (Debian 11.2.0-18) > builtin-buildid-list.c: In function 'buildid__map_cb': > builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=] > 32 | printf("%s %16lx %16lx", bid_buf, map->start, map->end); > | ~~~~^ ~~~~~~~~~~ > | | | > | long unsigned int u64 {aka long long unsigned int} > | %16llx > builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=] > 32 | printf("%s %16lx %16lx", bid_buf, map->start, map->end); > | ~~~~^ ~~~~~~~~ > | | | > | long unsigned int u64 {aka long long unsigned int} > | %16llx > cc1: all warnings being treated as errors > 29 23.06 debian:experimental-x-mips64 : Ok mips64-linux-gnuabi64-gcc (Debian 10.2.1-6) 10.2.1 20210110 > 30 6.08 debian:experimental-x-mipsel : FAIL gcc version 11.2.0 (Debian 11.2.0-18) > builtin-buildid-list.c: In function 'buildid__map_cb': > builtin-buildid-list.c:32:24: error: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=] > 32 | printf("%s %16lx %16lx", bid_buf, map->start, map->end); > | ~~~~^ ~~~~~~~~~~ > | | | > | long unsigned int u64 {aka long long unsigned int} > | %16llx > builtin-buildid-list.c:32:30: error: format '%lx' expects argument of type 'long unsigned int', but argument 4 has type 'u64' {aka 'long long unsigned int'} [-Werror=format=] > 32 | printf("%s %16lx %16lx", bid_buf, map->start, map->end); > | ~~~~^ ~~~~~~~~ > | | | > | long unsigned int u64 {aka long long unsigned int} > | %16llx > cc1: all warnings being treated as errors > > > These should use PRIx64, etc. > > - Arnaldo