From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750806AbdAXT7T (ORCPT ); Tue, 24 Jan 2017 14:59:19 -0500 Received: from mail-ot0-f182.google.com ([74.125.82.182]:36842 "EHLO mail-ot0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbdAXT7R (ORCPT ); Tue, 24 Jan 2017 14:59:17 -0500 MIME-Version: 1.0 In-Reply-To: <1485285847-7006-1-git-send-email-bhumirks@gmail.com> References: <1485285847-7006-1-git-send-email-bhumirks@gmail.com> From: Dan Williams Date: Tue, 24 Jan 2017 11:58:27 -0800 Message-ID: Subject: Re: [PATCH] nvdimm: constify device_type structures To: Bhumika Goyal Cc: Julia Lawall , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2017 at 11:24 AM, Bhumika Goyal wrote: > Declare device_type structure as const as it is only stored in the > type field of a device structure. This field is of type const, so add > const to declaration of device_type structure. > > File size before: > text data bss dec hex filename > 19278 3199 16 22493 57dd nvdimm/namespace_devs.o > > File size after: > text data bss dec hex filename > 19929 3160 16 23105 5a41 nvdimm/namespace_devs.o > > Signed-off-by: Bhumika Goyal Looks good to me, thanks, applied for 4.11.