From: Dan Williams <dan.j.williams@intel.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Jane Chu <jane.chu@oracle.com>, Christoph Hellwig <hch@lst.de>,
Vivek Goyal <vgoyal@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH v10 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode
Date: Fri, 13 May 2022 15:09:32 -0700 [thread overview]
Message-ID: <CAPcyv4g8Tkx_b_Rs1WeAeV1knxV-z2r7Gmf56b8XN=CTyj6RVQ@mail.gmail.com> (raw)
In-Reply-To: <165247892149.4131000.9240706498758561525.stgit@dwillia2-desk3.amr.corp.intel.com>
On Fri, May 13, 2022 at 2:56 PM Dan Williams <dan.j.williams@intel.com> wrote:
>
> From: Jane Chu <jane.chu@oracle.com>
>
> Up till now, dax_direct_access() is used implicitly for normal
> access, but for the purpose of recovery write, dax range with
> poison is requested. To make the interface clear, introduce
> enum dax_access_mode {
> DAX_ACCESS,
> DAX_RECOVERY_WRITE,
> }
> where DAX_ACCESS is used for normal dax access, and
> DAX_RECOVERY_WRITE is used for dax recovery write.
>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Jane Chu <jane.chu@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Cc: Vivek Goyal <vgoyal@redhat.com>
> Cc: Mike Snitzer <snitzer@redhat.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
[..]
> diff --git a/tools/testing/nvdimm/pmem-dax.c b/tools/testing/nvdimm/pmem-dax.c
> index af19c85558e7..dcc328eba811 100644
> --- a/tools/testing/nvdimm/pmem-dax.c
> +++ b/tools/testing/nvdimm/pmem-dax.c
> @@ -8,7 +8,8 @@
> #include <nd.h>
>
> long __pmem_direct_access(struct pmem_device *pmem, pgoff_t pgoff,
> - long nr_pages, void **kaddr, pfn_t *pfn)
> + long nr_pages, enum dax_access_mode mode, void **kaddr,
> + pfn_t *pfn)
Local build test reports:
tools/testing/nvdimm/pmem-dax.c:11:53: error: parameter 4 (‘mode’) has
incomplete type
11 | long nr_pages, enum dax_access_mode mode, void **kaddr,
| ~~~~~~~~~~~~~~~~~~~~~^~~~
...so need to include linux/dax.h in this file now for that definition.
next prev parent reply other threads:[~2022-05-13 22:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 22:45 [PATCH v9 0/7] DAX poison recovery Jane Chu
2022-04-22 22:45 ` [PATCH v9 1/7] acpi/nfit: rely on mce->misc to determine poison granularity Jane Chu
2022-04-22 22:45 ` [PATCH v9 2/7] x86/mce: relocate set{clear}_mce_nospec() functions Jane Chu
2022-04-28 13:09 ` Borislav Petkov
2022-05-13 21:41 ` [PATCH v10 " Dan Williams
2022-05-16 18:21 ` [PATCH v11 " Dan Williams
2022-05-16 20:30 ` [PATCH v9 " Dan Williams
2022-04-22 22:45 ` [PATCH v9 3/7] mce: fix set_mce_nospec to always unmap the whole page Jane Chu
2022-04-22 23:25 ` Dan Williams
2022-05-11 3:56 ` Dan Williams
2022-05-11 8:44 ` Borislav Petkov
2022-05-11 17:17 ` Luck, Tony
2022-05-13 3:41 ` Dan Williams
2022-05-16 18:38 ` [PATCH v10 " Dan Williams
2022-04-22 22:45 ` [PATCH v9 4/7] dax: introduce DAX_RECOVERY_WRITE dax access mode Jane Chu
2022-04-23 5:20 ` Christoph Hellwig
2022-05-13 21:55 ` [PATCH v10 " Dan Williams
2022-05-13 22:09 ` Dan Williams [this message]
2022-05-13 22:10 ` [PATCH v11 " Dan Williams
2022-05-16 12:40 ` [PATCH v10 " Vivek Goyal
2022-04-22 22:45 ` [PATCH v9 5/7] dax: add .recovery_write dax_operation Jane Chu
2022-04-22 22:45 ` [PATCH v9 6/7] pmem: refactor pmem_clear_poison() Jane Chu
2022-04-22 22:45 ` [PATCH v9 7/7] pmem: implement pmem_recovery_write() Jane Chu
2022-04-23 5:21 ` Christoph Hellwig
2022-05-13 22:13 ` [PATCH v10 " Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4g8Tkx_b_Rs1WeAeV1knxV-z2r7Gmf56b8XN=CTyj6RVQ@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=snitzer@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).