From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752187AbdGADzZ (ORCPT ); Fri, 30 Jun 2017 23:55:25 -0400 Received: from mail-yw0-f173.google.com ([209.85.161.173]:33403 "EHLO mail-yw0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbdGADzY (ORCPT ); Fri, 30 Jun 2017 23:55:24 -0400 MIME-Version: 1.0 In-Reply-To: <293ee143dcabb386ca06b384a384171c256a2ecc.1498810220.git.jerry.hoemann@hpe.com> References: <293ee143dcabb386ca06b384a384171c256a2ecc.1498810220.git.jerry.hoemann@hpe.com> From: Dan Williams Date: Fri, 30 Jun 2017 20:55:22 -0700 Message-ID: Subject: Re: [PATCH v4 3/6] libnvdimm, acpi, nfit: Add bus level dsm mask for pass thru. To: Jerry Hoemann Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 30, 2017 at 9:09 AM, Jerry Hoemann wrote: > Add a bus level dsm_mask to nvdimm_bus_descriptor to allow the passthru > calling mechanism to specify a different mask from the cmd_mask. > > Populate bus_dsm_mask and use it to filter dsm calls that user can > make through the pass thru interface. > > Signed-off-by: Jerry Hoemann > --- > drivers/acpi/nfit/core.c | 8 ++++++++ > include/linux/libnvdimm.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index b46fca2..5e4c137 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -253,6 +253,8 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm, > cmd_name = nvdimm_bus_cmd_name(cmd); > cmd_mask = nd_desc->cmd_mask; > dsm_mask = cmd_mask; > + if (cmd == ND_CMD_CALL) > + dsm_mask = nd_desc->bus_dsm_mask; > desc = nd_cmd_bus_desc(cmd); > uuid = to_nfit_uuid(NFIT_DEV_BUS); > handle = adev->handle; > @@ -1613,6 +1615,7 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) > struct nvdimm_bus_descriptor *nd_desc = &acpi_desc->nd_desc; > const u8 *uuid = to_nfit_uuid(NFIT_DEV_BUS); > struct acpi_device *adev; > + unsigned long dsm_mask; > int i; > > nd_desc->cmd_mask = acpi_desc->bus_cmd_force_en; > @@ -1624,6 +1627,11 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc) > if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i)) > set_bit(i, &nd_desc->cmd_mask); > set_bit(ND_CMD_CALL, &nd_desc->cmd_mask); > + > + dsm_mask = 0x3bf; I went ahead and fixed this up to use dsm_mask defined like this: + dsm_mask = + (1 << ND_CMD_ARS_CAP) | + (1 << ND_CMD_ARS_START) | + (1 << ND_CMD_ARS_STATUS) | + (1 << ND_CMD_CLEAR_ERROR) | + (1 << NFIT_CMD_TRANSLATE_SPA) | + (1 << NFIT_CMD_ARS_INJECT_SET) | + (1 << NFIT_CMD_ARS_INJECT_CLEAR) | + (1 << NFIT_CMD_ARS_INJECT_GET); This drops function number 0 which userspace has no need to call.