From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
"Alexander Duyck" <alexander.h.duyck@intel.com>,
"Linux MM" <linux-mm@kvack.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support
Date: Fri, 14 Sep 2018 10:40:52 -0700 [thread overview]
Message-ID: <CAPcyv4gj1E75rZ7kUVfO--CDK_u=-Qci06qmu+cQhaH8V=szGA@mail.gmail.com> (raw)
In-Reply-To: <20180914131420.GC27141@lst.de>
On Fri, Sep 14, 2018 at 6:14 AM, Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Sep 12, 2018 at 07:22:11PM -0700, Dan Williams wrote:
>> Given the fact that devm_memremap_pages() requires a percpu_ref that is
>> torn down by devm_memremap_pages_release() the current support for
>> mapping RAM is broken.
>
> I agree. Do you remember why we even added it in the first place?
It was initially a copy over from memremap() that catches these
attempts and returns a direct-map pointer.
next prev parent reply other threads:[~2018-09-14 17:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 2:22 [PATCH v5 0/7] mm: Merge hmm into devm_memremap_pages, mark GPL-only Dan Williams
2018-09-13 2:22 ` [PATCH v5 1/7] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams
2018-09-13 16:25 ` Logan Gunthorpe
2018-09-13 2:22 ` [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support Dan Williams
2018-09-13 16:10 ` Logan Gunthorpe
2018-09-14 13:14 ` Christoph Hellwig
2018-09-14 17:40 ` Dan Williams [this message]
2018-09-18 20:28 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 3/7] mm, devm_memremap_pages: Fix shutdown handling Dan Williams
2018-09-14 13:16 ` Christoph Hellwig
2018-09-14 17:25 ` Dan Williams
2018-09-18 20:28 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 4/7] mm, devm_memremap_pages: Add MEMORY_DEVICE_PRIVATE support Dan Williams
2018-09-14 13:18 ` Christoph Hellwig
2018-09-18 20:34 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 5/7] mm, hmm: Use devm semantics for hmm_devmem_{add, remove} Dan Williams
2018-09-14 13:18 ` Christoph Hellwig
2018-09-14 14:16 ` Jerome Glisse
2018-09-18 20:34 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 6/7] mm, hmm: Replace hmm_devmem_pages_create() with devm_memremap_pages() Dan Williams
2018-09-18 20:35 ` Jerome Glisse
2018-09-19 1:24 ` Balbir Singh
2018-09-13 2:22 ` [PATCH v5 7/7] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4gj1E75rZ7kUVfO--CDK_u=-Qci06qmu+cQhaH8V=szGA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).