From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1946185AbbDXXCU (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Apr 2015 19:02:20 -0400
Received: from mail-wi0-f175.google.com ([209.85.212.175]:37579 "EHLO
	mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S966964AbbDXXCS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Apr 2015 19:02:18 -0400
MIME-Version: 1.0
In-Reply-To: <553ABCA5.6050905@hp.com>
References: <20150418013256.25237.96403.stgit@dwillia2-desk3.amr.corp.intel.com>
	<20150418013541.25237.36797.stgit@dwillia2-desk3.amr.corp.intel.com>
	<553ABA06.90305@hp.com>
	<CAPcyv4hiUG1E8N3+jV5CajrOdPdtt2R+WtihVa2ouN_PUfnejQ@mail.gmail.com>
	<553ABCA5.6050905@hp.com>
Date: Fri, 24 Apr 2015 16:02:17 -0700
Message-ID: <CAPcyv4gmJA9sf_Udpc-Up4_=dRfHx3XqO+Y-0N3mHyZOMyAybg@mail.gmail.com>
Subject: Re: [Linux-nvdimm] [PATCH 05/21] nfit-test: manufactured NFITs for
 interface development
From: Dan Williams <dan.j.williams@intel.com>
To: Linda Knippers <linda.knippers@hp.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 24, 2015 at 2:59 PM, Linda Knippers <linda.knippers@hp.com> wrote:
> On 4/24/2015 5:50 PM, Dan Williams wrote:
>> On Fri, Apr 24, 2015 at 2:47 PM, Linda Knippers <linda.knippers@hp.com> wrote:
>>> On 4/17/2015 9:35 PM, Dan Williams wrote:
>>> :
>>>> diff --git a/drivers/block/nd/Kconfig b/drivers/block/nd/Kconfig
>>>> index 5fa74f124b3e..0106b3807202 100644
>>>> --- a/drivers/block/nd/Kconfig
>>>> +++ b/drivers/block/nd/Kconfig
>>>> @@ -41,4 +41,24 @@ config NFIT_ACPI
>>>>         register the platform-global NFIT blob with the core.  Also
>>>>         enables the core to craft ACPI._DSM messages for platform/dimm
>>>>         configuration.
>>>> +
>>>> +config NFIT_TEST
>>>> +     tristate "NFIT TEST: Manufactured NFIT for interface testing"
>>>> +     depends on DMA_CMA
>>>> +     depends on ND_CORE=m
>>>> +     depends on m
>>>> +     help
>>>> +       For development purposes register a manufactured
>>>> +       NFIT table to verify the resulting device model topology.
>>>> +       Note, this module arranges for ioremap_cache() to be
>>>> +       overridden locally to allow simulation of system-memory as an
>>>> +       io-memory-resource.
>>>> +
>>>> +       Note, this test expects to be able to find at least
>>>> +       256MB of CMA space (CONFIG_CMA_SIZE_MBYTES) or it will fail to
>>>
>>> It seems to actually be wanting >= 584MB.
>>
>> Ah, true, this Kconfig text is stale.  Will fix.
>
> Thanks.  One more question...
>
>> +#ifdef CONFIG_CMA_SIZE_MBYTES
>> +#define CMA_SIZE_MBYTES CONFIG_CMA_SIZE_MBYTES
>> +#else
>> +#define CMA_SIZE_MBYTES 0
>> +#endif
>> +
>> +static __init int nfit_test_init(void)
>> +{
>> +     int rc, i;
>> +
>> +     if (CMA_SIZE_MBYTES < 584) {
>> +             pr_err("need CONFIG_CMA_SIZE_MBYTES >= 584 to load\n");
>> +             return -EINVAL;
>> +     }
>> +
>
> Since the kernel takes a cma= boot parameter, it would be nice if
> this check is against what the kernel is using rather than the config
> option.  Is that possible?

Yeah, that would be more friendly.  I also think we can reduce the BLK
aperture sizes.  Since those don't need to be DAX capable they can
come from vmalloc memory rather than CMA.  I'll take a look.