From: Dan Williams <dan.j.williams@intel.com>
To: Guenter Roeck <groeck@google.com>
Cc: Kees Cook <keescook@chromium.org>,
kernelci@groups.io,
Guillaume Tucker <guillaume.tucker@collabora.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Mark Brown <broonie@kernel.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Matt Hart <matthew.hart@linaro.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Kevin Hilman <khilman@baylibre.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Nicholas Piggin <npiggin@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Adrian Reber <adrian@lisas.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Linux MM <linux-mm@kvack.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Richard Guy Briggs <rgb@redhat.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
info@kernelci.org
Subject: Re: next/master boot bisection: next-20190215 on beaglebone-black
Date: Tue, 16 Apr 2019 11:54:13 -0700 [thread overview]
Message-ID: <CAPcyv4gxk9xbsP3YSKzxu5Yp9FTefyxHc6xC33GwZ3Zf9_eeKA@mail.gmail.com> (raw)
In-Reply-To: <CABXOdTc5=J7ZFgbiwahVind-SNt7+G_-TVO=v-Y5SBVPLdUFog@mail.gmail.com>
On Thu, Apr 11, 2019 at 1:54 PM Guenter Roeck <groeck@google.com> wrote:
[..]
> > > Boot tests report
> > >
> > > Qemu test results:
> > > total: 345 pass: 345 fail: 0
> > >
> > > This is on top of next-20190410 with CONFIG_SHUFFLE_PAGE_ALLOCATOR=y
> > > and the known crashes fixed.
> >
> > In addition to CONFIG_SHUFFLE_PAGE_ALLOCATOR=y you also need the
> > kernel command line option "page_alloc.shuffle=1"
> >
> > ...so I doubt you are running with shuffling enabled. Another way to
> > double check is:
> >
> > cat /sys/module/page_alloc/parameters/shuffle
>
> Yes, you are right. Because, with it enabled, I see:
>
> Kernel command line: rdinit=/sbin/init page_alloc.shuffle=1 panic=-1
> console=ttyAMA0,115200 page_alloc.shuffle=1
> ------------[ cut here ]------------
> WARNING: CPU: 0 PID: 0 at ./include/linux/jump_label.h:303
> page_alloc_shuffle+0x12c/0x1ac
> static_key_enable(): static key 'page_alloc_shuffle_key+0x0/0x4' used
> before call to jump_label_init()
This looks to be specific to ARM never having had to deal with
DEFINE_STATIC_KEY_TRUE in the past.
I am able to avoid this warning by simply not enabling JUMP_LABEL
support in my build.
> Modules linked in:
> CPU: 0 PID: 0 Comm: swapper Not tainted
> 5.1.0-rc4-next-20190410-00003-g3367c36ce744 #1
> Hardware name: ARM Integrator/CP (Device Tree)
> [<c0011c68>] (unwind_backtrace) from [<c000ec48>] (show_stack+0x10/0x18)
> [<c000ec48>] (show_stack) from [<c07e9710>] (dump_stack+0x18/0x24)
> [<c07e9710>] (dump_stack) from [<c001bb1c>] (__warn+0xe0/0x108)
> [<c001bb1c>] (__warn) from [<c001bb88>] (warn_slowpath_fmt+0x44/0x6c)
> [<c001bb88>] (warn_slowpath_fmt) from [<c0b0c4a8>]
> (page_alloc_shuffle+0x12c/0x1ac)
> [<c0b0c4a8>] (page_alloc_shuffle) from [<c0b0c550>] (shuffle_store+0x28/0x48)
> [<c0b0c550>] (shuffle_store) from [<c003e6a0>] (parse_args+0x1f4/0x350)
> [<c003e6a0>] (parse_args) from [<c0ac3c00>] (start_kernel+0x1c0/0x488)
> [<c0ac3c00>] (start_kernel) from [<00000000>] ( (null))
>
> I'll re-run the test, but I suspect it will drown in warnings.
I slogged through getting a Beagle Bone Black up and running with a
Yocto build and it is not failing. I have tried apply the patches on
top of v5.1-rc5 as well as re-testing next-20190215 label, no
reproduction. The shuffle appears to avoid anything sensitive by
default, below are the shuffle actions that were taken relative to
iomem. Can someone with a failure reproduction please send me more
details about their configuration? It would also help to get a failing
boot log with the pr_debug() statements in mm/shuffle.c enabled to see
if the failure is correlated with any unexpected shuffle actions.
80000000-9fffffff : System RAM
80008000-809fffff : Kernel code
80b00000-812be523 : Kernel data
[ 0.086469] __shuffle_zone: swap: 0x81800 -> 0x99800
[ 0.086558] __shuffle_zone: swap: 0x82000 -> 0x88800
[ 0.086575] __shuffle_zone: swap: 0x82800 -> 0x89800
[ 0.086591] __shuffle_zone: swap: 0x83000 -> 0x89000
[ 0.086606] __shuffle_zone: swap: 0x83800 -> 0x8a800
[ 0.086621] __shuffle_zone: swap: 0x84000 -> 0x93800
[ 0.086636] __shuffle_zone: swap: 0x84800 -> 0x83000
[ 0.086651] __shuffle_zone: swap: 0x85000 -> 0x8f000
[ 0.086666] __shuffle_zone: swap: 0x85800 -> 0x88000
[ 0.086689] __shuffle_zone: swap: 0x86000 -> 0x84000
[ 0.086704] __shuffle_zone: swap: 0x86800 -> 0x8c800
[ 0.086719] __shuffle_zone: swap: 0x87000 -> 0x93000
[ 0.086735] __shuffle_zone: swap: 0x87800 -> 0x94000
[ 0.086751] __shuffle_zone: swap: 0x88000 -> 0x90800
[ 0.086766] __shuffle_zone: swap: 0x88800 -> 0x9d000
[ 0.086781] __shuffle_zone: swap: 0x89000 -> 0x82800
[ 0.086796] __shuffle_zone: swap: 0x89800 -> 0x95800
[ 0.086811] __shuffle_zone: swap: 0x8a000 -> 0x98000
[ 0.086826] __shuffle_zone: swap: 0x8a800 -> 0x89000
[ 0.086842] __shuffle_zone: swap: 0x8b000 -> 0x81800
[ 0.086857] __shuffle_zone: swap: 0x8b800 -> 0x88800
[ 0.086872] __shuffle_zone: swap: 0x8c000 -> 0x8a000
[ 0.086891] __shuffle_zone: swap: 0x8c800 -> 0x84800
[ 0.086906] __shuffle_zone: swap: 0x8d000 -> 0x95000
[ 0.086921] __shuffle_zone: swap: 0x8d800 -> 0x8d000
[ 0.086935] __shuffle_zone: swap: 0x8e000 -> 0x8e800
[ 0.086950] __shuffle_zone: swap: 0x8e800 -> 0x99000
[ 0.086964] __shuffle_zone: swap: 0x8f000 -> 0x8d000
[ 0.086979] __shuffle_zone: swap: 0x90000 -> 0x91000
[ 0.086994] __shuffle_zone: swap: 0x90800 -> 0x83000
[ 0.087009] __shuffle_zone: swap: 0x91000 -> 0x91800
[ 0.087025] __shuffle_zone: swap: 0x91800 -> 0x8d800
[ 0.087040] __shuffle_zone: swap: 0x92000 -> 0x86800
[ 0.087054] __shuffle_zone: swap: 0x92800 -> 0x92000
[ 0.087070] __shuffle_zone: swap: 0x93000 -> 0x91000
[ 0.087088] __shuffle_zone: swap: 0x93800 -> 0x85000
[ 0.087103] __shuffle_zone: swap: 0x94000 -> 0x8b800
[ 0.087117] __shuffle_zone: swap: 0x94800 -> 0x96000
[ 0.087132] __shuffle_zone: swap: 0x95000 -> 0x91000
[ 0.087147] __shuffle_zone: swap: 0x95800 -> 0x8e000
[ 0.087161] __shuffle_zone: swap: 0x96000 -> 0x95800
[ 0.087179] __shuffle_zone: swap: 0x96800 -> 0x8c800
[ 0.087193] __shuffle_zone: swap: 0x97000 -> 0x89000
[ 0.087208] __shuffle_zone: swap: 0x97800 -> 0x85000
[ 0.087224] __shuffle_zone: swap: 0x98000 -> 0x85000
[ 0.087239] __shuffle_zone: swap: 0x98800 -> 0x93000
[ 0.087255] __shuffle_zone: swap: 0x99000 -> 0x94800
[ 0.087269] __shuffle_zone: swap: 0x99800 -> 0x94000
next prev parent reply other threads:[~2019-04-16 18:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 18:20 next/master boot bisection: next-20190215 on beaglebone-black kernelci.org bot
2019-02-15 18:43 ` Andrew Morton
2019-02-15 18:51 ` Mark Brown
2019-02-15 19:00 ` Andrew Morton
2019-02-16 6:21 ` Stephen Rothwell
2019-02-26 23:59 ` Andrew Morton
2019-02-27 0:04 ` Dan Williams
2019-02-28 23:14 ` Andrew Morton
2019-02-28 23:55 ` Dan Williams
2019-03-01 8:25 ` Guillaume Tucker
2019-03-01 10:40 ` Mike Rapoport
2019-03-01 11:49 ` Mark Brown
2019-03-01 20:41 ` Andrew Morton
2019-03-01 21:04 ` Guillaume Tucker
2019-03-01 23:23 ` Dan Williams
2019-03-06 10:14 ` Guillaume Tucker
2019-03-06 14:05 ` Mike Rapoport
2019-03-07 9:16 ` Guillaume Tucker
2019-03-07 15:43 ` Dan Williams
2019-04-10 22:52 ` Kees Cook
2019-04-11 16:42 ` Guenter Roeck
2019-04-11 17:35 ` Kees Cook
2019-04-11 20:08 ` Guenter Roeck
2019-04-11 20:22 ` Dan Williams
2019-04-11 20:53 ` Guenter Roeck
2019-04-16 18:54 ` Dan Williams [this message]
2019-04-16 19:17 ` Mathieu Desnoyers
2019-04-16 19:25 ` Mathieu Desnoyers
2019-04-16 19:45 ` Mathieu Desnoyers
2019-04-16 19:33 ` Guenter Roeck
2019-04-16 20:37 ` Dan Williams
2019-04-16 21:04 ` Guenter Roeck
2019-04-17 3:30 ` Kees Cook
2019-04-16 20:05 ` Mathieu Desnoyers
2019-04-11 20:49 ` Mike Rapoport
2019-03-01 11:45 ` Mark Brown
2019-03-01 9:02 ` Vlastimil Babka
2019-02-18 9:44 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4gxk9xbsP3YSKzxu5Yp9FTefyxHc6xC33GwZ3Zf9_eeKA@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=hannes@cmpxchg.org \
--cc=info@kernelci.org \
--cc=keescook@chromium.org \
--cc=kernelci@groups.io \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@dominikbrodowski.net \
--cc=mathieu.desnoyers@efficios.com \
--cc=matthew.hart@linaro.org \
--cc=mhocko@suse.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rgb@redhat.com \
--cc=rppt@linux.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=tomeu.vizoso@collabora.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).