From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9392BC433E2 for ; Tue, 21 Jul 2020 21:35:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F3CC2068F for ; Tue, 21 Jul 2020 21:35:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="fpVtZ5vr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731198AbgGUVfX (ORCPT ); Tue, 21 Jul 2020 17:35:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731001AbgGUVfW (ORCPT ); Tue, 21 Jul 2020 17:35:22 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A9C3C0619DD for ; Tue, 21 Jul 2020 14:35:22 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id f12so23063603eja.9 for ; Tue, 21 Jul 2020 14:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pUG6c39OxzQ8IxUpaaU1wklcT+ZDA+H9y6wrizuP1IQ=; b=fpVtZ5vr/bl4gwJZ660px4Eks0k0bFp5F00leanT0uPcOTgmoIVnokm+ua/STwjYYU 9V0Le4JZ7BwvhlVhFXG7Dk6uDAL6avESZPtpqEXkGTTx7a0UAf5JI5cLpd6qdzoiV4pc OVZuIyutP3UYG7RX+wyFYILhVk9K+2Bf5Rkkvu4t2vAnzZGCeHNgevlyRyPEZajZKVWb LJx3ccmgwBWG3aOFencD4vIdccFY+YTJ+h0qq1fXsevTE8RiRwpAEsyonT9mp1hrf2yM MP/VlkjZk9cKmlm2n20iRO2IPBPgE/cY4y2TN8o594hbmdnreaFuvl/GYgmWrPMBcdz8 wb2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pUG6c39OxzQ8IxUpaaU1wklcT+ZDA+H9y6wrizuP1IQ=; b=MwbN9Kp5ysrRhXJZVan89JMSOorik1+/ItmdNUsYzTmSjj+ykm8734xE+Nr/k8QuNg CNWHbwTCFX13sIt2wa0LQXtLjZZCE31pfZZuyVwbq7ZuQa91uosbmgJ6sZksakTBKBHl Y7r2KbLMKafZzw93xKBkaqodbboS1AB1wN2Lm5zkHr8XUE/yDhvWfSr83xVSlooVI5L1 8m8/tw/3Rmy1JbbAQKTv9W9xsq5TKqZUr8nkKBlAQFZY0Ki1R4K2A7fdKh/FsSaBcpjr 4ab6MeK0hCjJXUDtV+YZH/OYBnWDmxgSbsadl6lB4DOGGW8cQOhnHFbohgVP+h6wir2O iKzg== X-Gm-Message-State: AOAM531CExYMZ/Cak5kPItOxt4hwvZClzsy5R3uNY/qyTPBQD8EFmpBP TRD0AUEzul+lDvlOc07I43qIHVD2QDsOfXHLb22zUA== X-Google-Smtp-Source: ABdhPJybQSo8dZkcp7h1w6spji8sbGsdM1tSDGznEquhq3K0DjuECAckH4y+EAugj+bvtxFnwhrKgK1z4PC3S6mLDA0= X-Received: by 2002:a17:906:1a54:: with SMTP id j20mr26707162ejf.455.1595367320599; Tue, 21 Jul 2020 14:35:20 -0700 (PDT) MIME-Version: 1.0 References: <159534667974.28840.2045034360240786644.stgit@djiang5-desk3.ch.intel.com> <20200721162858.GA2139881@kroah.com> In-Reply-To: <20200721162858.GA2139881@kroah.com> From: Dan Williams Date: Tue, 21 Jul 2020 14:35:09 -0700 Message-ID: Subject: Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver To: Greg KH Cc: Dave Jiang , Vinod Koul , "Dey, Megha" , maz@kernel.org, Bjorn Helgaas , "Rafael J. Wysocki" , Thomas Gleixner , "H. Peter Anvin" , Alex Williamson , Jacob jun Pan , "Raj, Ashok" , Jason Gunthorpe , Yi L Liu , Baolu Lu , "Tian, Kevin" , Sanjay K Kumar , "Luck, Tony" , Jing Lin , kwankhede@nvidia.com, eric.auger@redhat.com, parav@mellanox.com, Dave Hansen , netanelg@mellanox.com, shahafs@mellanox.com, yan.y.zhao@linux.intel.com, Paolo Bonzini , Samuel Ortiz , mona.hossain@intel.com, dmaengine@vger.kernel.org, Linux Kernel Mailing List , X86 ML , linux-pci@vger.kernel.org, KVM list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 9:29 AM Greg KH wrote: > > On Tue, Jul 21, 2020 at 09:02:15AM -0700, Dave Jiang wrote: > > v2: > > "RFC" to me means "I don't really think this is mergable, so I'm > throwing it out there." Which implies you know it needs more work > before others should review it as you are not comfortable with it :( There's full blown reviewed-by from me on the irq changes. The VFIO / mdev changes looked ok to me, but I did not feel comfortable / did not have time to sign-off on them. At the same time I did not see much to be gained to keeping those internal. So "RFC" in this case is a bit modest. It's more internal reviewer said this looks like it is going in the right direction, but wants more community discussion on the approach. > So, back-of-the-queue you go... Let's consider this not RFC in that context. The drivers/base/ pieces have my review for you, the rest are dmaengine and vfio subsystem concerns that could use some commentary.