From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FECEC3F68F for ; Tue, 17 Dec 2019 01:18:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 159712072D for ; Tue, 17 Dec 2019 01:18:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="ZML1YlPf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfLQBSM (ORCPT ); Mon, 16 Dec 2019 20:18:12 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:33851 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbfLQBSM (ORCPT ); Mon, 16 Dec 2019 20:18:12 -0500 Received: by mail-oi1-f194.google.com with SMTP id l136so4874934oig.1 for ; Mon, 16 Dec 2019 17:18:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gQlxuukx7ZYSQZmNiora65lLQtsKLdrcwl34+cNn20I=; b=ZML1YlPfc4X1lcJ2MEbwwuNUKRegQeZ1YWVhElf9aNxBihtxGgtQUSJL6yDQFiM2rL y/lqLODFRtPxZRmMnuW9B1kUabr/9AGAClBFwX0znrz0wJsyiRGYNjaCepLaxTeWBNBX SiVi4m+QZl/9PWp2i/Gej2UCGi0YWW8IAKtvPz0U5FZS7Amc68+vfcu8BwfvUeSscuVF kUfLmgSgMrtPuf0Vc+yijMqQUx6yzFsgm3vk0Y0emxOOEaff735UHNk7VQWa65n7NFlF 8COOeab+RZx6zAqGm2MLWzNGm3Zrmk68eKfmuXeXklk3Q1r3cMwqb0r/fmpqOyWsTBPs vwMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gQlxuukx7ZYSQZmNiora65lLQtsKLdrcwl34+cNn20I=; b=sl/3Tk1vJSEXq1fiavhlg5daHY4lztepXB92OtR+RLRvEZCpNuv8jm6dy7xK14i6Pc AiOiSTG6UoNf/bTvsaeySIAs316CPxPksJfVf1MkSExyt0LjAaTK/PU9nYJShWwJgoiJ DKSly4aEva8hrvt9mgpyy0fNjv/nTZivzvzI9gg6U2bcbYhnQpJG1lfuDmlqgpm8euEv Xa1N7dH2kmcBkYGHzpH4cOIpZKBzHYdWoXQNnKTYZIVEe8+50UGPJmQ7UiFg/El/hA/5 +k+UgVvnVUTFeueBWmkA3/Yka8Vr8kr1s0P+8QaOaVy4DAeWMxKGILeyvN/ZcJEQHmO/ Er3A== X-Gm-Message-State: APjAAAUjP2JOLE/dFP+lRt+xBWdKJjwzho+2mx9tgSAF+bXRWlpXI903 nH+ihNEUNzj/1eH8A4N85Vd+fGT/q/hfluPrrdRzZw== X-Google-Smtp-Source: APXvYqyALUz6qMsfZ8CPqN2DhPrepKX8K+FY6z1DAn5DPLETrrCCRCs0bMrUATx7fxnThIB2URczhSpUKLEZ1cMtY+s= X-Received: by 2002:aca:c354:: with SMTP id t81mr1065974oif.149.1576545490980; Mon, 16 Dec 2019 17:18:10 -0800 (PST) MIME-Version: 1.0 References: <20191211231758.22263-1-jsnitsel@redhat.com> <20191211235455.24424-1-jsnitsel@redhat.com> <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> In-Reply-To: <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> From: Dan Williams Date: Mon, 16 Dec 2019 17:18:00 -0800 Message-ID: Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init To: Jarkko Sakkinen Cc: Jerry Snitselaar , Linux Kernel Mailing List , Christian Bundy , Peter Huewe , Jason Gunthorpe , Stefan Berger , stable , linux-integrity@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 16, 2019 at 4:59 PM Jarkko Sakkinen wrote: > > On Wed, 2019-12-11 at 16:54 -0700, Jerry Snitselaar wrote: > > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when > > issuing commands to the tpm during initialization, just reserve the > > chip after wait_startup, and release it when we are ready to call > > tpm_chip_register. > > > > Cc: Christian Bundy > > Cc: Dan Williams > > Cc: Peter Huewe > > Cc: Jarkko Sakkinen > > Cc: Jason Gunthorpe > > Cc: Stefan Berger > > Cc: stable@vger.kernel.org > > Cc: linux-integrity@vger.kernel.org > > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") > > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's") > > Signed-off-by: Jerry Snitselaar > > I pushed to my master with minor tweaks and added my tags. > > Please check before I put it to linux-next. I don't see it yet here: http://git.infradead.org/users/jjs/linux-tpmdd.git/shortlog/refs/heads/master However, I wanted to make sure you captured that this does *not* fix the interrupt issue. I.e. make sure you remove the "Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")" tag. With that said, are you going to include the revert of: 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's ...in your -rc3 pull?