From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94B3AC2D0BF for ; Wed, 18 Dec 2019 23:31:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 69AE921582 for ; Wed, 18 Dec 2019 23:31:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="aADuHTHV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfLRXbg (ORCPT ); Wed, 18 Dec 2019 18:31:36 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:36744 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726561AbfLRXbg (ORCPT ); Wed, 18 Dec 2019 18:31:36 -0500 Received: by mail-oi1-f196.google.com with SMTP id c16so2144542oic.3 for ; Wed, 18 Dec 2019 15:31:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fUytKbh3fxwQeY78Sh0bP3Ypu5vGalHc1spY/K/2hYw=; b=aADuHTHVDgDJIjYoRrFQtvCtQgjeTd6MHEuYXKaMBoChVpakmW017w1NLtNmg/nZ4l H5v1X8hB8CMByDOWpfXPWHofB+iJSW9nDapGGfjLokjZE5hOW31GOpyjEraT6a1DZeal W8GRIKnqG1PnBIys7m7zgJ0N6urSMEDsbWhgefJGgzaKP2bVaW181BgoAPKVD3VlNpRh V/S9GeauYsL1CSHx6ZScqAWAPCiRrRdVqfD8wGeoepbfxNi3EZSoK8QPz2hpkJEffPiC FMAz8yU4Zkloy5zq2XEwBj4Ht0LLW3Wc8GNqBQuwiFisiPGIeWod2EcIsTsENymsc+97 NtoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fUytKbh3fxwQeY78Sh0bP3Ypu5vGalHc1spY/K/2hYw=; b=ArCqc7yMmjZ2lvdedFktBWAILdOEnIcdVzS+pBTanzXHIVT/t/KqArBACb7MrgMc9M fiLD7tH5MuJ3WKlK9/8r3RTupXVe1ZvKQTfaqGRTaRBpdpMzEHH/1qkBKxFJMi6UrZCV l6U31rS4I+yJgQQ1cFUip/52hvuEvQgn3JrkCIWzdJze9idFTPRXkA+z2aTUHxa2XFSn TQVPt5EZhi292hTE4egTx8KFSDLuCjEqgB9AWroezmim82302kLBuGp/q69wWPNhnCKA TtfPioxz3113X65ayb8pSbnOdt7rZihiOJhoIHCx5+/hZaHNbwXSuq06o3HUu3IkUAx3 BGAg== X-Gm-Message-State: APjAAAWttNu5l3CsDjjnOS6Xbh7pfdv+7CGjtwa9S9IKyUMQYqRmswtV 1G5i40QjIVMOfdk5PN9HHB472NcfKnDSGgis/DWgbg== X-Google-Smtp-Source: APXvYqzEXrvpAjwiv2G/9Vv+SQnMlU3rni98xmIEIgWEgRhXsiBl5svGAoocWfD5bq9Vmw3xbgHM/CcuxdesXarEq8Q= X-Received: by 2002:aca:4850:: with SMTP id v77mr1569292oia.70.1576711894829; Wed, 18 Dec 2019 15:31:34 -0800 (PST) MIME-Version: 1.0 References: <20191211231758.22263-1-jsnitsel@redhat.com> <20191211235455.24424-1-jsnitsel@redhat.com> <5aef0fbe28ed23b963c53d61445b0bac6f108642.camel@linux.intel.com> <20191217020022.knh7uxt4pn77wk5m@cantor> <5d0763334def7d7ae1e7cf931ef9b14184dce238.camel@linux.intel.com> <20191217171844.huqlj5csr262zkkk@cantor> <37f4ed0d6145dbe1e8724a5d05d0da82b593bf9c.camel@linux.intel.com> In-Reply-To: <37f4ed0d6145dbe1e8724a5d05d0da82b593bf9c.camel@linux.intel.com> From: Dan Williams Date: Wed, 18 Dec 2019 15:31:23 -0800 Message-ID: Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init To: Jarkko Sakkinen Cc: Jerry Snitselaar , Linux Kernel Mailing List , Christian Bundy , Peter Huewe , Jason Gunthorpe , Stefan Berger , stable , linux-integrity@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 18, 2019 at 3:07 PM Jarkko Sakkinen wrote: > > On Tue, 2019-12-17 at 10:18 -0700, Jerry Snitselaar wrote: > > On Tue Dec 17 19, Jarkko Sakkinen wrote: > > > On Mon, 2019-12-16 at 18:14 -0800, Dan Williams wrote: > > > > On Mon, Dec 16, 2019 at 6:00 PM Jerry Snitselaar wrote: > > > > > On Mon Dec 16 19, Dan Williams wrote: > > > > > > On Mon, Dec 16, 2019 at 4:59 PM Jarkko Sakkinen > > > > > > wrote: > > > > > > > On Wed, 2019-12-11 at 16:54 -0700, Jerry Snitselaar wrote: > > > > > > > > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when > > > > > > > > issuing commands to the tpm during initialization, just reserve the > > > > > > > > chip after wait_startup, and release it when we are ready to call > > > > > > > > tpm_chip_register. > > > > > > > > > > > > > > > > Cc: Christian Bundy > > > > > > > > Cc: Dan Williams > > > > > > > > Cc: Peter Huewe > > > > > > > > Cc: Jarkko Sakkinen > > > > > > > > Cc: Jason Gunthorpe > > > > > > > > Cc: Stefan Berger > > > > > > > > Cc: stable@vger.kernel.org > > > > > > > > Cc: linux-integrity@vger.kernel.org > > > > > > > > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") > > > > > > > > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's") > > > > > > > > Signed-off-by: Jerry Snitselaar > > > > > > > > > > > > > > I pushed to my master with minor tweaks and added my tags. > > > > > > > > > > > > > > Please check before I put it to linux-next. > > > > > > > > > > > > I don't see it yet here: > > > > > > > > > > > > http://git.infradead.org/users/jjs/linux-tpmdd.git/shortlog/refs/heads/master > > > > > > > > > > > > However, I wanted to make sure you captured that this does *not* fix > > > > > > the interrupt issue. I.e. make sure you remove the "Fixes: > > > > > > 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")" > > > > > > tag. > > > > > > > > > > > > With that said, are you going to include the revert of: > > > > > > > > > > > > 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts > > > > > > > > > > Dan, with the above reverted do you still get the screaming interrupt? > > > > > > > > Yes, the screaming interrupt goes away, although it is replaced by > > > > these messages when the driver starts: > > > > > > > > [ 3.725131] tpm_tis IFX0740:00: 2.0 TPM (device-id 0x1B, rev-id 16) > > > > [ 3.725358] tpm tpm0: tpm_try_transmit: send(): error -5 > > > > [ 3.725359] tpm tpm0: [Firmware Bug]: TPM interrupt not working, > > > > polling instead > > > > > > > > If the choice is "error message + polled-mode" vs "pinning a cpu with > > > > interrupts" I'd accept the former, but wanted Jarkko with his > > > > maintainer hat to weigh in. > > > > > > > > Is there a simple sanity check I can run to see if the TPM is still > > > > operational in this state? > > > > > > What about T490S? > > > > > > /Jarkko > > > > > > > Hi Jarkko, I'm waiting to hear back from the t490s user, but I imagine > > it still has the problem as well. > > > > Christian, were you able to try this patch and verify it still > > resolves the issue you were having with the kernel failing to get the > > timeouts and durations from the tpm? > > Including those reverts would be a bogus change at this point. I'm failing to see how you arrived at that conclusion. > The fix that I already applied obviously fixes an issue even if > it does not fix all the issues. These patches take a usable system and make it unusable: 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's ...they need to be reverted, or the regression needs to be fixed, but asserting that you fixed something else unrelated does not help.