From: Dan Williams <email@example.com> To: Linus Torvalds <firstname.lastname@example.org> Cc: Rasmus Villemoes <email@example.com>, Thomas Gleixner <firstname.lastname@example.org>, Will Deacon <email@example.com>, Ingo Molnar <firstname.lastname@example.org>, stable <email@example.com>, Linux Kernel Mailing List <firstname.lastname@example.org> Subject: Re: [PATCH] linux/nospec.h: allow index argument to have const-qualified type Date: Thu, 15 Feb 2018 13:56:22 -0800 Message-ID: <CAPcyv4hFn7jXLY43xTVPgzXVjECkpqhuj24mn5XXAyjiJq3Hyg@mail.gmail.com> (raw) In-Reply-To: <CA+55aFzYyWLiWb_O3KFZiJAZPzoopaa2cuj8ByWDi4ERjg0ZHw@mail.gmail.com> On Thu, Feb 15, 2018 at 12:59 PM, Linus Torvalds <email@example.com> wrote: > On Thu, Feb 15, 2018 at 11:52 AM, Rasmus Villemoes > <firstname.lastname@example.org> wrote: >> >> This way, we can allow index to have const-qualified type, which will in >> some cases avoid the need for introducing a local copy of index of >> non-const qualified type. > > Ack. > > That said, looking at this header file, I find a couple of of other issues.. > > (a) we should just remove the array_index_mask_nospec_check() thing. > > (b) once fixed, there's no reason for that extra "_s" variable in > array_index_nospec() > > That (a) thing causes horrible code generation, and is pointless and wrong. > > The "wrong" part is because it wants about "index" being larger than > LONG_MAX, and that's really stupid and wrong, because by *definition* > we don't trust index and it came from user space. The whole point was > that array_index_nospec() would limit those things! > > Yes, it's true that the compiler may optimize that warning away if the > type of 'index' is such that it cannot happen, but that doesn't make > the warning any more valid. > > It is only the sign of *size* that can matter and be an issue. > HOWEVER, even then it's wrong, because if "size" is of a signed type, > the check in WARN_ONCE is pure garbage. > > To make matters worse, that warning means that > array_index_mask_nospec_check() currently uses it's arguments twice. > It so happens that the only current use of that macro is ok with that, > because it's being extra careful, but it's *WRONG*. Macros that look > like functions should not use arguments twice. Yes, that piece is new and I should have noticed that breakage when I reviewed that patch from Will. > > So (a) is just wrong right now. It's better to just remove it. > > A valid warning *might* be > > WARN_ONCE((long)(size) < 0, "array_index_mask only works for sizes > that fit in a positive long"); > > but honestly, it's just not worth the code generation pain. So I don't mind removing it, but I don't think it is garbage. It's there purely as a notification to the odd kernel developer that wants to pass "insane" index values, It compiles away in most cases because all current users are sane and have indexes that are right sized. It also used to be the case that it was only used when the arch did not provide a custom array_index_mask_nospec(), but now that it is "on all the time" I do think it is in the way.
next prev parent reply index Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-02-15 13:27 [PATCH] posix-timers: Protect posix clock array access against speculation Thomas Gleixner 2018-02-15 14:05 ` Rasmus Villemoes 2018-02-15 14:39 ` Dan Williams 2018-02-15 14:53 ` Thomas Gleixner 2018-02-15 16:21 ` [PATCH V2] " Thomas Gleixner 2018-02-15 17:01 ` Peter Zijlstra 2018-03-07 18:13 ` Dan Williams 2018-03-22 11:34 ` [tip:timers/urgent] " tip-bot for Thomas Gleixner 2018-02-15 19:52 ` [PATCH] linux/nospec.h: allow index argument to have const-qualified type Rasmus Villemoes 2018-02-15 20:59 ` Linus Torvalds 2018-02-15 21:56 ` Dan Williams [this message] 2018-02-15 22:03 ` Linus Torvalds 2018-02-15 22:08 ` Dan Williams
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAPcyv4hFn7jXLY43xTVPgzXVjECkpqhuj24mn5XXAyjiJq3Hyg@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com firstname.lastname@example.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox