From: Dan Williams <dan.j.williams@intel.com>
To: rodrigo.vivi@gmail.com
Cc: Leon Romanovsky <leon@kernel.org>,
ksummit <ksummit-discuss@lists.linuxfoundation.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
zwisler@kernel.org, mchehab+samsung@kernel.org
Subject: Re: [Ksummit-discuss] [RFC PATCH 3/3] libnvdimm, MAINTAINERS: Subsystem Profile
Date: Fri, 16 Nov 2018 15:44:45 -0800 [thread overview]
Message-ID: <CAPcyv4hWK+to6vOSfSdeVMDzUutYwg9=XqshSDzaCf0c-u8jLA@mail.gmail.com> (raw)
In-Reply-To: <CABVU7+twSz3OZx7PTO+bS-wfLfTTjZVhRAnhgtcs6KWwntattw@mail.gmail.com>
On Fri, Nov 16, 2018 at 12:37 PM Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
>
> On Thu, Nov 15, 2018 at 8:38 AM Leon Romanovsky <leon@kernel.org> wrote:
> >
> > On Thu, Nov 15, 2018 at 06:10:36AM -0800, Mauro Carvalho Chehab wrote:
> > > Em Thu, 15 Nov 2018 09:03:11 +0100
> > > Geert Uytterhoeven <geert@linux-m68k.org> escreveu:
> > >
> > > > Hi Dan,
> > > >
> > > > On Thu, Nov 15, 2018 at 6:06 AM Dan Williams <dan.j.williams@intel.com> wrote:
> > > > > Document the basic policies of the libnvdimm subsystem and provide a
> > > > > first example of a Subsystem Profile for others to duplicate and edit.
> > > > >
> > > > > Cc: Ross Zwisler <zwisler@kernel.org>
> > > > > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > > > > Cc: Dave Jiang <dave.jiang@intel.com>
> > > > > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > > >
> > > > Thanks for your patch!
> > > >
> > > > > --- /dev/null
> > > > > +++ b/Documentation/nvdimm/subsystem-profile.rst
> > > >
> > > > > +Trusted Reviewers
> > > > > +-----------------
> > > > > +Johannes Thumshirn
> > > > > +Toshi Kani
> > > > > +Jeff Moyer
> > > > > +Robert Elliott
> > > >
> > > > Don't you want to add email addresses?
> > > > Only the first one is listed in MAINTAINERS.
> > >
> > > IMO, it makes sense to have their e-mails here, in a way that it could
> > > easily be parsed by get_maintainers.pl.
> >
> > I personally think that list of "trusted reviewers" makes more harm than
> > good. It creates unneeded negative feelings to those who wanted to be in
> > this list, but for any reason they don't. Those reviewers will feel
> > "untrusted".
>
> I'd like to +1 on this concern here. Besides leaving all the other
> people demotivated.
Yes, that's a valid concern, I overlooked that unfortunate interpretation.
>
> A small group of trusted reviewers doesn't scale. People will get overloaded.
> Or you won't be able to enforce that all patches need to get Reviews.
>
> Reviews should be coming from everywhere and commiters and maintainers
> deciding on what to trust or re-review.
>
> Also the list is hard to maintain and keep the lists updated.
I understand the concern, and as I saw feedback come in I realized
there were more people that I would add to that reviewer list for
libnvdimm.
Stepping back the end goal is to have an initial list of recommended
people to follow up with directly to seek a second opinion, or help in
cases where a contributor otherwise needs some direction / engagement
that they are not readily receiving from the maintainer. Typically
someone just lurks on the mailing list for a few weeks to get a feel
for who the usual suspects are in the subsystem, but for a new
contributor identifying those individuals may be difficult.
One of the contributing factors of lack of response to a patchset is
that they are sent with the implicit expectation that the maintainer
will get to eventually, and typically other people feel content to sit
back and watch. If instead a contributor sent a direct mail to a
"trusted reviewer" saying, "Hey, Alice, Bob seems busy can you help me
out?" that seems more likely to rope in additional review help.
next prev parent reply other threads:[~2018-11-16 23:44 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 4:53 [RFC PATCH 0/3] Maintainer Handbook: Subsystem Profile Dan Williams
2018-11-15 4:53 ` [RFC PATCH 1/3] MAINTAINERS: Reclaim the P: tag for " Dan Williams
2018-11-15 5:39 ` [Ksummit-discuss] " Mauro Carvalho Chehab
2018-11-15 20:12 ` Joe Perches
2018-11-15 4:53 ` [RFC PATCH 2/3] MAINTAINERS, Handbook: " Dan Williams
2018-11-15 5:48 ` [Ksummit-discuss] " Julia Lawall
2018-11-15 7:59 ` Geert Uytterhoeven
2018-11-15 13:47 ` Julia Lawall
2018-11-16 12:44 ` Jani Nikula
2018-11-16 17:56 ` Joe Perches
2018-11-17 14:12 ` Rob Herring
2018-11-17 17:03 ` Julia Lawall
2018-11-20 7:28 ` Jani Nikula
2018-11-15 5:49 ` Mauro Carvalho Chehab
2018-11-15 7:58 ` Geert Uytterhoeven
2018-11-15 8:38 ` Jani Nikula
2018-11-15 18:03 ` Tim.Bird
2018-11-15 23:56 ` Tobin C. Harding
2018-11-15 15:44 ` Mauro Carvalho Chehab
2018-11-16 23:28 ` Randy Dunlap
2018-11-17 11:57 ` Hans Verkuil
2018-11-16 0:11 ` Frank Rowand
2018-11-16 12:04 ` Mauro Carvalho Chehab
2018-11-16 18:57 ` Dan Williams
2018-11-18 12:58 ` Mauro Carvalho Chehab
2018-11-18 17:31 ` Dan Williams
2018-11-18 17:31 ` Dan Williams
2018-11-18 17:34 ` Dan Williams
2018-11-18 17:44 ` Mauro Carvalho Chehab
2018-11-16 16:47 ` Frank Rowand
2018-11-15 4:53 ` [RFC PATCH 3/3] libnvdimm, MAINTAINERS: " Dan Williams
2018-11-15 8:03 ` [Ksummit-discuss] " Geert Uytterhoeven
2018-11-15 14:10 ` Mauro Carvalho Chehab
2018-11-15 16:20 ` Leon Romanovsky
2018-11-15 19:09 ` Mauro Carvalho Chehab
2018-11-15 19:35 ` Leon Romanovsky
2018-11-15 19:40 ` Luck, Tony
2018-11-15 19:43 ` Joe Perches
2018-11-16 11:39 ` Mauro Carvalho Chehab
2018-11-18 7:12 ` Leon Romanovsky
2018-11-16 11:33 ` Mauro Carvalho Chehab
2018-11-16 12:00 ` Jan Kara
2018-11-18 7:00 ` Leon Romanovsky
2018-11-16 20:36 ` Rodrigo Vivi
2018-11-16 23:44 ` Dan Williams [this message]
2018-11-17 0:38 ` NeilBrown
2018-11-18 13:11 ` Mauro Carvalho Chehab
2018-11-18 13:03 ` Mauro Carvalho Chehab
2018-11-20 8:10 ` Jani Nikula
2018-11-20 19:31 ` Dan Williams
2018-11-26 11:12 ` Mauro Carvalho Chehab
2018-11-26 15:55 ` Joe Perches
2018-11-16 19:13 ` Dan Williams
2018-11-15 14:30 ` Mauro Carvalho Chehab
2018-11-15 14:51 ` Julia Lawall
2018-11-16 19:20 ` Dan Williams
2018-11-16 2:58 ` y-goto
2018-11-17 0:32 ` [Ksummit-discuss] " David Woodhouse
2018-11-15 5:56 ` [RFC PATCH 0/3] Maintainer Handbook: " Mauro Carvalho Chehab
2018-11-25 10:57 ` Pavel Machek
2018-11-25 20:55 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hWK+to6vOSfSdeVMDzUutYwg9=XqshSDzaCf0c-u8jLA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mchehab+samsung@kernel.org \
--cc=rodrigo.vivi@gmail.com \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).