From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87297C4320A for ; Wed, 18 Aug 2021 22:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70C47610CE for ; Wed, 18 Aug 2021 22:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234806AbhHRWhL (ORCPT ); Wed, 18 Aug 2021 18:37:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234775AbhHRWhK (ORCPT ); Wed, 18 Aug 2021 18:37:10 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1DE5C06179A for ; Wed, 18 Aug 2021 15:36:34 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id o2so3890359pgr.9 for ; Wed, 18 Aug 2021 15:36:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2sMII5G/YrPb+0dkZspyZPS9+RZRKOtmg2+pJ+lOQh8=; b=zCeTW3J0K5np3tXoG1IVSEAaPhRTsp6E7FG40JMxEKemO8ZOHARazqIQmpKFIcs6Sd N+GcdWyWkTcutczTnN4sOyyVCxvFWCYptMFPsGfhg09eZke8WGMWE7X323gqAUdPsHGt GJI+Q1n5sJHSiu6jvMoqplSND0vhS0iaBcT4D21x/nhiQ6MHkY+ruWt2EXdQpfM96zjC hi5+qOD40TDeOvrQRR206d0ujvibZUy7wKb/uB+gerRXWqa6ZBPhLTAUkWQOL5fPGNzE UiSjQoQgCCbD822O9dBlOBwzl+Vg8GmLowbUkm3Fma27sj5ipvOpNTGfxjNlZImQucyY 2hBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2sMII5G/YrPb+0dkZspyZPS9+RZRKOtmg2+pJ+lOQh8=; b=fCQzZeom92rxKoQ/QZrEsYnv1nJWEv6/qKOZQRlPUgGVD7UrBaRn5sjcNigybwAduq KWjLnnx6j6ukAtBFyYXILw348qKKh8yh4u7vSFaXQ6lM8ykOlxKaUekFP81iLqnCt6NM i+B/egLBOMfMxOh74WwmKZkreEaSzpVwrUbKAnfFk6qFdmEG4LgOWlR3CMZAH4llz7OE iY5qPF4KPStWQYkBmcFhdeU+Wih39AVHEfPenRb59V2TNFUFJpTBjYEFem1JDxOGbeAT jI6r2ieGaNRFPo7sydA6L9HNLN9CZwUpaYVNtpUTdmCsLsolFRrosjciEoye7amDRzE2 iazw== X-Gm-Message-State: AOAM533feq5OufH3Y0maCh0glEZQ9yLMsN8IDsJ2rYns0cxq8uFQxBfP Z1/LehrctVm7wmNiFah1+74t1bFOhEgweDjaZWxFuw== X-Google-Smtp-Source: ABdhPJx62hXsE0+fSTYrXfKzc8DzxmmvkPKOdI5TBxPP7euaOB9l5vqd5XytOvYvOyAB9vVojNAO4JW+D+jXmEpzsAs= X-Received: by 2002:a63:dd0e:: with SMTP id t14mr9405083pgg.279.1629326194463; Wed, 18 Aug 2021 15:36:34 -0700 (PDT) MIME-Version: 1.0 References: <20210818060533.3569517-1-keescook@chromium.org> <20210818060533.3569517-7-keescook@chromium.org> In-Reply-To: <20210818060533.3569517-7-keescook@chromium.org> From: Dan Williams Date: Wed, 18 Aug 2021 15:36:23 -0700 Message-ID: Subject: Re: [PATCH v2 06/63] cxl/core: Replace unions with struct_group() To: Kees Cook Cc: Linux Kernel Mailing List , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , linux-cxl@vger.kernel.org, "Gustavo A. R. Silva" , Greg Kroah-Hartman , Andrew Morton , Linux Wireless List , Netdev , Maling list - DRI developers , linux-staging@lists.linux.dev, linux-block@vger.kernel.org, Linux Kbuild mailing list , clang-built-linux , Rasmus Villemoes , linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 17, 2021 at 11:06 PM Kees Cook wrote: > > Use the newly introduced struct_group_typed() macro to clean up the > declaration of struct cxl_regs. > > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Ben Widawsky > Cc: linux-cxl@vger.kernel.org > Suggested-by: Dan Williams Looks good and tests ok here: Reviewed-by: Dan Williams