From: Dan Williams <dan.j.williams@intel.com>
To: Jerry Hoemann <jerry.hoemann@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru
Date: Thu, 29 Jun 2017 14:35:14 -0700 [thread overview]
Message-ID: <CAPcyv4hjw50P2YsqQxzBMhVesj7rxXJ-PdxNw6Gan3Wj7UMMeQ@mail.gmail.com> (raw)
In-Reply-To: <f332778c416d01fd76ce8e474acd583e1b787c29.1498754314.git.jerry.hoemann@hpe.com>
On Thu, Jun 29, 2017 at 9:56 AM, Jerry Hoemann <jerry.hoemann@hpe.com> wrote:
> Populate bus_dsm_mask and use it to filter dsm calls that user can
> make through the pass thru interface.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
> ---
> drivers/acpi/nfit/core.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index b46fca2..971002b 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -253,6 +253,8 @@ int acpi_nfit_ctl(struct nvdimm_bus_descriptor *nd_desc, struct nvdimm *nvdimm,
> cmd_name = nvdimm_bus_cmd_name(cmd);
> cmd_mask = nd_desc->cmd_mask;
> dsm_mask = cmd_mask;
> + if (cmd == ND_CMD_CALL)
> + dsm_mask = nd_desc->bus_dsm_mask;
> desc = nd_cmd_bus_desc(cmd);
> uuid = to_nfit_uuid(NFIT_DEV_BUS);
> handle = adev->handle;
> @@ -1624,6 +1626,9 @@ static void acpi_nfit_init_dsms(struct acpi_nfit_desc *acpi_desc)
> if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i))
> set_bit(i, &nd_desc->cmd_mask);
> set_bit(ND_CMD_CALL, &nd_desc->cmd_mask);
> + for (i = 0; i < ND_CMD_CALL; i++)
> + if (acpi_check_dsm(adev->handle, uuid, 1, 1ULL << i))
> + set_bit(i, &nd_desc->bus_dsm_mask);
> }
This loop checks for function 6 which is specified as reserved. Lets
explicitly test for the known good function numbers with something
like this:
/* this should be private in drivers/acpi/nfit/nfit.h */
enum nfit_aux_cmds {
NFIT_CMD_TRANSLATE_SPA = 5,
NFIT_CMD_ARS_INJECT_SET = 7,
NFIT_CMD_ARS_INJECT_CLEAR = 8,
NFIT_CMD_ARS_INJECT_GET = 9,
};
bus_dsm_mask =
(1 << ND_CMD_ARS_CAP) |
(1 << ND_CMD_ARS_START) |
(1 << ND_CMD_ARS_STATUS) |
(1 << ND_CMD_CLEAR_ERROR) |
(1 << NFIT_CMD_TRANSLATE_SPA) |
(1 << NFIT_CMD_ARS_INJECT_SET) |
(1 << NFIT_CMD_ARS_INJECT_CLEAR) |
(1 << NFIT_CMD_ARS_INJECT_GET);
for_each_set_bit(i, &bus_dsm_mask...
next prev parent reply other threads:[~2017-06-29 21:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 16:56 [PATCH v3 0/7] Enable DSM pass thru for root functions Jerry Hoemann
2017-06-29 16:56 ` [PATCH v3 1/7] libnvdimm: passthru functions clear to send Jerry Hoemann
2017-06-29 16:56 ` [PATCH v3 2/7] acpi, nfit: Enable DSM pass thru for root functions Jerry Hoemann
2017-06-29 16:56 ` [PATCH v3 3/7] libnvdimm: Add bus level dsm mask Jerry Hoemann
2017-06-29 21:23 ` Dan Williams
2017-06-29 16:56 ` [PATCH v3 4/7] acpi, nfit: Use bus_dsm_mask for passthru Jerry Hoemann
2017-06-29 21:35 ` Dan Williams [this message]
2017-06-29 21:47 ` Jerry Hoemann
2017-06-29 21:55 ` Dan Williams
2017-06-29 23:26 ` Jerry Hoemann
2017-06-30 1:26 ` Dan Williams
2017-06-29 16:56 ` [PATCH v3 5/7] acpi, nfit: Show bus_dsm_mask in sysfs Jerry Hoemann
2017-06-29 16:56 ` [PATCH v3 6/7] libnvdimm: New ACPI 6.2 DSM functions Jerry Hoemann
2017-06-29 16:56 ` [PATCH v3 7/7] acpi, nfit: override mask Jerry Hoemann
2017-06-29 21:16 ` Dan Williams
2017-06-29 22:18 ` Jerry Hoemann
2017-06-29 22:50 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hjw50P2YsqQxzBMhVesj7rxXJ-PdxNw6Gan3Wj7UMMeQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=jerry.hoemann@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).