From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932091AbbELFoc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 May 2015 01:44:32 -0400
Received: from mail-wi0-f174.google.com ([209.85.212.174]:38783 "EHLO
	mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752610AbbELFo0 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 May 2015 01:44:26 -0400
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1505120724230.2075@localhost6.localdomain6>
References: <20150512042629.11521.70356.stgit@dwillia2-desk3.amr.corp.intel.com>
	<20150512042956.11521.32457.stgit@dwillia2-desk3.amr.corp.intel.com>
	<alpine.DEB.2.02.1505120724230.2075@localhost6.localdomain6>
Date: Mon, 11 May 2015 22:44:25 -0700
Message-ID: <CAPcyv4hq5dX=HN=wYZEddOu7yX1SU4EXT0tT1hUUwKpL7txXLQ@mail.gmail.com>
Subject: Re: [PATCH v3 05/11] scatterlist: use sg_phys()
From: Dan Williams <dan.j.williams@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-arch@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Rik van Riel <riel@redhat.com>,
        linux-nvdimm <linux-nvdimm@ml01.01.org>, david <david@fromorbit.com>,
        Christoph Hellwig <hch@lst.de>, Mel Gorman <mgorman@suse.de>,
        j.glisse@gmail.com, linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 11, 2015 at 10:24 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
> On Tue, 12 May 2015, Dan Williams wrote:
>
>> Coccinelle cleanup to replace open coded sg to physical address
>> translations.  This is in preparation for introducing scatterlists that
>> reference pfn(s) without a backing struct page.
>>
>> // sg_phys.cocci: convert usage page_to_phys(sg_page(sg)) to sg_phys(sg)
>> // usage: make coccicheck COCCI=sg_phys.cocci MODE=patch
>>
>> virtual patch
>> virtual report
>> virtual org
>
> Just for information, you don't need the three lines above.  There are ony
> useful when you want the semantic patch to support several kinds of
> output.
>

Ok, I think I added them from copying a coccicheck script, and if I
delete virtual patch I get

"virtual rule patch not supported"

when running:

make coccicheck COCCI=sg_phys.cocci MODE=patch

I suspect I am invoking it wrong.