From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD65CC18E5B for ; Wed, 1 Apr 2020 08:48:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 898F221841 for ; Wed, 1 Apr 2020 08:48:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="nKT1PI4l" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732116AbgDAIs5 (ORCPT ); Wed, 1 Apr 2020 04:48:57 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:39831 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726536AbgDAIs4 (ORCPT ); Wed, 1 Apr 2020 04:48:56 -0400 Received: by mail-ed1-f66.google.com with SMTP id a43so28679567edf.6 for ; Wed, 01 Apr 2020 01:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nO7NvYL5YbGkypKxGoWuwxxFk6qjRVPvgK2ifgde8ys=; b=nKT1PI4lZjRkGXA0qoVt39rD6dCkioi4T1wOtFKczerqB7xR37+SXrexLXVaxyRoRZ P/MQ9KkylbCIRFpuT/z2h482ouR713/nq6B9H5/rP7dskLnqLtnramvo665NSX0DmbN8 77xpnQ9Sm/oZOinLBRsbN0Aq/CY0nAN421P4ND2RoGjW6GiHNbw4u7zITADs4vFdTR7w mr9q4JNLEUMY3rKgONFt7/nL5sDfFJp+oXDZsgjhTLd41jLz9ChU3YKFsf9/4GiELmlO DUygUUNqRx08PsUj63TKvtq0MTZCMgb+awXdTOjVXo/0Y7HZa/5sHB1KmL2ZXuKtyS1S oDVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nO7NvYL5YbGkypKxGoWuwxxFk6qjRVPvgK2ifgde8ys=; b=XV1mkOl9ut0ZK+yGsY4vHYLIeGDU2R93CBJBqoFty9gv2ccrBa/vqXQItyXVlHzNIL axveVj1zHuIyGtStSxRgIbQ11f/iZWEXQgseLtza2N19s+tC53i0qAwxB4ZwWynfyU5i wb7ADrIxTAjA4Fi6+xgRe07Wbk37vTfs/FZzJGaRrkRnDrwbgtxSw7G6//4guHTBHX8N U/nhBSEzkl/zGggyiuFk3c8xiGnl8OQ/Ydi4BvS1/QoEFiTouj/JwIlEY+BFcVE/Mokd iWKC4iqK9zKiH1zycvIZU48RBFj+YyHy6RJKVBpfv8jjhd9qsK5NinWZG+j4fge2Mztz zBKw== X-Gm-Message-State: ANhLgQ0Y/T6NumWp2oor6hHv9IMj1fqWrcdnJ4yW4xibNmF2G63MFzcu 0iGDxYUIrn4jZ32jRZbamrpkoUr4L8QyOGtQgFL+Uw== X-Google-Smtp-Source: ADFU+vufccZcs61ZBlmuOm7ukHfWC6ZhrwNFAphauzXSa/puB0SAYGjCUbhdXtkYuKjFSx5h5oNBplH8yyO/gpHPw6E= X-Received: by 2002:a17:906:4bc4:: with SMTP id x4mr14096929ejv.201.1585730934033; Wed, 01 Apr 2020 01:48:54 -0700 (PDT) MIME-Version: 1.0 References: <20200327071202.2159885-1-alastair@d-silva.org> <20200327071202.2159885-5-alastair@d-silva.org> In-Reply-To: <20200327071202.2159885-5-alastair@d-silva.org> From: Dan Williams Date: Wed, 1 Apr 2020 01:48:42 -0700 Message-ID: Subject: Re: [PATCH v4 04/25] ocxl: Remove unnecessary externs To: "Alastair D'Silva" Cc: "Aneesh Kumar K . V" , "Oliver O'Halloran" , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , Anton Blanchard , Krzysztof Kozlowski , Mahesh Salgaonkar , Madhavan Srinivasan , =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , Anju T Sudhakar , Hari Bathini , Thomas Gleixner , Greg Kurz , Nicholas Piggin , Masahiro Yamada , Alexey Kardashevskiy , Linux Kernel Mailing List , linuxppc-dev , linux-nvdimm , Linux MM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 29, 2020 at 10:23 PM Alastair D'Silva wrote: > > Function declarations don't need externs, remove the existing ones > so they are consistent with newer code > > Signed-off-by: Alastair D'Silva > Acked-by: Andrew Donnellan > Acked-by: Frederic Barrat Looks good. > --- > arch/powerpc/include/asm/pnv-ocxl.h | 40 ++++++++++++++--------------- > include/misc/ocxl.h | 6 ++--- > 2 files changed, 22 insertions(+), 24 deletions(-) > > diff --git a/arch/powerpc/include/asm/pnv-ocxl.h b/arch/powerpc/include/asm/pnv-ocxl.h > index 560a19bb71b7..205efc41a33c 100644 > --- a/arch/powerpc/include/asm/pnv-ocxl.h > +++ b/arch/powerpc/include/asm/pnv-ocxl.h > @@ -9,29 +9,27 @@ > #define PNV_OCXL_TL_BITS_PER_RATE 4 > #define PNV_OCXL_TL_RATE_BUF_SIZE ((PNV_OCXL_TL_MAX_TEMPLATE+1) * PNV_OCXL_TL_BITS_PER_RATE / 8) > > -extern int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 *enabled, > - u16 *supported); > -extern int pnv_ocxl_get_pasid_count(struct pci_dev *dev, int *count); > +int pnv_ocxl_get_actag(struct pci_dev *dev, u16 *base, u16 *enabled, u16 *supported); > +int pnv_ocxl_get_pasid_count(struct pci_dev *dev, int *count); > > -extern int pnv_ocxl_get_tl_cap(struct pci_dev *dev, long *cap, > +int pnv_ocxl_get_tl_cap(struct pci_dev *dev, long *cap, > char *rate_buf, int rate_buf_size); > -extern int pnv_ocxl_set_tl_conf(struct pci_dev *dev, long cap, > - uint64_t rate_buf_phys, int rate_buf_size); > - > -extern int pnv_ocxl_get_xsl_irq(struct pci_dev *dev, int *hwirq); > -extern void pnv_ocxl_unmap_xsl_regs(void __iomem *dsisr, void __iomem *dar, > - void __iomem *tfc, void __iomem *pe_handle); > -extern int pnv_ocxl_map_xsl_regs(struct pci_dev *dev, void __iomem **dsisr, > - void __iomem **dar, void __iomem **tfc, > - void __iomem **pe_handle); > - > -extern int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask, > - void **platform_data); > -extern void pnv_ocxl_spa_release(void *platform_data); > -extern int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle); > - > -extern int pnv_ocxl_alloc_xive_irq(u32 *irq, u64 *trigger_addr); > -extern void pnv_ocxl_free_xive_irq(u32 irq); > +int pnv_ocxl_set_tl_conf(struct pci_dev *dev, long cap, > + uint64_t rate_buf_phys, int rate_buf_size); > + > +int pnv_ocxl_get_xsl_irq(struct pci_dev *dev, int *hwirq); > +void pnv_ocxl_unmap_xsl_regs(void __iomem *dsisr, void __iomem *dar, > + void __iomem *tfc, void __iomem *pe_handle); > +int pnv_ocxl_map_xsl_regs(struct pci_dev *dev, void __iomem **dsisr, > + void __iomem **dar, void __iomem **tfc, > + void __iomem **pe_handle); > + > +int pnv_ocxl_spa_setup(struct pci_dev *dev, void *spa_mem, int PE_mask, void **platform_data); > +void pnv_ocxl_spa_release(void *platform_data); > +int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle); > + > +int pnv_ocxl_alloc_xive_irq(u32 *irq, u64 *trigger_addr); > +void pnv_ocxl_free_xive_irq(u32 irq); > u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size); > void pnv_ocxl_platform_lpc_release(struct pci_dev *pdev); > > diff --git a/include/misc/ocxl.h b/include/misc/ocxl.h > index 06dd5839e438..0a762e387418 100644 > --- a/include/misc/ocxl.h > +++ b/include/misc/ocxl.h > @@ -173,7 +173,7 @@ int ocxl_context_detach(struct ocxl_context *ctx); > * > * Returns 0 on success, negative on failure > */ > -extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > +int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > > /** > * Frees an IRQ associated with an AFU context > @@ -182,7 +182,7 @@ extern int ocxl_afu_irq_alloc(struct ocxl_context *ctx, int *irq_id); > * > * Returns 0 on success, negative on failure > */ > -extern int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > +int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > > /** > * Gets the address of the trigger page for an IRQ > @@ -193,7 +193,7 @@ extern int ocxl_afu_irq_free(struct ocxl_context *ctx, int irq_id); > * > * returns the trigger page address, or 0 if the IRQ is not valid > */ > -extern u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, int irq_id); > +u64 ocxl_afu_irq_get_addr(struct ocxl_context *ctx, int irq_id); > > /** > * Provide a callback to be called when an IRQ is triggered > -- > 2.24.1 >