From: Dan Williams <dan.j.williams@intel.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
KVM list <kvm@vger.kernel.org>,
Qemu Developers <qemu-devel@nongnu.org>,
linux-nvdimm <linux-nvdimm@ml01.01.org>,
Linux MM <linux-mm@kvack.org>, Jan Kara <jack@suse.cz>,
Stefan Hajnoczi <stefanha@redhat.com>,
Rik van Riel <riel@surriel.com>,
Haozhong Zhang <haozhong.zhang@intel.com>,
Nitesh Narayan Lal <nilal@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Zwisler, Ross" <ross.zwisler@intel.com>,
David Hildenbrand <david@redhat.com>,
Xiao Guangrong <xiaoguangrong.eric@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Marcel Apfelbaum <marcel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
niteshnarayanlal@hotmail.com, Igor Mammedov <imammedo@redhat.com>,
lcapitulino@redhat.com
Subject: Re: [RFC v2 1/2] virtio: add pmem driver
Date: Wed, 25 Apr 2018 07:21:21 -0700 [thread overview]
Message-ID: <CAPcyv4hvrB08XPTbVK0xT2_1Xmaid=-v3OMxJVDTNwQucsOHLA@mail.gmail.com> (raw)
In-Reply-To: <20180425112415.12327-2-pagupta@redhat.com>
On Wed, Apr 25, 2018 at 4:24 AM, Pankaj Gupta <pagupta@redhat.com> wrote:
> This patch adds virtio-pmem driver for KVM
> guest.
Minor nit, please expand your changelog line wrapping to 72 columns.
>
> Guest reads the persistent memory range
> information from Qemu over VIRTIO and registers
> it on nvdimm_bus. It also creates a nd_region
> object with the persistent memory range
> information so that existing 'nvdimm/pmem'
> driver can reserve this into system memory map.
> This way 'virtio-pmem' driver uses existing
> functionality of pmem driver to register persistent
> memory compatible for DAX capable filesystems.
We need some additional enabling to disable MAP_SYNC for this
configuration. In other words, if fsync() is required then we must
disable the MAP_SYNC optimization. I think this should be a struct
dax_device property looked up at mmap time in each MAP_SYNC capable
->mmap() file operation implementation.
next prev parent reply other threads:[~2018-04-25 14:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 11:24 [RFC v2 0/2] kvm "fake DAX" device flushing Pankaj Gupta
2018-04-25 11:24 ` [RFC v2 1/2] virtio: add pmem driver Pankaj Gupta
2018-04-25 14:21 ` Dan Williams [this message]
2018-04-25 14:43 ` Dan Williams
2018-04-26 12:27 ` Jeff Moyer
2018-04-26 17:15 ` [Qemu-devel] " Pankaj Gupta
2018-04-26 17:24 ` Jeff Moyer
2018-04-25 14:52 ` Michael S. Tsirkin
2018-04-25 15:11 ` [Qemu-devel] " Pankaj Gupta
2018-04-26 13:12 ` Stefan Hajnoczi
2018-04-26 15:44 ` Pankaj Gupta
2018-04-27 13:31 ` Stefan Hajnoczi
2018-04-28 10:48 ` Pankaj Gupta
2018-04-25 11:24 ` [RFC v2 2/2] pmem: device flush over VIRTIO Pankaj Gupta
2018-04-25 14:23 ` Dan Williams
2018-04-25 14:47 ` Pankaj Gupta
2018-04-26 13:15 ` Stefan Hajnoczi
2018-04-26 16:40 ` Pankaj Gupta
2018-04-26 16:57 ` Dan Williams
2018-04-26 17:13 ` Pankaj Gupta
2018-04-25 11:24 ` [RFC v2] qemu: Add virtio pmem device Pankaj Gupta
2018-04-25 11:35 ` [Qemu-devel] " no-reply
2018-04-25 11:58 ` Pankaj Gupta
2018-04-25 14:23 ` Eric Blake
2018-04-25 14:51 ` Pankaj Gupta
2018-04-25 11:46 ` no-reply
2018-04-25 14:25 ` Eric Blake
2018-04-25 14:55 ` Pankaj Gupta
2018-04-26 13:24 ` Stefan Hajnoczi
2018-04-26 16:43 ` [Qemu-devel] " Pankaj Gupta
2018-06-01 12:24 ` [Qemu-devel] [RFC v2 0/2] kvm "fake DAX" device flushing Igor Mammedov
2018-06-04 5:56 ` Pankaj Gupta
2018-06-04 9:55 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4hvrB08XPTbVK0xT2_1Xmaid=-v3OMxJVDTNwQucsOHLA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=hch@infradead.org \
--cc=imammedo@redhat.com \
--cc=jack@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=nilal@redhat.com \
--cc=niteshnarayanlal@hotmail.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riel@surriel.com \
--cc=ross.zwisler@intel.com \
--cc=stefanha@redhat.com \
--cc=xiaoguangrong.eric@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).