From: Dan Williams <dan.j.williams@intel.com>
To: John Garry <john.garry@huawei.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
jejb@linux.vnet.ibm.com, linux-scsi <linux-scsi@vger.kernel.org>,
john.garry2@mail.dcu.ie, linuxarm@huawei.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
lindar_liu@usish.com, jinpu.wang@profitbricks.com,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH] scsi: libsas: fix WARN on device removal
Date: Wed, 9 Nov 2016 12:35:23 -0800 [thread overview]
Message-ID: <CAPcyv4hvuFLhS2sYXkccXMTSh-ggxo7uHN2Qt6i5g8GkyBksrw@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4g+XzCuHsUvqeE+r8hqgPK3yq=E9k23a89XcLs96bkphg@mail.gmail.com>
On Wed, Nov 9, 2016 at 11:09 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Wed, Nov 9, 2016 at 9:36 AM, John Garry <john.garry@huawei.com> wrote:
>> On 09/11/2016 12:28, John Garry wrote:
>>>
>>> On 03/11/2016 14:58, John Garry wrote:
>>>>
>>>> The following patch introduces an annoying WARN
>>>> when a device is removed from the SAS topology:
>>>> [SCSI] libsas: prevent domain rediscovery competing with ata error
>>>> handling
>>>>
>>>
>>> Are there any views on this patch? I would have thought that the parties
>>> who use the drivers based on libsas would be interested in fixing this
>>> bug.
>>>
>>
>> I should have added the before and after logs earlier, so the issue is
>> illustrated. Now attached. When a 24-port expander is unplugged we get >6k
>> lines of WARN on the console, lasting >30 seconds. Not nice.
>>
>
> I might be mistaken, but this patch seems functionally identical to
> this attempt:
>
> http://marc.info/?l=linux-scsi&m=143459794823595&w=2
>
> i.e. it moves the port destruction to the workqueue and still suffers
> from the flutter problem:
>
> http://marc.info/?l=linux-scsi&m=143801026028006&w=2
> http://marc.info/?l=linux-scsi&m=143801971131073&w=2
>
> Perhaps we instead need to quiet this warning?
>
> http://marc.info/?l=linux-scsi&m=143802229932175&w=2
Alternatively we need a mechanism to cancel in-flight port shutdown
requests when we start re-attaching devices before queued port
destruction events have run.
next prev parent reply other threads:[~2016-11-09 20:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 14:58 [RFC PATCH] scsi: libsas: fix WARN on device removal John Garry
2016-11-09 12:28 ` John Garry
2016-11-09 17:36 ` John Garry
2016-11-09 19:09 ` Dan Williams
2016-11-09 20:35 ` Dan Williams [this message]
2016-11-10 11:53 ` John Garry
2016-11-11 8:12 ` wangyijing
2016-11-11 8:23 ` John Garry
2016-11-11 8:49 ` wangyijing
2016-11-17 15:23 ` John Garry
2016-11-18 1:51 ` Martin K. Petersen
2016-11-18 1:53 ` Dan Williams
2016-11-18 9:00 ` John Garry
2016-11-18 19:08 ` Dan Williams
2016-11-21 15:16 ` John Garry
2016-11-21 17:13 ` Dan Williams
2016-11-22 16:56 ` John Garry
2016-11-23 1:07 ` wangyijing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4hvuFLhS2sYXkccXMTSh-ggxo7uHN2Qt6i5g8GkyBksrw@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jinpu.wang@profitbricks.com \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).