From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 225A6C04AAD for ; Wed, 8 May 2019 00:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DBD4E21479 for ; Wed, 8 May 2019 00:30:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="gRIeqvWj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726644AbfEHAa2 (ORCPT ); Tue, 7 May 2019 20:30:28 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:34117 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726602AbfEHAa1 (ORCPT ); Tue, 7 May 2019 20:30:27 -0400 Received: by mail-ot1-f66.google.com with SMTP id l17so7243530otq.1 for ; Tue, 07 May 2019 17:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aNugRNfI1NASCVQQotBkfUx3cjwsiA1TzUpe8ibe7ac=; b=gRIeqvWjXvHVuVEemJNJK8AS0nBpMXjQNbmZV9qOtFksOrHCfrqeuX/vrn0nS6wwxy kLfpormJ8YBe4ZEF9hNxd/IFXkViwzDXyjJ7SWlHab5fqkWfEG9z/QESkM0GYa14N37c lpNEiivZk/k4qPe6YXKCt/Usic/XxFC7BwQxcRPqPZt9yKca0JFbo8LULWWrbneDHmq+ K8a2yddzszAkKsKQ3kY36HSo7YkWplePB3l48/W53IN9tPwuJM2Yv7wbC95njLsaoego 6jh4lLkkJ43Um5WDoj3cd+7cCVtFpC4h2yUMlngnDEfXLG3iM/uPEArsgoY53kR9Wc3H DUgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aNugRNfI1NASCVQQotBkfUx3cjwsiA1TzUpe8ibe7ac=; b=f1OklCfmP9B1HWhuTtuK5vrPpJCcCWJtEJPdayR67eeJN3e21pg/HSXCWX49XL6aZx 6piRav3g+nYFOLcY8joxUfEPFU1PPYi/cyexDmkMCQo1DeQfWaSdXOtOSAq7KGLX8lZX a8EGeGiKAMPd9krqsdPIZF6eeMLgaUaongDBZh0c6w8lER8S/qAhDqkUaCFGp09dRs3Y U/7mJqclQHycGxN8pxx+XGC1u3aUkeyaGr/aYA2PclGaKzCxiV6xC/42XOtsv7omb+12 dSRTrQG8NHkEIwz9Ns+V/aLXqxLQFf8DGRGp/2KiJdKHX8pinCBt+ogjVBdDM/Qmo2dc gskQ== X-Gm-Message-State: APjAAAUJFbxrQm9yAD7i9PGbaDvyMB16LQtcKW72ymUcb4f/iiyD9vHk 92Mu0tQzAjaNkQW+Fn5jYdzoFNdvPAdkGYR8FuHelQ== X-Google-Smtp-Source: APXvYqwnFUcfnqP6BFgjGKomJPr5yaMMCBD85pEk3++fjkl68hk/raq4PqQ7V3ysBstXCoK7LDo9wO4kaWYzTHhnX6M= X-Received: by 2002:a9d:5cc1:: with SMTP id r1mr22059155oti.229.1557275426847; Tue, 07 May 2019 17:30:26 -0700 (PDT) MIME-Version: 1.0 References: <20190507183804.5512-1-david@redhat.com> <20190507183804.5512-9-david@redhat.com> In-Reply-To: <20190507183804.5512-9-david@redhat.com> From: Dan Williams Date: Tue, 7 May 2019 17:30:15 -0700 Message-ID: Subject: Re: [PATCH v2 8/8] mm/memory_hotplug: Remove "zone" parameter from sparse_remove_one_section To: David Hildenbrand Cc: Linux MM , Linux Kernel Mailing List , linux-ia64@vger.kernel.org, linuxppc-dev , linux-s390 , Linux-sh , Andrew Morton Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 7, 2019 at 11:39 AM David Hildenbrand wrote: > > Unused, and memory unplug path should never care about zones. This is > the job of memory offlining. ZONE_DEVICE might require special care - > the caller of arch_remove_memory() should handle this. The ZONE_DEVICE usage does not require special care so you can drop that comment. The only place it's used in the subsection patches is to lookup the node-id, but it turns out that the resulting node-id is then never used. With the ZONE_DEVICE mention dropped out of changelog you can add: Reviewed-by: Dan Williams