From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD3A0C433E0 for ; Wed, 10 Mar 2021 23:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98BD364FC8 for ; Wed, 10 Mar 2021 23:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbhCJXaa (ORCPT ); Wed, 10 Mar 2021 18:30:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231478AbhCJXaQ (ORCPT ); Wed, 10 Mar 2021 18:30:16 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B48C3C061760 for ; Wed, 10 Mar 2021 15:30:15 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id h13so34014eds.5 for ; Wed, 10 Mar 2021 15:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vuj/D7o1+/AE9t3wM/vQsuPf0MOJqhA/d5cfPutvQfU=; b=o2uQ9nbLBO9R5FOm8KE2FiXDRix0GjxEoucgtHfPLR/wQNZblGYKZeUbZaB3a3gVls j5myReVOVSv8e+2as+yWYoc126H5rXjnDz1S/XKEZZqyjP5CjOuJtJdCXwtvh1gGajGB AttnNRUhzEiJr3aYXULMyxlHaZvK4tQR2BqqciENC5bZuYnHlM/sDf07rKUZp/9ev5Cl YaTNrQmG9WizlGQCUI2TAeuVaoqvCRRHdWDslVQgyQLqCWkKN4ZG/iNSyYEhHzvH3WFj K4JoRLLeA8DgfDKV+deTn3ktf5nSBZdM2H3ftPJJGmo54eTR0tvDEMLQuNJeSgoQMGGN ngGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vuj/D7o1+/AE9t3wM/vQsuPf0MOJqhA/d5cfPutvQfU=; b=SBb4Pae2m4j0+VQ7Q3Ewf6SvUnEYUpbe7ZSRFPP677ZppOrc4kMFqUaZJwa3r7jn7R snNqevxAlk5QpMHe/sbOE1deF1uuXs/Mjd+zquJ8eyxcKDyngSF6YgY9zq0MBNVKh6XW 3t/QKl8NgQS7LXXBGyz7xCbbSpXCaA7CJQ41C2fnjMttPI/0dqlCQxImYb+HWIE2G7Xe 6DpJQGZRsWiThx9pr8wPtRCKrG4tCMxb8TFMX8Zj3/sdZVly8MTfj2QTKhbvnp1RZK3y J/1BcGh32Nj2Mu+Ts5J+xkMayzhv0c33KtE7swAclsW1JrSkjvETcoXIWbBcI8d77weu 2Njg== X-Gm-Message-State: AOAM5333lvrdmLRNk7967JEuScSSh3xmujrrsYqNZpUxxhYmKi0CsVYN 8Ni1Qk2q5lPw8wIi9IeX8CIuovzOoa6iF9p7dDviKok68sE= X-Google-Smtp-Source: ABdhPJyAUtjsQZeO+IyfOJ0D71CMa4kn2W9c7sy/JaW+YXPD6tUcwvd9d32TJu/3+N1X9rS+ufsB+LKVJeI/Uw+LbQg= X-Received: by 2002:aa7:c3cd:: with SMTP id l13mr5720329edr.52.1615419014504; Wed, 10 Mar 2021 15:30:14 -0800 (PST) MIME-Version: 1.0 References: <161534060720.528671.2341213328968989192.stgit@dwillia2-desk3.amr.corp.intel.com> <20210310065425.GA1794@lst.de> In-Reply-To: <20210310065425.GA1794@lst.de> From: Dan Williams Date: Wed, 10 Mar 2021 15:30:02 -0800 Message-ID: Subject: Re: [PATCH v2] libnvdimm: Notify disk drivers to revalidate region read-only To: Christoph Hellwig Cc: linux-nvdimm , Ming Lei , "Martin K. Petersen" , Hannes Reinecke , Jens Axboe , kernel test robot , Vishal Verma , Linux Kernel Mailing List , linux-block@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 10:54 PM Christoph Hellwig wrote: > > Looks good to me: > > Reviewed-by: Christoph Hellwig > > Question on the pre-existing code: given that nvdimm_check_and_set_ro is > the only caller of set_disk_ro for nvdimm devices, we'll also get > the message when initially setting up any read-only disk. Is that > intentional? Yeah, that's intentional. There's no other notification that userspace would be looking for by default besides the kernel log, and the block device name is more meaningful than the region name, or the nvdimm device status for that matter.