From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 608A2C63777 for ; Tue, 17 Nov 2020 21:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF51924181 for ; Tue, 17 Nov 2020 21:45:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="FBb5z0wF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728363AbgKQVpd (ORCPT ); Tue, 17 Nov 2020 16:45:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728045AbgKQVpd (ORCPT ); Tue, 17 Nov 2020 16:45:33 -0500 Received: from mail-ed1-x543.google.com (mail-ed1-x543.google.com [IPv6:2a00:1450:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A27A2C061A04 for ; Tue, 17 Nov 2020 13:45:32 -0800 (PST) Received: by mail-ed1-x543.google.com with SMTP id k4so7364933edl.0 for ; Tue, 17 Nov 2020 13:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5lBVBDWK8SCqKzaHy0L/+mLoij0OAwknWiLnXgPeJSM=; b=FBb5z0wFGOiQbc45dE0niLuV0rybunP/wEU/0k6b783EPVbzDuRuejCVpDauBALHfc +lc+d6XRbgwNlOlzPZ80uZOVCFXlW1F2ThVz/PgWXDMr5Qk2qXUzVeV/mkMEpA6NGBWJ /r6IhOXal5Ashs5MZqCi+/Cclekpk1N7Hu9Viof3LXHIYVpqGBDN2fBwVFtEcO1Bg3xL tzN0ffs5tPZJKxTNR/PuvOabZJbNfgH+ytvBghZkwTb90HvxcpdUGn1dX3oNF3/DPg4V t49QQpzkPhLWrGwW9cDwq4Kw7uQG5EcgkdpwrzO/HDHONv+D/N6z78dNpCEiwy/lcNpB TB3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5lBVBDWK8SCqKzaHy0L/+mLoij0OAwknWiLnXgPeJSM=; b=UAJxYol8fikRNb5hFaChcxycGVsnrmGTSrPSGMdQyc1aejDNdz4o9YxdAqTlE4lDtj qELim4+MiOq5taq/JhKGX5SYtPWbwDskoIKvmX74E/vslw89OXzOs5QZDBy7oreSv5hB UqILBzsrJhu1x2/cYEQI3GMCTIez55eZIMt7ZSFb11y4AgwWzLwglchOULgHyCTor+dj NayNtydTEHWlKgLSw7g7JLUrNRzK2fxoaJwr1+l6Ty05LSIOiOyk6voAYHC2qanGNkF6 P4x4S0TcQxaNSPKUpimuqQUa4/514tAyj0aecxj0WPjgzrorCnvq1pS7oc1ORn+B4s/B HNsA== X-Gm-Message-State: AOAM531FXF2Dm3xJM94kS4U69B5dYyLh/cA/T1cqrFmQM4YoXB3DYMUX 5xF8jW6zQ6dVUlZSXYt3YoskPMjKuRQ/IGPusvRHrA== X-Google-Smtp-Source: ABdhPJyqTIqMdYQYBJBwXDLjTJrIAYOVAjbbvPmUH0FRy9zTiej41mBWzaPPONfsn2ZvoadeWtEkbQOTbaDmxU63dbg= X-Received: by 2002:a05:6402:b35:: with SMTP id bo21mr24193805edb.52.1605649531304; Tue, 17 Nov 2020 13:45:31 -0800 (PST) MIME-Version: 1.0 References: <20201111054356.793390-1-ben.widawsky@intel.com> <20201111054356.793390-2-ben.widawsky@intel.com> In-Reply-To: From: Dan Williams Date: Tue, 17 Nov 2020 13:45:20 -0800 Message-ID: Subject: Re: [RFC PATCH 1/9] cxl/acpi: Add an acpi_cxl module for the CXL interconnect To: "Rafael J. Wysocki" Cc: Ben Widawsky , linux-cxl@vger.kernel.org, Linux Kernel Mailing List , Linux PCI , ACPI Devel Maling List , Ira Weiny , Vishal Verma , "Kelley, Sean V" , Bjorn Helgaas , "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 6:33 AM Rafael J. Wysocki wrote: [..] > > +static struct acpi_driver acpi_cxl_driver = { > > First of all, no new acpi_driver instances, pretty please! > > acpi_default_enumeration() should create a platform device with the > ACPI0017 ID for you. Can't you provide a driver for this one? > Ah, yes, I recall we had this discussion around the time the ACPI0012 NFIT driver was developed. IIRC the reason ACPI0012 remaining an acpi_driver was due to a need to handle ACPI notifications, is that the deciding factor? ACPI0017 does not have any notifications so it seems like platform driver is the way to go.