linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the nvdimm tree
Date: Mon, 4 Sep 2017 11:34:46 -0700	[thread overview]
Message-ID: <CAPcyv4i7itXFzwWm0192oGU0buW_sGLqC7-9Vjht+0Q_y+1apg@mail.gmail.com> (raw)
In-Reply-To: <20170904173425.5cc0e08d@canb.auug.org.au>

On Mon, Sep 4, 2017 at 12:34 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Dan,
>
> After merging the nvdimm tree, today's linux-next build (i386 defconfig)
> failed like this:
>
> drivers/dax/super.c:64:20: error: redefinition of 'fs_dax_get_by_bdev'
>  struct dax_device *fs_dax_get_by_bdev(struct block_device *bdev)
>                     ^
> In file included from drivers/dax/super.c:22:0:
> include/linux/dax.h:76:34: note: previous definition of 'fs_dax_get_by_bdev' was here
>  static inline struct dax_device *fs_dax_get_by_bdev(struct block_device *bdev)
>                                   ^
>
> Caused by commit
>
>   78f354735081 ("dax: introduce a fs_dax_get_by_bdev() helper")
>
> The protection in drivers/dax/super.c is CONFIG_BLOCK, while in
> include/linux/dax.h it is IS_ENABLED(CONFIG_FS_DAX) and the Makefile
> uses CONFIG_DAX.
>
> I have reverted that commit and the following 3 for today.

Thanks Stephen, I have appended a fix to that branch.

https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?h=libnvdimm-for-next&id=26f2f4de0bd93

  reply	other threads:[~2017-09-04 18:34 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-04  7:34 linux-next: build failure after merge of the nvdimm tree Stephen Rothwell
2017-09-04 18:34 ` Dan Williams [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-05-16  9:10 Stephen Rothwell
2022-05-16 18:05 ` Dan Williams
2021-08-30  7:09 Stephen Rothwell
2021-08-30  7:10 ` Christoph Hellwig
2021-08-30  7:15   ` Gao Xiang
2019-07-05  7:20 Stephen Rothwell
2019-07-05  8:45 ` Pankaj Gupta
2019-07-05 11:09   ` Stephen Rothwell
2019-07-05 11:14     ` Pankaj Gupta
2019-07-05 22:32 ` Dan Williams
2019-07-05 23:48   ` Stephen Rothwell
2019-06-20  9:29 Stephen Rothwell
2019-06-20 10:30 ` Pankaj Gupta
2018-04-09  3:16 Stephen Rothwell
2018-04-09  3:38 ` Oliver
2018-04-09  7:34   ` Oliver
2018-04-09 17:11     ` Dan Williams
2018-04-09 18:14       ` Dan Williams
2017-11-03  7:19 Stephen Rothwell
2017-11-03 16:04 ` Dan Williams
2017-04-24  6:11 Stephen Rothwell
2017-04-24  8:39 ` Al Viro
2017-04-24 23:29   ` Dan Williams
2017-04-25 22:22   ` Dan Williams
2016-07-22  6:13 Stephen Rothwell
2016-07-23  1:04 ` Dan Williams
2016-07-23  3:54   ` Dan Williams
2016-07-21  6:13 Stephen Rothwell
2016-07-21 21:33 ` Dan Williams
2016-03-27  9:50 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPcyv4i7itXFzwWm0192oGU0buW_sGLqC7-9Vjht+0Q_y+1apg@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).