From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF92C2BCA1 for ; Fri, 7 Jun 2019 20:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CA0B2146F for ; Fri, 7 Jun 2019 20:03:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="u6rXT3Xk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728727AbfFGUDi (ORCPT ); Fri, 7 Jun 2019 16:03:38 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:45803 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729342AbfFGUDi (ORCPT ); Fri, 7 Jun 2019 16:03:38 -0400 Received: by mail-oi1-f195.google.com with SMTP id m206so2260128oib.12 for ; Fri, 07 Jun 2019 13:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tNWHofgNaqy6pErzI2UDdlfPXYGdisLICCNigvI4kL0=; b=u6rXT3Xk89E7qKZJuqet/kerwsW/8pbifYfbULG0Hl/9cqx/I2ZRAEyvBG62o4extZ wAaIEjw3XjBv16xyVl1le/CrVWXfxtjbO+/oJacrZ7oKh3hvurUvbwDA/9HTSM20GBjn w5BBygSxhP2JKc63CxyI3teYBc84w8qnOmwxMKIgAOtMMiuAcSIq4AtgY5fyAra+CJHI oF4c/P4dsqTzwVfwmGRtz2IoT9hpxJhBJtN/CXH5nQ6lK38J+bgrm3NiRudTmRV4xr8B w9zoN74jsv49+DgrTPWzcfpX7kTtx8FhE+9Qxspy8dgylv58d2b5qynGCr7A6rUP8kjG xw1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tNWHofgNaqy6pErzI2UDdlfPXYGdisLICCNigvI4kL0=; b=f9h8q5v0h0hUsGaNFpZKzsTLmS578PnxE8otJ1vmi880D5+EUTNI627/DOqhMkFNtD wvmxtQc7C6XIvCrpZsUl0F7ZrZz9We55pmqyQvlB/cghHm17bs60wdM/q2PIoM7seR9T upKT1C8MuZUZzvhnYsfHIkzjBPJkkwAq6qNFhTqKgmwG43ttU3F1XRemZqybOSJxzNWq 9QITdXDeKb83FuYZdwmm4t5Wbo/1nggSrtW43QsXl4/j+ZweGjYcYQmDVSvRzhMpz3Rm pRzMaBSzScBVDVr3IAvo0NEbfmt1SkG4l1fcq0W1U3KmPN4hzL4Od7gv13Nydy6LMXWF TgyA== X-Gm-Message-State: APjAAAUl9PnEILvcZFbn+/sJKR/V9KsFwusN2yNmBGbGlu+lBlRcjlDA Q3rjZdwrZUsGHN7gDClbU9iLxZq/RmSmW0ZG9sO3dw== X-Google-Smtp-Source: APXvYqzjRw0XmHbFfB6N+LCDL02dSt9gHYEVSEZPCDUNI5M9/YAyKIO6lrQhDDoN+9fLMKTRkM2lsSceY96vks8ggTQ= X-Received: by 2002:aca:aa88:: with SMTP id t130mr2819351oie.70.1559937817614; Fri, 07 Jun 2019 13:03:37 -0700 (PDT) MIME-Version: 1.0 References: <155993563277.3036719.17400338098057706494.stgit@dwillia2-desk3.amr.corp.intel.com> <155993564854.3036719.3692507629721494555.stgit@dwillia2-desk3.amr.corp.intel.com> In-Reply-To: From: Dan Williams Date: Fri, 7 Jun 2019 13:03:26 -0700 Message-ID: Subject: Re: [PATCH v3 03/10] efi: Enumerate EFI_MEMORY_SP To: Dave Hansen Cc: Linux Kernel Mailing List , Ard Biesheuvel , Peter Zijlstra , Vishal L Verma , Dave Hansen , linux-nvdimm , X86 ML , linux-efi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 7, 2019 at 12:54 PM Dave Hansen wrote: > > On 6/7/19 12:27 PM, Dan Williams wrote: > > @@ -848,15 +848,16 @@ char * __init efi_md_typeattr_format(char *buf, size_t size, > > if (attr & ~(EFI_MEMORY_UC | EFI_MEMORY_WC | EFI_MEMORY_WT | > > EFI_MEMORY_WB | EFI_MEMORY_UCE | EFI_MEMORY_RO | > > EFI_MEMORY_WP | EFI_MEMORY_RP | EFI_MEMORY_XP | > > - EFI_MEMORY_NV | > > + EFI_MEMORY_NV | EFI_MEMORY_SP | > > EFI_MEMORY_RUNTIME | EFI_MEMORY_MORE_RELIABLE)) > > snprintf(pos, size, "|attr=0x%016llx]", > > (unsigned long long)attr); > > else > > snprintf(pos, size, > > - "|%3s|%2s|%2s|%2s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]", > > + "|%3s|%2s|%2s|%2s|%2s|%2s|%2s|%2s|%3s|%2s|%2s|%2s|%2s]", > > attr & EFI_MEMORY_RUNTIME ? "RUN" : "", > > attr & EFI_MEMORY_MORE_RELIABLE ? "MR" : "", > > + attr & EFI_MEMORY_SP ? "SP" : "", > > attr & EFI_MEMORY_NV ? "NV" : "", > > attr & EFI_MEMORY_XP ? "XP" : "", > > attr & EFI_MEMORY_RP ? "RP" : "", > > Haha, I went digging in sysfs to find out where this gets dumped out. > The joke was on me because it seems to only go to dmesg. > > Separate from these patches, should we have a runtime file that dumps > out the same info? dmesg isn't always available, and hotplug could > change this too, I'd imagine. Perhaps, but I thought /proc/iomem was that runtime file. Given that x86/Linux only seems to care about the the EFI to E820 translation of the map and the E820 map is directly reflected in /proc/iomem, do we need another file?