From: Dan Williams <dan.j.williams@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel: remove the unused device_private_entry_fault export
Date: Mon, 29 Apr 2019 07:45:34 -0700 [thread overview]
Message-ID: <CAPcyv4iJo6QdDdaXWJCnF3LqO-wSkRcKx1wwWF1h-=q=z2UZdA@mail.gmail.com> (raw)
In-Reply-To: <20190429115535.12793-1-hch@lst.de>
On Mon, Apr 29, 2019 at 4:56 AM Christoph Hellwig <hch@lst.de> wrote:
>
> This export has been entirely unused since it was added more than 1 1/2
> years ago.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> kernel/memremap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/memremap.c b/kernel/memremap.c
> index 4e59d29245f4..1490e63f69a9 100644
> --- a/kernel/memremap.c
> +++ b/kernel/memremap.c
> @@ -45,7 +45,6 @@ vm_fault_t device_private_entry_fault(struct vm_area_struct *vma,
> */
> return devmem->page_fault(vma, addr, page, flags, pmdp);
> }
> -EXPORT_SYMBOL(device_private_entry_fault);
> #endif /* CONFIG_DEVICE_PRIVATE */
Looks good to me.
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
prev parent reply other threads:[~2019-04-29 14:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 11:55 [PATCH] kernel: remove the unused device_private_entry_fault export Christoph Hellwig
2019-04-29 14:45 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4iJo6QdDdaXWJCnF3LqO-wSkRcKx1wwWF1h-=q=z2UZdA@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).