From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADD80C04E53 for ; Wed, 15 May 2019 20:46:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77AC220843 for ; Wed, 15 May 2019 20:46:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="Cy2EIYX1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727745AbfEOUqY (ORCPT ); Wed, 15 May 2019 16:46:24 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:38018 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726170AbfEOUqU (ORCPT ); Wed, 15 May 2019 16:46:20 -0400 Received: by mail-ot1-f68.google.com with SMTP id s19so1348739otq.5 for ; Wed, 15 May 2019 13:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kQMkVem+f5BUJTL0ohOK8s/LBe9AOQLQXzJAVF0NO2o=; b=Cy2EIYX1Pq2jZ4OZSz2yQkq0F9kd5atoA7LKrqdgOhRjKiFVlVYA2gODEElFw67K45 tpjRxjmowCB5ex6K1svZPmFMGUJvDyewft/V9f+O8H7U1VGbN+OU4Z/xpXBeMQgdofxU HwFKIrN+ZDE05AjnzxypOVzx8FHhxfQfSPDlE24jH7d0yRidX/qCp6tGapcyXMIsQ/FN xTviZEpkXwuB4/hLQMP71dgjub+M7+e9+NQASiodAsRVquNojGSwTZ5hM/gNAMDb2yEk Teybs5bgEInBpgzEo9DC1MccDV1z1SSDczRUyu9xTatdTpheOTQU+jZivdK6ZvGITWFx bOkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kQMkVem+f5BUJTL0ohOK8s/LBe9AOQLQXzJAVF0NO2o=; b=nnKrJwlF8FGczm3j0BJfgDCFYMAEI0IyT0TK2pTC0X1lnbUAG28olDXuAmNnnmLmbm CfGjI6oWjegGAcZM/ghB/vemUB6lYsR0nwOYv9alTHhE0tIoOSL4yquuouFkFTZSaepJ TkOJ0hgE1yeVh/P5AbBt9PZw3Xt03lObxxAWeaEzCRHF3089SXAo34rR4/0TpGs3bx3Q WDXc+DUCILlbN9h2n/+7mHYBFFLNZPMHust7kFm4sBZoyx+L8NKK6IVvUx+uyQtlvq+C y4LNvLf0RazQVuBVvNUMcaT2bxM5lcv0QIpyG7pqltA1/hGVdWDjz/Od5gbju0HIj0nf oBBg== X-Gm-Message-State: APjAAAVYE8I32SAMKB5aqJkWKy4c3EO4OLqcjm0AZMUQhQ7p0Df+He8h +vgWxI0iUo+VHY7E844IR3N/ZU4ZtAV218Islgo5mg== X-Google-Smtp-Source: APXvYqzmFFlcg/jPSqhKzy3t5czXCo+ojmXW5WVgFrjk+NAmke64X9x4AGwl9LoR92w5/nxaP9HiWHsnxe/dpzoT3CE= X-Received: by 2002:a9d:6116:: with SMTP id i22mr26141595otj.13.1557953179336; Wed, 15 May 2019 13:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20190514145422.16923-1-pagupta@redhat.com> <20190514145422.16923-3-pagupta@redhat.com> <1112624345.28705248.1557847520326.JavaMail.zimbra@redhat.com> In-Reply-To: <1112624345.28705248.1557847520326.JavaMail.zimbra@redhat.com> From: Dan Williams Date: Wed, 15 May 2019 13:46:08 -0700 Message-ID: Subject: Re: [Qemu-devel] [PATCH v9 2/7] virtio-pmem: Add virtio pmem driver To: Pankaj Gupta Cc: Randy Dunlap , linux-nvdimm , Linux Kernel Mailing List , virtualization@lists.linux-foundation.org, KVM list , linux-fsdevel , Linux ACPI , Qemu Developers , linux-ext4 , linux-xfs , Jan Kara , "Michael S. Tsirkin" , Jason Wang , david , lcapitulino@redhat.com, adilger kernel , Ross Zwisler , Andrea Arcangeli , dave jiang , jstaron@google.com, darrick wong , vishal l verma , David Hildenbrand , Matthew Wilcox , Christoph Hellwig , jmoyer , Nitesh Narayan Lal , Len Brown , Adam Borowski , Rik van Riel , yuval shaia , Stefan Hajnoczi , Paolo Bonzini , Kevin Wolf , "Theodore Ts'o" , xiaoguangrong eric , cohuck@redhat.com, "Rafael J. Wysocki" , Igor Mammedov Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 14, 2019 at 8:25 AM Pankaj Gupta wrote: > > > > On 5/14/19 7:54 AM, Pankaj Gupta wrote: > > > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig > > > index 35897649c24f..94bad084ebab 100644 > > > --- a/drivers/virtio/Kconfig > > > +++ b/drivers/virtio/Kconfig > > > @@ -42,6 +42,17 @@ config VIRTIO_PCI_LEGACY > > > > > > If unsure, say Y. > > > > > > +config VIRTIO_PMEM > > > + tristate "Support for virtio pmem driver" > > > + depends on VIRTIO > > > + depends on LIBNVDIMM > > > + help > > > + This driver provides access to virtio-pmem devices, storage devices > > > + that are mapped into the physical address space - similar to NVDIMMs > > > + - with a virtio-based flushing interface. > > > + > > > + If unsure, say M. > > > > > > from Documentation/process/coding-style.rst: > > "Lines under a ``config`` definition > > are indented with one tab, while help text is indented an additional two > > spaces." > > ah... I changed help text and 'checkpatch' did not say anything :( . > > Will wait for Dan, If its possible to add two spaces to help text while applying > the series. I'm inclined to handle this with a fixup appended to the end of the series just so the patchwork-bot does not get confused by the content changing from what was sent to the list.