From: Dan Williams <dan.j.williams@intel.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Christoph Hellwig" <hch@lst.de>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Linux MM" <linux-mm@kvack.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] mm, hmm: replace hmm_devmem_pages_create() with devm_memremap_pages()
Date: Tue, 22 May 2018 14:38:02 -0700 [thread overview]
Message-ID: <CAPcyv4idV8JbwUQ8tkzFzMV-sfLY15zwE_Xp3F6C_+zajVbxng@mail.gmail.com> (raw)
In-Reply-To: <45b62e4b-ee9a-a2de-579f-24642bb1fbc7@deltatee.com>
On Tue, May 22, 2018 at 10:13 AM, Logan Gunthorpe <logang@deltatee.com> wrote:
>
>
> On 21/05/18 04:35 PM, Dan Williams wrote:
>> + /*
>> + * For device private memory we call add_pages() as we only need to
>> + * allocate and initialize struct page for the device memory. More-
>> + * over the device memory is un-accessible thus we do not want to
>> + * create a linear mapping for the memory like arch_add_memory()
>> + * would do.
>> + *
>> + * For all other device memory types, which are accessible by
>> + * the CPU, we do want the linear mapping and thus use
>> + * arch_add_memory().
>> + */
>> + if (pgmap->type == MEMORY_DEVICE_PRIVATE) {
>> + error = add_pages(nid, align_start >> PAGE_SHIFT,
>> + align_size >> PAGE_SHIFT, NULL, false);
>> + } else {
>> + struct zone *zone;
>> +
>> + error = arch_add_memory(nid, align_start, align_size, altmap,
>> + false);
>> + zone = &NODE_DATA(nid)->node_zones[ZONE_DEVICE];
>> + if (!error)
>> + move_pfn_range_to_zone(zone, align_start >> PAGE_SHIFT,
>> align_size >> PAGE_SHIFT, altmap);
>> + }
>
> Maybe I missed it in the patch but, don't we need the same thing in
> devm_memremap_pages_release() such that it calls the correct remove
> function? Similar to the replaced hmm code:
>
>> - mem_hotplug_begin();
>> - if (resource->desc == IORES_DESC_DEVICE_PRIVATE_MEMORY)
>> - __remove_pages(zone, start_pfn, npages, NULL);
>> - else
>> - arch_remove_memory(start_pfn << PAGE_SHIFT,
>> - npages << PAGE_SHIFT, NULL);
>> - mem_hotplug_done();
>> -
>> - hmm_devmem_radix_release(resource);
>
> Perhaps it should be a separate patch too as it would be easier to see
> outside the big removal of HMM code.
>
Yes, I'll split it out.
next prev parent reply other threads:[~2018-05-22 21:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 22:35 [PATCH 0/5] mm: rework hmm to use devm_memremap_pages Dan Williams
2018-05-21 22:35 ` [PATCH 1/5] mm, devm_memremap_pages: mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams
2018-05-22 6:29 ` Christoph Hellwig
2018-05-21 22:35 ` [PATCH 2/5] mm, devm_memremap_pages: handle errors allocating final devres action Dan Williams
2018-05-21 23:10 ` Andrew Morton
2018-05-22 0:07 ` Dan Williams
2018-05-22 16:42 ` Logan Gunthorpe
2018-05-22 16:56 ` Dan Williams
2018-05-22 17:03 ` Logan Gunthorpe
2018-05-22 17:25 ` Dan Williams
2018-05-22 17:36 ` Logan Gunthorpe
2018-05-22 6:30 ` Christoph Hellwig
2018-05-21 22:35 ` [PATCH 3/5] mm, hmm: use devm semantics for hmm_devmem_{add, remove} Dan Williams
2018-05-22 6:30 ` Christoph Hellwig
2018-05-21 22:35 ` [PATCH 4/5] mm, hmm: replace hmm_devmem_pages_create() with devm_memremap_pages() Dan Williams
2018-05-22 6:31 ` Christoph Hellwig
2018-05-22 17:13 ` Logan Gunthorpe
2018-05-22 21:38 ` Dan Williams [this message]
2018-05-21 22:35 ` [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Dan Williams
2018-05-22 6:32 ` Christoph Hellwig
2018-05-22 21:31 ` Andrew Morton
2018-06-05 18:24 ` Jerome Glisse
2018-05-24 0:10 ` [PATCH 0/5] mm: rework hmm to use devm_memremap_pages Jerome Glisse
2018-05-24 3:18 ` Dan Williams
2018-05-24 6:35 ` Christoph Hellwig
2018-05-29 22:22 ` Dave Airlie
2018-05-29 22:31 ` Dan Williams
2018-05-29 23:00 ` Dave Airlie
2018-05-29 23:33 ` Dan Williams
2018-06-05 18:48 ` Jerome Glisse
2018-06-05 22:19 ` Dave Airlie
2018-06-05 23:06 ` Dan Williams
2018-06-06 0:08 ` Jerome Glisse
2018-06-06 1:33 ` Dan Williams
2018-06-06 7:14 ` Christoph Hellwig
2018-06-07 14:16 ` Jerome Glisse
2018-06-07 18:39 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4idV8JbwUQ8tkzFzMV-sfLY15zwE_Xp3F6C_+zajVbxng@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).