From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1615C49ED9 for ; Thu, 12 Sep 2019 07:41:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9312620830 for ; Thu, 12 Sep 2019 07:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="r5iciw4g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729813AbfILHlh (ORCPT ); Thu, 12 Sep 2019 03:41:37 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:34831 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729391AbfILHlh (ORCPT ); Thu, 12 Sep 2019 03:41:37 -0400 Received: by mail-oi1-f194.google.com with SMTP id a127so16378757oii.2 for ; Thu, 12 Sep 2019 00:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=o8LTeC4govd1fNBJO0ioJqcSmCWQfNIKLUUZIaiAhHg=; b=r5iciw4g8aqTCdevxlX7Yl1qKRDD/phXv4v2oTTELHQGit1wxhO/OmSHjpMCzaPPrC Vr8pfrqAPKZP/QRditALJa3T7m3utIzI7knIH43NmnrLOYeWwUlpJTX+V+qEIHPXtDWk i+S3TBIunng9amNi6owpSMAwGYmTOzTOg39UCXWUFCAs9mW/cRdQ9TrieNsVwozqYGMY ud38gNVy7hASRzjURWmOVrK8Lm1bGKmNLt/QqIPlK0Zbi79sDGl94Y4HvgRcvzJv2owV GO/6yFDyIZBlsfIr5xvExb4PHDGHZscKuenTgOys/I73OMjRL8cbQsLrUCTP+Fo1/Uy7 k13A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o8LTeC4govd1fNBJO0ioJqcSmCWQfNIKLUUZIaiAhHg=; b=mYC+dP/WDJcpdUCufq6GqLT7I3XF4ZzfS3vmJHVP2p8OJlgU71Fi1SJoQ7xwuSEHHB 7BWm9jVslr73Z3O+jpo2HZ/Y/YITxjimy7P+CpVWqfhUXbDeWkXPcxvcrc7E4e2Jls3Z qHCNw8drs3HDVa+bYtfolT+RrRhKSZnIrJhzxJUN8wzvEyWbngZNBM4vhXR6HF8s2sxR EMR+tyiJq3NDbP1HiUBPVD9KOPNfcGzoki04umrZ+FraOjnGcMZMl4ldCCW2ZPVM+bBI gURdebAzlWnL2QAFEPuqAHqf9eaANWVVqA/4ks/J/rsxbt5+yrQ0z/EiMw2xlm9eE7ua GPvA== X-Gm-Message-State: APjAAAVcFaaKb5A62k6WZ+v5ya7JvxaeJ+WiBcfbdj9AuuJ+snAOdfnr nMP2eMLsi6KGoBXlVj1bipOQ5pPd2jXQ4Ebz+SkxTujA X-Google-Smtp-Source: APXvYqw0A8Lqk6qX7CD0ZjUAfqaCMtvOeZCnyqiVzGAx3LVFCio/Y9Fb+8rbJ3TzTxR704q9l8iceiToxbjJgcESn2g= X-Received: by 2002:aca:eb09:: with SMTP id j9mr7724558oih.105.1568274096350; Thu, 12 Sep 2019 00:41:36 -0700 (PDT) MIME-Version: 1.0 References: <156821692280.2951081.18036584954940423225.stgit@dwillia2-desk3.amr.corp.intel.com> <156821693963.2951081.11214256396118531359.stgit@dwillia2-desk3.amr.corp.intel.com> <20190911184332.GL20699@kadam> <9132e214-9b57-07dc-7ee2-f6bc52e960c5@kernel.dk> In-Reply-To: <9132e214-9b57-07dc-7ee2-f6bc52e960c5@kernel.dk> From: Dan Williams Date: Thu, 12 Sep 2019 00:41:24 -0700 Message-ID: Subject: Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile To: Jens Axboe Cc: Dan Carpenter , Dave Jiang , ksummit , linux-nvdimm , Vishal Verma , Linux Kernel Mailing List , bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 11, 2019 at 3:11 PM Jens Axboe wrote: > > On 9/11/19 12:43 PM, Dan Carpenter wrote: > > On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: > >> +Coding Style Addendum > >> +--------------------- > >> +libnvdimm expects multi-line statements to be double indented. I.e. > >> + > >> + if (x... > >> + && ...y) { > > > > That looks horrible and it causes a checkpatch warning. :( Why not > > do it the same way that everyone else does it. > > > > if (blah_blah_x && <-- && has to be on the first line for checkpatch > > blah_blah_y) { <-- [tab][space][space][space][space]blah > > > > Now all the conditions are aligned visually which makes it readable. > > They aren't aligned with the indent block so it's easy to tell the > > inside from the if condition. > > > > I kind of hate all this extra documentation because now everyone thinks > > they can invent new hoops to jump through. > > FWIW, I completely agree with Dan (Carpenter) here. I absolutely > dislike having these kinds of files, and with subsystems imposing weird > restrictions on style (like the quoted example, yuck). > > Additionally, it would seem saner to standardize rules around when > code is expected to hit the maintainers hands for kernel releases. Both > yours and Martins deals with that, there really shouldn't be the need > to have this specified in detail per sub-system. So this is *the* point of the exercise. I picked up this indentation habit a long while back in response to review feedback on a patch to a subsystem that formatted code this way. At the time CodingStyle did not contradict the maintainer's preference, so I adopted it across the board. Now I come to find that CodingStyle has settled on clang-format (in the last 15 months) as the new standard which is a much better answer to me than a manually specified style open to interpretation. I'll take a look at getting libnvdimm converted over. If we can take that further and standardize all of the places where contributors see variations across subsystems on the fundamental questions of style, timing, follow-up, and unit test invocation the Maintainer Entry Profile can be superseded with common guidelines. Otherwise, yes I completely agree with you that a "Maintainer Entry Profile" is a sad comment on the state of what contributors need to navigate, but that's today's reality that needs to be addressed.