From: Dan Williams <dan.j.williams@intel.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: lkp <lkp@intel.com>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@suse.de>
Subject: Re: arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle_tail'
Date: Wed, 9 Jun 2021 17:13:25 -0700 [thread overview]
Message-ID: <CAPcyv4ioLR4UyG_h3Z6Yaym9Yfg1CsQ0o_2gtrUbd3SKiS9i6A@mail.gmail.com> (raw)
In-Reply-To: <10c9fdc0ace04013b7d4999643aa8b21@intel.com>
On Wed, Jun 9, 2021 at 4:55 PM Luck, Tony <tony.luck@intel.com> wrote:
>
> > This routine is only ever called from ASM code, so the fact that there
> > is no C declaration is expected.
>
> Does the asm code really need to call back into C?
>
> Could you just have the asm code do "jmp .L_read_trailing_bytes" (might need to only do that if %ecx is non-zero)?
I could... it turns out when Peter did this:
3693ca81151e x86/uaccess: Move copy_user_handle_tail() into asm
...he did not also go fixup my cargo culting. I'll take a look...
next prev parent reply other threads:[~2021-06-10 0:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 22:43 arch/x86/lib/copy_mc.c:30:1: warning: no previous prototype for 'copy_mc_fragile_handle_tail' kernel test robot
2021-06-09 23:43 ` Dan Williams
2021-06-09 23:55 ` Luck, Tony
2021-06-10 0:13 ` Dan Williams [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-28 8:32 kernel test robot
2021-03-30 18:10 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4ioLR4UyG_h3Z6Yaym9Yfg1CsQ0o_2gtrUbd3SKiS9i6A@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=bp@suse.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).