From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754583AbdA3WAk (ORCPT ); Mon, 30 Jan 2017 17:00:40 -0500 Received: from mail-ot0-f181.google.com ([74.125.82.181]:35577 "EHLO mail-ot0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752623AbdA3WAi (ORCPT ); Mon, 30 Jan 2017 17:00:38 -0500 MIME-Version: 1.0 In-Reply-To: <20170130122452.GA9043@lst.de> References: <148566590827.1627.3631056985359212959.stgit@dwillia2-desk3.amr.corp.intel.com> <20170130122452.GA9043@lst.de> From: Dan Williams Date: Mon, 30 Jan 2017 13:53:36 -0800 Message-ID: Subject: Re: [RFC PATCH] scsi, block: fix duplicate bdi name registration crashes To: Christoph Hellwig Cc: "Martin K. Petersen" , Jens Axboe , linux-block@vger.kernel.org, linux-scsi , "linux-kernel@vger.kernel.org" , James Bottomley , Bart Van Assche , Omar Sandoval Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2017 at 4:24 AM, Christoph Hellwig wrote: > Hi Dan, > > this looks mostly fine to me. A few code comments below, but except > for this there is another issue with it: We still have drivers > that share a single request_queue for multiple gendisks, so I wonder scsi drivers or others? If those drivers can switch to dynamically allocated devt (GENHD_FL_EXT_DEVT), then they don't need this fix.