From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4371FC433FE for ; Thu, 10 Mar 2022 03:54:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239360AbiCJDzb (ORCPT ); Wed, 9 Mar 2022 22:55:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232411AbiCJDz2 (ORCPT ); Wed, 9 Mar 2022 22:55:28 -0500 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D059FE3C7E for ; Wed, 9 Mar 2022 19:54:28 -0800 (PST) Received: by mail-pf1-x42a.google.com with SMTP id t5so4041113pfg.4 for ; Wed, 09 Mar 2022 19:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lU5YJqnIdV6EY+Secthv0iH88/tqXC8YBp4+e6GV1+A=; b=vWwRMK+EIdboVO5wlmn0/o8zduvLLav44n1w6rT88q/HHODVeCiCbS+vYYbHGA6UV4 lsUNLp70L/1OLzQ47T9bzH+030qyZSx/MTTOE2xZetveZ6il1kDT29fEUBXfRltQ5Eu8 hkkeBjJSg7iHJQ+N29qLjpIytfcxW3WAzHYEDpeJ6nrZymuJHrRgOPgpJSX0+QOuHvJm C4qvxbQoMS+p5LKHuVroK6YQqwERfAD36xIRKCK8+SWDj3416FPLgejd5Dp+6xYnE9CC VUFsXuGvwnhvkZXGQ0wL81sF7D/YaKSVq7dbXetnhyDB0ihysr99z/98GaqyiEjgr2an i4MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lU5YJqnIdV6EY+Secthv0iH88/tqXC8YBp4+e6GV1+A=; b=dUVtc34RhKndtcTMzEaEEgE06R0Hwd+zU1oJLihapTLkrhzHZIPAOLfybor6r78Z0a QxnXdTfRpY1c1GqX452++RqPcoFQsLY2rY/eSnJaq0OdC54yosByf5t1fpDgotU+b8U7 6WcfsJSXw+ywGYJtlFxpzUZjq3YCnMprpxlJ88mov/3fDeuOD0rXETERGfS3vvH7yH+g rwKZsukO9hwVrr4Q6CctnVuBftBStovs/Scry06LakXu9RfEdVnLlVNmDBXJfdi9akF2 /XFLvP3bEIJdepKugPPZrfnJJ5ZKLIiIYBx+vlL7rXsG4RifSNp4x+MGzrskIxwioOT/ vybA== X-Gm-Message-State: AOAM530ZwIMoSrjsMdFBfsnhPnRXQJmJtivB2iyGgFTzFXsD2tMXcMZj 9xD4YUMcHph/AB9ZL1UAQSulG3YLd1e9j8XAzOJxlw== X-Google-Smtp-Source: ABdhPJwvemzucTPrgpseFphjjG8pwdptwyDczVK5E/gt4x73Np20Dd90o+US1aq+uxMNTq2O9E9h8MAmCdWWN6fMKqY= X-Received: by 2002:a05:6a02:283:b0:342:703e:1434 with SMTP id bk3-20020a056a02028300b00342703e1434mr2456148pgb.74.1646884468421; Wed, 09 Mar 2022 19:54:28 -0800 (PST) MIME-Version: 1.0 References: <164610292916.2682974.12924748003366352335.stgit@dwillia2-desk3.amr.corp.intel.com> <164610294604.2682974.11169622387063183603.stgit@dwillia2-desk3.amr.corp.intel.com> <20220309182217.00006bf5@Huawei.com> In-Reply-To: <20220309182217.00006bf5@Huawei.com> From: Dan Williams Date: Wed, 9 Mar 2022 19:54:17 -0800 Message-ID: Subject: Re: [PATCH 03/11] cxl/core: Remove cxl_device_lock() To: Jonathan Cameron Cc: Greg KH , Rafael J Wysocki , Alison Schofield , Vishal Verma , Ira Weiny , Ben Widawsky , Linux Kernel Mailing List , linux-cxl@vger.kernel.org, Linux NVDIMM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 9, 2022 at 10:22 AM Jonathan Cameron wrote: > > On Mon, 28 Feb 2022 18:49:06 -0800 > Dan Williams wrote: > > > In preparation for moving lockdep_mutex nested lock acquisition into the > > core, remove the cxl_device_lock() wrapper, but preserve > > cxl_lock_class() that will be used to inform the core of the subsystem's > > lock ordering rules. > > > > Cc: Alison Schofield > > Cc: Vishal Verma > > Cc: Ira Weiny > > Cc: Ben Widawsky > > Signed-off-by: Dan Williams > > Makes sense, but perhaps the description should call out that after > this patch it's not just a wrapper remove, but rather the lock > checking is totally gone for now? Sure, that's worth a note. > > Otherwise this looks fine to me. FWIW > Reviewed-by: Jonathan Cameron