From: Dan Williams <dan.j.williams@intel.com>
To: Shiyang Ruan <ruansy.fnst@fujitsu.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Linux NVDIMM <nvdimm@lists.linux.dev>,
Linux MM <linux-mm@kvack.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
david <david@fromorbit.com>, Jane Chu <jane.chu@oracle.com>
Subject: Re: [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS
Date: Thu, 7 Apr 2022 23:26:08 -0700 [thread overview]
Message-ID: <CAPcyv4jO+-JkRcwZk0ZuYaGy0NDx2iZg-GjnDLWqVFYvciFF4g@mail.gmail.com> (raw)
In-Reply-To: <8f1931d2-b224-de98-4593-df136f397eb4@fujitsu.com>
On Thu, Apr 7, 2022 at 11:05 PM Shiyang Ruan <ruansy.fnst@fujitsu.com> wrote:
>
>
>
> 在 2022/3/30 14:00, Christoph Hellwig 写道:
> >> @@ -1892,6 +1893,8 @@ xfs_free_buftarg(
> >> list_lru_destroy(&btp->bt_lru);
> >>
> >> blkdev_issue_flush(btp->bt_bdev);
> >> + if (btp->bt_daxdev)
> >> + dax_unregister_holder(btp->bt_daxdev, btp->bt_mount);
> >> fs_put_dax(btp->bt_daxdev);
> >>
> >> kmem_free(btp);
> >> @@ -1939,6 +1942,7 @@ xfs_alloc_buftarg(
> >> struct block_device *bdev)
> >> {
> >> xfs_buftarg_t *btp;
> >> + int error;
> >>
> >> btp = kmem_zalloc(sizeof(*btp), KM_NOFS);
> >>
> >> @@ -1946,6 +1950,14 @@ xfs_alloc_buftarg(
> >> btp->bt_dev = bdev->bd_dev;
> >> btp->bt_bdev = bdev;
> >> btp->bt_daxdev = fs_dax_get_by_bdev(bdev, &btp->bt_dax_part_off);
> >> + if (btp->bt_daxdev) {
> >> + error = dax_register_holder(btp->bt_daxdev, mp,
> >> + &xfs_dax_holder_operations);
> >> + if (error) {
> >> + xfs_err(mp, "DAX device already in use?!");
> >> + goto error_free;
> >> + }
> >> + }
> >
> > It seems to me that just passing the holder and holder ops to
> > fs_dax_get_by_bdev and the holder to dax_unregister_holder would
> > significantly simply the interface here.
> >
> > Dan, what do you think?
>
> Hi Dan,
>
> Could you give some advise on this API? Is it needed to move
> dax_register_holder's job into fs_dax_get_by_bdev()?
Yes, works for me to just add them as optional arguments.
next prev parent reply other threads:[~2022-04-08 6:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-27 12:07 [PATCH v11 0/8] fsdax: introduce fs query to support reflink Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 1/8] dax: Introduce holder for dax_device Shiyang Ruan
2022-03-11 23:35 ` Dan Williams
2022-03-16 13:46 ` Shiyang Ruan
2022-03-30 5:41 ` Christoph Hellwig
2022-03-30 10:03 ` Shiyang Ruan
2022-03-30 10:13 ` Christoph Hellwig
2022-03-30 10:58 ` Shiyang Ruan
2022-03-30 15:49 ` Christoph Hellwig
2022-03-30 16:18 ` Darrick J. Wong
2022-04-06 0:55 ` Jane Chu
2022-04-06 1:22 ` Dan Williams
2022-04-06 20:39 ` Darrick J. Wong
2022-04-08 1:38 ` Dan Williams
2022-04-08 5:59 ` Shiyang Ruan
2022-03-30 5:41 ` Christoph Hellwig
2022-02-27 12:07 ` [PATCH v11 2/8] mm: factor helpers for memory_failure_dev_pagemap Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 3/8] pagemap,pmem: Introduce ->memory_failure() Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 4/8] fsdax: Introduce dax_lock_mapping_entry() Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 5/8] mm: move pgoff_address() to vma_pgoff_address() Shiyang Ruan
2022-03-30 5:46 ` Christoph Hellwig
2022-03-30 6:49 ` Shiyang Ruan
2022-02-27 12:07 ` [PATCH v11 6/8] mm: Introduce mf_dax_kill_procs() for fsdax case Shiyang Ruan
2022-03-30 5:51 ` Christoph Hellwig
2022-02-27 12:07 ` [PATCH v11 7/8] xfs: Implement ->notify_failure() for XFS Shiyang Ruan
2022-02-27 14:05 ` kernel test robot
2022-02-27 15:36 ` kernel test robot
2022-02-27 15:46 ` kernel test robot
2022-03-30 6:00 ` Christoph Hellwig
2022-03-30 15:16 ` Shiyang Ruan
2022-03-30 15:52 ` Christoph Hellwig
2022-04-08 6:04 ` Shiyang Ruan
2022-04-08 6:26 ` Dan Williams [this message]
2022-04-08 6:25 ` Dan Williams
2022-02-27 12:07 ` [PATCH v11 8/8] fsdax: set a CoW flag when associate reflink mappings Shiyang Ruan
2022-02-27 15:57 ` kernel test robot
2022-03-10 13:08 ` [PATCH v11 0/8] fsdax: introduce fs query to support reflink Shiyang Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jO+-JkRcwZk0ZuYaGy0NDx2iZg-GjnDLWqVFYvciFF4g@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=jane.chu@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=ruansy.fnst@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).