From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36159C07E96 for ; Fri, 9 Jul 2021 02:04:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 162F16146E for ; Fri, 9 Jul 2021 02:04:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230367AbhGICHg (ORCPT ); Thu, 8 Jul 2021 22:07:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbhGICHe (ORCPT ); Thu, 8 Jul 2021 22:07:34 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0105C061762 for ; Thu, 8 Jul 2021 19:04:51 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id p4-20020a17090a9304b029016f3020d867so5200579pjo.3 for ; Thu, 08 Jul 2021 19:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BVmgiSoeAePhBmCLdjFJeAKj4gM8pZI9jJIBMA1d9SE=; b=nOy3S+hBH8Tk3VPQtRsr4FS7vHvTjqKKF3q4j4/Iz3rEow5ZwXTSH+1Eq1Qyct6jfd cRwQhXijCMaDM3wTbh4tJPpjF8ze2aGBDhHTisQK6YbEsAb/eJAhaXW68YmZwp7pSPKH y7obz32V9TCKSYEgGN1EqCp+IuW3akLvlugdeykO+p5b9g/KGZm/BxBG1Sk5VbmVjXD5 PDj8dOYE98hqeeCiu9Ir5q+0KS07C38eKGmFtACVM/QipVxhtXvhavsADsTRBnHvVQMM qxtAh8B59ycVO1ZdQLuY+kzzPslqILg8akcV4XeDYTXQTbtzFvTIRDkHsc58M+8CI/Y9 KVOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BVmgiSoeAePhBmCLdjFJeAKj4gM8pZI9jJIBMA1d9SE=; b=YEMLGqZVLb7B3D1cOUcywkvwa90FRhAI390zFandpcgXRor0eNELvc/e8XmJbKFM66 m33DV3xgoEPQlgMSM5phCUVdKvc9mCnDjOW7ux3Hs9ANTSSN2ynGKjUp1EX5lc+oXplb 3IayfjrIBrBSn5/9KwIIa5jN3KbJHEvPutWp+1wfC3IiB0DVHqv7GBrFML7BGN8efKi5 IqpwxPp5/uDjYWd1qymL589ULDi5sqQQqNj9fLKgDv61qOBB7470SJ8YwKnstEOez1P+ tit3sanqbvR0vXejuyXGXB0xulSrUWpY74JR1k2VW7j28bRgZbFbL1wImcCDoRt/hm8d ciqA== X-Gm-Message-State: AOAM530qRPjSm1KmhYJHxtHnN+KgRDZ5DMeWwRlJr61TPBn5PshJUL2k cnitLhUPqRgpHpG4RWiucmQe9FaWoJF56C/NfZpnQg== X-Google-Smtp-Source: ABdhPJyEz8U2pKVhGrHBoDqX+2MQUYuuhUzLeDOKRp5NApgfTOqBP5NVA74Lwy229E9/7syAydM5mL2FNAKSdTbIQpg= X-Received: by 2002:a17:902:d88b:b029:128:cd59:ead2 with SMTP id b11-20020a170902d88bb0290128cd59ead2mr28421140plz.27.1625796290994; Thu, 08 Jul 2021 19:04:50 -0700 (PDT) MIME-Version: 1.0 References: <20210707204249.3046665-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210707204249.3046665-6-sathyanarayanan.kuppuswamy@linux.intel.com> <24d8fd58-36c1-0e89-4142-28f29e2c434b@linux.intel.com> <4972fc1a-1ffb-2b6d-e764-471210df96a3@linux.intel.com> In-Reply-To: From: Dan Williams Date: Thu, 8 Jul 2021 19:04:40 -0700 Message-ID: Subject: Re: [PATCH v2 5/6] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver To: Andi Kleen Cc: "Kuppuswamy, Sathyanarayanan" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Hans de Goede , Mark Gross , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter H Anvin , Dave Hansen , Tony Luck , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , X86 ML , Linux Kernel Mailing List , platform-driver-x86@vger.kernel.org, bpf@vger.kernel.org, Netdev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 8, 2021 at 6:44 PM Andi Kleen wrote: > > > > One allocation for the life of the driver that can have its direct map > > permissions changed rather than an allocation per-file descriptor and > > fragmenting the direct map. > > The vmap() approach discussed in another mail will solve that. Ok, not my first choice for how to handle the allocation side of that, but not broken. I'd still feel better if there was an actual data structure assigned to file->private_data rather than using that 'void *' pointer directly and casting throughout the driver.