From: Dan Williams <dan.j.williams@intel.com>
To: "Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"hpa@zytor.com" <hpa@zytor.com>,
"david@fromorbit.com" <david@fromorbit.com>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
"mingo@kernel.org" <mingo@kernel.org>,
"tj@kernel.org" <tj@kernel.org>,
"paulus@samba.org" <paulus@samba.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"hch@lst.de" <hch@lst.de>,
"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>
Subject: Re: [PATCH v4 4/9] dax: fix mapping lifetime handling, convert to __pfn_t + kmap_atomic_pfn_t()
Date: Mon, 8 Jun 2015 09:36:46 -0700 [thread overview]
Message-ID: <CAPcyv4jeX+SMhoVh-wwuNozn5-E-4hfhH7H6RpqgsBnHq30Bmg@mail.gmail.com> (raw)
In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295A973B07@G9W0745.americas.hpqcorp.net>
On Mon, Jun 8, 2015 at 9:29 AM, Elliott, Robert (Server Storage)
<Elliott@hp.com> wrote:
>> -----Original Message-----
>> From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf
>> Of Dan Williams
>> Sent: Friday, June 05, 2015 3:19 PM
>> Subject: [PATCH v4 4/9] dax: fix mapping lifetime handling, convert to
>> __pfn_t + kmap_atomic_pfn_t()
> ...
>> diff --git a/arch/powerpc/sysdev/axonram.c
>> b/arch/powerpc/sysdev/axonram.c
>> index e8657d3bc588..20725006592e 100644
>> --- a/arch/powerpc/sysdev/axonram.c
>> +++ b/arch/powerpc/sysdev/axonram.c
> ...
>> @@ -165,9 +166,13 @@ static int axon_ram_probe(struct platform_device
>> *device)
>> {
>> static int axon_ram_bank_id = -1;
>> struct axon_ram_bank *bank;
>> - struct resource resource;
>> + struct resource *resource;
>> int rc = 0;
>>
>> + resource = devm_kzalloc(&device->dev, sizeof(*resource),
>> GFP_KERNEL);
>> + if (!resource)
>> + return -ENOMEM;
>> +
>
> Since resource is now a pointer...
>
> ...
>> @@ -184,13 +189,13 @@ static int axon_ram_probe(struct platform_device
>> *device)
>>
>> bank->device = device;
>>
>> - if (of_address_to_resource(device->dev.of_node, 0, &resource) != 0)
>> {
>> + if (of_address_to_resource(device->dev.of_node, 0, resource) != 0) {
>> dev_err(&device->dev, "Cannot access device tree\n");
>> rc = -EFAULT;
>> goto failed;
>> }
> ...
>
> ... I'd expect to see a devm_kfree call added after the failed label,
> like was done here:
No, because unlike dccsblk the axon_ram driver actually adheres to the
device model, so it will be auto-freed on failed probe. The dcssblk
implementation is not a proper "driver" so we don't get the
devres_release_all() until the device is unregistered. That causes
the "resource" object to stick around longer than necessary unless we
force devm_kfree() it.
next prev parent reply other threads:[~2015-06-08 16:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 21:19 [PATCH v4 0/9] introduce __pfn_t, evacuate struct page from sgls Dan Williams
2015-06-05 21:19 ` [PATCH v4 1/9] introduce __pfn_t for scatterlists and pmem Dan Williams
2015-06-05 21:37 ` Linus Torvalds
2015-06-05 22:12 ` Dan Williams
2015-06-05 21:19 ` [PATCH v4 2/9] x86: support kmap_atomic_pfn_t() for persistent memory Dan Williams
2015-06-09 6:50 ` Christoph Hellwig
2015-06-10 12:12 ` Christoph Hellwig
2015-06-10 15:03 ` Matthew Wilcox
2015-06-10 15:11 ` Christoph Hellwig
2015-06-10 15:36 ` Dan Williams
2015-06-10 16:11 ` Christoph Hellwig
2015-06-10 16:17 ` Dan Williams
2015-06-05 21:19 ` [PATCH v4 3/9] dax: drop size parameter to ->direct_access() Dan Williams
2015-06-06 11:37 ` Matthew Wilcox
2015-06-09 6:51 ` Christoph Hellwig
2015-06-05 21:19 ` [PATCH v4 4/9] dax: fix mapping lifetime handling, convert to __pfn_t + kmap_atomic_pfn_t() Dan Williams
2015-06-06 11:58 ` Matthew Wilcox
2015-08-07 23:54 ` Dan Williams
2015-06-08 16:29 ` Elliott, Robert (Server Storage)
2015-06-08 16:36 ` Dan Williams [this message]
2015-06-09 6:55 ` Christoph Hellwig
2015-06-05 21:19 ` [PATCH v4 5/9] dma-mapping: allow archs to optionally specify a ->map_pfn() operation Dan Williams
2015-06-05 21:19 ` [PATCH v4 6/9] scatterlist: use sg_phys() Dan Williams
2015-06-09 6:59 ` Christoph Hellwig
2015-06-05 21:19 ` [PATCH v4 7/9] scatterlist: cleanup sg_chain() and sg_unmark_end() Dan Williams
2015-06-05 21:19 ` [PATCH v4 8/9] scatterlist: convert to __pfn_t Dan Williams
2015-06-05 21:19 ` [PATCH v4 9/9] x86: convert dma_map_ops to support mapping a __pfn_t Dan Williams
2015-06-09 6:58 ` Christoph Hellwig
2015-06-09 13:47 ` Konrad Rzeszutek Wilk
2015-06-05 21:23 ` [PATCH v4 0/9] introduce __pfn_t, evacuate struct page from sgls Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jeX+SMhoVh-wwuNozn5-E-4hfhH7H6RpqgsBnHq30Bmg@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=Elliott@hp.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=david@fromorbit.com \
--cc=hch@lst.de \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=schwidefsky@de.ibm.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).