From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932076AbbCZTZf (ORCPT ); Thu, 26 Mar 2015 15:25:35 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:35317 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbbCZTZc (ORCPT ); Thu, 26 Mar 2015 15:25:32 -0400 MIME-Version: 1.0 In-Reply-To: <94D0CD8314A33A4D9D801C0FE68B40295A84640D@G9W0745.americas.hpqcorp.net> References: <1427358764-6126-1-git-send-email-hch@lst.de> <1427358764-6126-3-git-send-email-hch@lst.de> <20150326090215.GA11520@gmail.com> <20150326093424.GA28217@lst.de> <55142A92.4060607@plexistor.com> <20150326164314.GB23958@lst.de> <94D0CD8314A33A4D9D801C0FE68B40295A84640D@G9W0745.americas.hpqcorp.net> Date: Thu, 26 Mar 2015 12:25:30 -0700 Message-ID: Subject: Re: [Linux-nvdimm] [PATCH 2/3] x86: add a is_e820_ram() helper From: Dan Williams To: "Elliott, Robert (Server Storage)" Cc: Christoph Hellwig , Boaz Harrosh , "axboe@kernel.dk" , "linux-nvdimm@ml01.01.org" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Ingo Molnar Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2015 at 11:46 AM, Elliott, Robert (Server Storage) wrote: > > >> -----Original Message----- >> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel- >> owner@vger.kernel.org] On Behalf Of Christoph Hellwig >> Sent: Thursday, March 26, 2015 11:43 AM >> To: Boaz Harrosh >> Cc: Christoph Hellwig; Ingo Molnar; linux-nvdimm@ml01.01.org; linux- >> fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org; x86@kernel.org; >> ross.zwisler@linux.intel.com; axboe@kernel.dk >> Subject: Re: [PATCH 2/3] x86: add a is_e820_ram() helper >> >> On Thu, Mar 26, 2015 at 05:49:38PM +0200, Boaz Harrosh wrote: >> > > + memmap=nn[KMG]!ss[KMG] >> > > + [KNL,X86] Mark specific memory as protected. >> > > + Region of memory to be used, from ss to ss+nn. >> > > + The memory region may be marked as e820 type 12 (0xc) >> > > + and is NVDIMM or ADR memory. >> > > + >> > >> > Do we need to escape "\!" this character on grub command line ? It might >> > help to note that. I did like the original "|" BTW >> >> No need to escape it on the kvm command line, which is where I tested >> this flag only so far. If there is a strong argument for "|" I'm happy >> to change it. > > I agree with Boaz that ! is a nuisance if loading pmem as a module > with modprobe from bash. This is a core kernel command line, not a module parameter. I'm not saying that it should stay "!", but modprobe will not need to deal with it.