* [PATCH] iommu/exynos: use list_del_init instead of list_del/INIT_LIST_HEAD
@ 2012-09-06 4:34 Wei Yongjun
2012-09-18 10:44 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2012-09-06 4:34 UTC (permalink / raw)
To: joerg.roedel; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Using list_del_init() instead of list_del() + INIT_LIST_HEAD().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/iommu/exynos-iommu.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
index 80bad32..7fe44f8 100644
--- a/drivers/iommu/exynos-iommu.c
+++ b/drivers/iommu/exynos-iommu.c
@@ -840,8 +840,7 @@ static void exynos_iommu_detach_device(struct iommu_domain *domain,
if (__exynos_sysmmu_disable(data)) {
dev_dbg(dev, "%s: Detached IOMMU with pgtable %#lx\n",
__func__, __pa(priv->pgtable));
- list_del(&data->node);
- INIT_LIST_HEAD(&data->node);
+ list_del_init(&data->node);
} else {
dev_dbg(dev, "%s: Detaching IOMMU with pgtable %#lx delayed",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iommu/exynos: use list_del_init instead of list_del/INIT_LIST_HEAD
2012-09-06 4:34 [PATCH] iommu/exynos: use list_del_init instead of list_del/INIT_LIST_HEAD Wei Yongjun
@ 2012-09-18 10:44 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2012-09-18 10:44 UTC (permalink / raw)
To: Wei Yongjun; +Cc: yongjun_wei, linux-kernel
On Thu, Sep 06, 2012 at 12:34:09PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Using list_del_init() instead of list_del() + INIT_LIST_HEAD().
>
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Applied, thanks.
--
AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-18 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-06 4:34 [PATCH] iommu/exynos: use list_del_init instead of list_del/INIT_LIST_HEAD Wei Yongjun
2012-09-18 10:44 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).