From: Song Liu <song@kernel.org>
To: Alexander Lobakin <alobakin@pm.me>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Dmitrii Dolgov" <9erthalion6@gmail.com>,
"Quentin Monnet" <quentin@isovalent.com>,
"Tiezhu Yang" <yangtiezhu@loongson.cn>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Chenbo Feng" <fengc@google.com>,
"Willem de Bruijn" <willemb@google.com>,
"Daniel Wagner" <daniel.wagner@bmw-carit.de>,
"Thomas Graf" <tgraf@suug.ch>,
"Ong Boon Leong" <boon.leong.ong@intel.com>,
linux-perf-users@vger.kernel.org,
"open list" <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
llvm@lists.linux.dev
Subject: Re: [PATCH bpf-next 10/11] samples: bpf: fix -Wsequence-point
Date: Fri, 15 Apr 2022 16:56:25 -0700 [thread overview]
Message-ID: <CAPhsuW4kqcjgd=ckUDToebvGUmRUJC290ryJShbPDzv43S0kvg@mail.gmail.com> (raw)
In-Reply-To: <20220414223704.341028-11-alobakin@pm.me>
On Thu, Apr 14, 2022 at 3:47 PM Alexander Lobakin <alobakin@pm.me> wrote:
>
> In some libc implementations, CPU_SET() may utilize its first
> argument several times. When combined with a post-increment, it
> leads to:
>
> samples/bpf/test_lru_dist.c:233:36: warning: operation on 'next_to_try' may be undefined [-Wsequence-point]
> 233 | CPU_SET(next_to_try++, &cpuset);
> | ^
>
> Split the sentence into two standalone operations to fix this.
>
> Fixes: 5db58faf989f ("bpf: Add tests for the LRU bpf_htab")
> Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> samples/bpf/test_lru_dist.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/samples/bpf/test_lru_dist.c b/samples/bpf/test_lru_dist.c
> index be98ccb4952f..191643ec501e 100644
> --- a/samples/bpf/test_lru_dist.c
> +++ b/samples/bpf/test_lru_dist.c
> @@ -229,7 +229,8 @@ static int sched_next_online(int pid, int next_to_try)
>
> while (next_to_try < nr_cpus) {
> CPU_ZERO(&cpuset);
> - CPU_SET(next_to_try++, &cpuset);
> + CPU_SET(next_to_try, &cpuset);
> + next_to_try++;
> if (!sched_setaffinity(pid, sizeof(cpuset), &cpuset))
> break;
> }
> --
> 2.35.2
>
>
next prev parent reply other threads:[~2022-04-15 23:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 22:44 [PATCH bpf-next 00/11] bpf: random unpopular userspace fixes (32 bit et al.) Alexander Lobakin
2022-04-14 22:44 ` [PATCH bpf-next 01/11] bpf, perf: fix bpftool compilation with !CONFIG_PERF_EVENTS Alexander Lobakin
2022-04-15 23:07 ` Song Liu
2022-04-15 23:20 ` Song Liu
2022-04-19 9:03 ` Peter Zijlstra
2022-04-20 5:30 ` Andrii Nakryiko
2022-04-14 22:45 ` [PATCH bpf-next 02/11] bpf: always emit struct bpf_perf_link BTF Alexander Lobakin
2022-04-15 23:24 ` Song Liu
2022-04-16 17:50 ` Alexander Lobakin
2022-04-14 22:45 ` [PATCH bpf-next 03/11] tools, bpf: fix bpftool build with !CONFIG_BPF_EVENTS Alexander Lobakin
2022-04-15 23:34 ` Song Liu
2022-04-20 17:12 ` Andrii Nakryiko
2022-04-14 22:45 ` [PATCH bpf-next 04/11] samples: bpf: add 'asm/mach-generic' include path for every MIPS Alexander Lobakin
2022-04-15 23:35 ` Song Liu
2022-04-14 22:45 ` [PATCH bpf-next 05/11] samples: bpf: use host bpftool to generate vmlinux.h, not target Alexander Lobakin
2022-04-15 13:38 ` Kumar Kartikeya Dwivedi
2022-04-15 23:44 ` Song Liu
2022-04-14 22:46 ` [PATCH bpf-next 06/11] tools, bpf: fix fcntl.h include in bpftool Alexander Lobakin
2022-04-15 23:46 ` Song Liu
2022-04-14 22:46 ` [PATCH bpf-next 07/11] samples: bpf: fix uin64_t format literals Alexander Lobakin
2022-04-15 23:52 ` Song Liu
2022-04-16 17:55 ` Alexander Lobakin
2022-04-19 8:07 ` David Laight
2022-04-20 17:14 ` Andrii Nakryiko
2022-04-14 22:46 ` [PATCH bpf-next 08/11] samples: bpf: fix shifting unsigned long by 32 positions Alexander Lobakin
2022-04-15 23:54 ` Song Liu
2022-04-20 17:18 ` Andrii Nakryiko
2022-04-27 15:54 ` Yonghong Song
2022-04-27 18:53 ` Andrii Nakryiko
2022-04-14 22:46 ` [PATCH bpf-next 09/11] samples: bpf: fix include order for non-Glibc environments Alexander Lobakin
2022-04-15 23:55 ` Song Liu
2022-04-14 22:47 ` [PATCH bpf-next 10/11] samples: bpf: fix -Wsequence-point Alexander Lobakin
2022-04-15 23:56 ` Song Liu [this message]
2022-04-14 22:47 ` [PATCH bpf-next 11/11] samples: bpf: xdpsock: fix -Wmaybe-uninitialized Alexander Lobakin
2022-04-15 12:15 ` Maciej Fijalkowski
2022-04-15 23:57 ` Song Liu
2022-04-20 17:20 ` [PATCH bpf-next 00/11] bpf: random unpopular userspace fixes (32 bit et al.) Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW4kqcjgd=ckUDToebvGUmRUJC290ryJShbPDzv43S0kvg@mail.gmail.com' \
--to=song@kernel.org \
--cc=9erthalion6@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alobakin@pm.me \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn@kernel.org \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=fengc@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jonathan.lemon@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=magnus.karlsson@intel.com \
--cc=mark.rutland@arm.com \
--cc=memxor@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=quentin@isovalent.com \
--cc=songliubraving@fb.com \
--cc=tgraf@suug.ch \
--cc=willemb@google.com \
--cc=yangtiezhu@loongson.cn \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).