From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66288C4360C for ; Fri, 27 Sep 2019 18:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3659D20872 for ; Fri, 27 Sep 2019 18:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="unbvXDxn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728460AbfI0SoS (ORCPT ); Fri, 27 Sep 2019 14:44:18 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45577 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728321AbfI0SoR (ORCPT ); Fri, 27 Sep 2019 14:44:17 -0400 Received: by mail-qt1-f196.google.com with SMTP id c21so8469646qtj.12; Fri, 27 Sep 2019 11:44:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2og6D8JNGUcFzo2+ZOKB4t8tH7Nwv5RRVJlFtszjd+8=; b=unbvXDxnpNpcf8CoeSiwRYEbaguyEnVe7BU2tnKz0HxgW0iup/mqrk+c66d6zG0Jr8 II95/A/X4I8kXM+g/a8ggxkX7nJMkYT9ij5nqrQEk33ll61o9WeX7MnPz4Kh9FAP1U6w d4cy5S1hMCu9Oml+aTdAivYdpB0tnqVlqkjntzfd5AuoRtB/T5J74fjIz8gQHNVw+Y8P /h0qSEubAKZtbVGcTy0Eqh0ya8m/WJdKRJYNzfxH2Ya6/iXwevjmn+4XqWXBkUF+El7u 0WnN6VOXJPuucvvX89TO9VbkZ/oaDGUVgBsmfQb2RLpW9tJEaaM0htpGrjmhR0I6pkZF 0rWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2og6D8JNGUcFzo2+ZOKB4t8tH7Nwv5RRVJlFtszjd+8=; b=VEi091ae405kHpUMK1amldLAYLRKLUpcTufMQQhAIp4+k+lGFDtWYRsLhIw2XkYLOy PD9x5Ga/P3wWuqMdkUNQVB+wU74NjuIuI5wkk4AXyf6nYpBg3bQ/FnmKYAdwEe7Sp8Bj y8QtaRTT0bQmpdoYZ0ztkoqoutHA78uffhfxolvq05z6/yDbcd8WLO4qLBneDxHaQ9PT ALaiZh6YuPmNeyDBsV1shp0xPPwUPTEZL460/22HvsKgipQ3NC1lheqLu79z1tDM0t1d Iwqbd091LVDRowhVjvU6VTwIw/hghA8SglbDGceDdD+0SoHDq8oalfsNXAgVQkg4nFKP jS7A== X-Gm-Message-State: APjAAAV4V5nwtDlrh6vRuwKuRkGZ0XES0b0shoKxzNRfKfKB9QVJefBj CipZuqVThavSIr6VoCZG0GglD/VJdp5EJINQ/y8= X-Google-Smtp-Source: APXvYqwAlwnd4veOBCqFHae+zgONBZFe8cp9ApiFkNKCb8JCy0Kv1XtjK2VEE2CERXOf4DuvZw71LzlZsjVhDobvMHg= X-Received: by 2002:ac8:1099:: with SMTP id a25mr11275982qtj.308.1569609855302; Fri, 27 Sep 2019 11:44:15 -0700 (PDT) MIME-Version: 1.0 References: <20190927011344.4695-1-skhan@linuxfoundation.org> In-Reply-To: <20190927011344.4695-1-skhan@linuxfoundation.org> From: Song Liu Date: Fri, 27 Sep 2019 11:44:04 -0700 Message-ID: Subject: Re: [PATCH] tools: bpf: Use !building_out_of_srctree to determine srctree To: Shuah Khan Cc: Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Networking , bpf , open list , linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 26, 2019 at 6:14 PM Shuah Khan wrote: > > make TARGETS=bpf kselftest fails with: > > Makefile:127: tools/build/Makefile.include: No such file or directory > > When the bpf tool make is invoked from tools Makefile, srctree is > cleared and the current logic check for srctree equals to empty > string to determine srctree location from CURDIR. > > When the build in invoked from selftests/bpf Makefile, the srctree > is set to "." and the same logic used for srctree equals to empty is > needed to determine srctree. > > Check building_out_of_srctree undefined as the condition for both > cases to fix "make TARGETS=bpf kselftest" build failure. > > Signed-off-by: Shuah Khan The fix looks reasonable. Thanks! However, I am still seeing some failure: make TARGETS=bpf kselftest [...] test_verifier.c /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/test_stub.o /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/libbpf.a -lcap -lelf -lrt -lpthread -o /data/users/songliubraving/kernel/linux-git/tools/testing/selftests/bpf/test_verifier make[3]: test_verifier.c: Command not found Is this just a problem with my setup? Thanks, Song