From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89B1C04E84 for ; Tue, 28 May 2019 20:57:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1056208CB for ; Tue, 28 May 2019 20:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pUUFYFdh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727665AbfE1U55 (ORCPT ); Tue, 28 May 2019 16:57:57 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:36210 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbfE1U54 (ORCPT ); Tue, 28 May 2019 16:57:56 -0400 Received: by mail-qt1-f196.google.com with SMTP id u12so27061qth.3; Tue, 28 May 2019 13:57:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=o1ydLImzsmpkS5F7PlvU5sVhBXF/PklEQqQZqMpZmxE=; b=pUUFYFdhSOjFKlE4+4l7DO7lFTfWN1aoCbBGKyUVb1zddz/d94F+w8Swz99yR7Z+yi JMuV5TFhMLdvWJuUEBwYbuKUJTLJiQBweh9i1EOl3KSECbPvROcAD92Nzu8+lk+4Wj1H Veg8w/g/mxEO9ooewq3DrgMWdw1+Vr35vdmu3em+cXEpVTUNhk7O82mGNdigmcgJZ6xY DTOA1uWJRMCxYnoS7J/BuACvvS81cDojuRxFtxwWjzvUX0+IX7TNR+/C4RdSRQ3xJr6r Hykh8DQekErFOps4eAllmh+qoou+mRcNzmo99/e49QV53zWeNCkSlIchshLsny5H1/NG MpsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o1ydLImzsmpkS5F7PlvU5sVhBXF/PklEQqQZqMpZmxE=; b=V1q2fKJ1tDgYDCATvHUtyniHmgOM9Z8OnGZxnXk9lRCFOpnS/9nzmKN/PeTGA8SulB cDHGX4Fhf3RmE2OWfYWYcXaFr5rAqb2Eans8GX/FkolfnnGBGNyUJrL8XHXsKXCIpkYC sOPK1rhkA80nZJjMGKwhAECDP8mDwVn9VYgLjnZm6Qwjgr3OnDdIOFPFOSQqri79NDMP jnrQ/FeNDekTBqNdE2vhNhhvNBlZZLksxcHzihn4ML3xgXV7Drf4B7ljzt2vSVhowA9k 4J8X3+6MmfEtMTMIsBEZNeLZ7zajWDWGhuBKZF/a0QNUQv8zPRKI716ZD9EbEAWbAKJ3 192w== X-Gm-Message-State: APjAAAUydww0kRlInx5cKAeflE6pBv/sA2ax0yZ8TXwvJPONL7AlYClY RejlbgbLs73uDGjlBE9hrZwfgh9QuRkWn2MJGzg= X-Google-Smtp-Source: APXvYqyVyzhSWxFPxx1Q7S/1xkEQOPxvA+Ddzkuz4KVntMBUsTlXhD9T29/yxzB2jQa3duROW2pyJYlgJS46nAlO7dk= X-Received: by 2002:a0c:d4ee:: with SMTP id y43mr95878708qvh.26.1559077075184; Tue, 28 May 2019 13:57:55 -0700 (PDT) MIME-Version: 1.0 References: <20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal> In-Reply-To: <20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal> From: Song Liu Date: Tue, 28 May 2019 13:57:44 -0700 Message-ID: Subject: Re: [PATCH bpf v2] selftests: bpf: fix compiler warning To: Alakesh Haloi Cc: linux-kselftest@vger.kernel.org, Networking , bpf , open list , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Stanislav Fomichev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 28, 2019 at 12:35 PM Alakesh Haloi wr= ote: > > Add missing header file following compiler warning > > prog_tests/flow_dissector.c: In function =E2=80=98tx_tap=E2=80=99: > prog_tests/flow_dissector.c:175:9: warning: implicit declaration of funct= ion =E2=80=98writev=E2=80=99; did you mean =E2=80=98write=E2=80=99? [-Wimpl= icit-function-declaration] > return writev(fd, iov, ARRAY_SIZE(iov)); > ^~~~~~ > write > > Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less= mode") > Signed-off-by: Alakesh Haloi Acked-by: Song Liu Thanks for the fix! > --- > tools/testing/selftests/bpf/prog_tests/flow_dissector.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c b/to= ols/testing/selftests/bpf/prog_tests/flow_dissector.c > index fbd1d88a6095..c938283ac232 100644 > --- a/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > +++ b/tools/testing/selftests/bpf/prog_tests/flow_dissector.c > @@ -3,6 +3,7 @@ > #include > #include > #include > +#include > > #define CHECK_FLOW_KEYS(desc, got, expected) \ > CHECK_ATTR(memcmp(&got, &expected, sizeof(got)) !=3D 0, = \ > -- > 2.17.1 >