From: Song Liu <song@kernel.org>
To: Zhang Jiaming <jiaming@nfschina.com>
Cc: linux-raid <linux-raid@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
d@ja.vu, liqiong@nfschina.com, renyu@nfschina.com,
Paul Menzel <pmenzel@molgen.mpg.de>
Subject: Re: [PATCH v2] block: Fix spelling mistakes in comments
Date: Tue, 23 Aug 2022 10:59:33 -0700 [thread overview]
Message-ID: <CAPhsuW6H6Gyazn4o23UeYhfWtTFqcvw9dqS=Aqjpjf1o1qdMrg@mail.gmail.com> (raw)
In-Reply-To: <20220705022617.12555-1-jiaming@nfschina.com>
On Mon, Jul 4, 2022 at 7:26 PM Zhang Jiaming <jiaming@nfschina.com> wrote:
>
> Fix spelling of dones't and waitting in comments.
> Fix tense mistakes of hold and finsh in comments.
> Use underline to connecting reconfig and mutex.
>
> Signed-off-by: Zhang Jiaming <jiaming@nfschina.com>
> Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Sorry for getting on this late.
AFAICT, this one doesn't apply any more (conflict with some of your
other fixes). Could you please resend?
Thanks,
Song
> ---
> drivers/md/raid5-cache.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/md/raid5-cache.c b/drivers/md/raid5-cache.c
> index 83c184eddbda..8d5154d94f86 100644
> --- a/drivers/md/raid5-cache.c
> +++ b/drivers/md/raid5-cache.c
> @@ -125,7 +125,7 @@ struct r5l_log {
> * reclaimed. if it's 0, reclaim spaces
> * used by io_units which are in
> * IO_UNIT_STRIPE_END state (eg, reclaim
> - * dones't wait for specific io_unit
> + * doesn't wait for specific io_unit
> * switching to IO_UNIT_STRIPE_END
> * state) */
> wait_queue_head_t iounit_wait;
> @@ -1326,12 +1326,12 @@ static void r5l_write_super_and_discard_space(struct r5l_log *log,
> * Discard could zero data, so before discard we must make sure
> * superblock is updated to new log tail. Updating superblock (either
> * directly call md_update_sb() or depend on md thread) must hold
> - * reconfig mutex. On the other hand, raid5_quiesce is called with
> - * reconfig_mutex hold. The first step of raid5_quiesce() is waitting
> - * for all IO finish, hence waitting for reclaim thread, while reclaim
> - * thread is calling this function and waitting for reconfig mutex. So
> + * reconfig_mutex. On the other hand, raid5_quiesce is called with
> + * reconfig_mutex held. The first step of raid5_quiesce() is waiting
> + * for all IO to finish, hence waiting for reclaim thread, while reclaim
> + * thread is calling this function and waiting for reconfig_mutex. So
> * there is a deadlock. We workaround this issue with a trylock.
> - * FIXME: we could miss discard if we can't take reconfig mutex
> + * FIXME: we could miss discard if we can't take reconfig_mutex
> */
> set_mask_bits(&mddev->sb_flags, 0,
> BIT(MD_SB_CHANGE_DEVS) | BIT(MD_SB_CHANGE_PENDING));
> --
> 2.34.1
>
next prev parent reply other threads:[~2022-08-23 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 1:23 [PATCH] block: Fix spelling mistake in comments Zhang Jiaming
2022-07-04 7:51 ` Paul Menzel
2022-07-04 10:05 ` [PATCH] block: Fix spelling mistakes " Zhang Jiaming
2022-07-04 18:01 ` Daniel K.
2022-07-05 2:26 ` [PATCH v2] " Zhang Jiaming
2022-08-23 17:59 ` Song Liu [this message]
2022-08-26 3:08 ` [PATCH v3] md/raid5-cache: Resolve patch confilcts Zhang Jiaming
2022-08-26 5:16 ` Song Liu
2022-08-26 10:44 ` [PATCH v3] block: Fix spelling mistakes in comments Zhang Jiaming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW6H6Gyazn4o23UeYhfWtTFqcvw9dqS=Aqjpjf1o1qdMrg@mail.gmail.com' \
--to=song@kernel.org \
--cc=d@ja.vu \
--cc=jiaming@nfschina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=liqiong@nfschina.com \
--cc=pmenzel@molgen.mpg.de \
--cc=renyu@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).