From: Song Liu <song@kernel.org>
To: bpf <bpf@vger.kernel.org>, Linux-MM <linux-mm@kvack.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
rick.p.edgecombe@intel.com, Christoph Hellwig <hch@infradead.org>,
imbrenda@linux.ibm.com, Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH v2 bpf 3/3] bpf: use module_alloc_huge for bpf_prog_pack
Date: Mon, 11 Apr 2022 16:52:40 -0700 [thread overview]
Message-ID: <CAPhsuW6Z1AM=AXtxP5Hk+Xa4yF8r2f0ckOTHDML5A1iRQS8t_w@mail.gmail.com> (raw)
In-Reply-To: <20220411233549.740157-4-song@kernel.org>
On Mon, Apr 11, 2022 at 4:41 PM Song Liu <song@kernel.org> wrote:
>
> module_alloc_huge for bpf_prog_pack so that BPF programs sit on PMD_SIZE
> pages. This benefits system performance by reducing iTLB miss rate.
>
> Signed-off-by: Song Liu <song@kernel.org>
I am really sorry for spamming the list twice. The first set
experienced long lag,
so I thought it didn't get through.
I also updated the commit log of 3/3, and this one is the latest version.
Thanks,
Song
> ---
> kernel/bpf/core.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c
> index 13e9dbeeedf3..fd45bdd80a75 100644
> --- a/kernel/bpf/core.c
> +++ b/kernel/bpf/core.c
> @@ -857,7 +857,7 @@ static size_t select_bpf_prog_pack_size(void)
> void *ptr;
>
> size = BPF_HPAGE_SIZE * num_online_nodes();
> - ptr = module_alloc(size);
> + ptr = module_alloc_huge(size);
>
> /* Test whether we can get huge pages. If not just use PAGE_SIZE
> * packs.
> @@ -881,7 +881,7 @@ static struct bpf_prog_pack *alloc_new_pack(void)
> GFP_KERNEL);
> if (!pack)
> return NULL;
> - pack->ptr = module_alloc(bpf_prog_pack_size);
> + pack->ptr = module_alloc_huge(bpf_prog_pack_size);
> if (!pack->ptr) {
> kfree(pack);
> return NULL;
> @@ -889,7 +889,6 @@ static struct bpf_prog_pack *alloc_new_pack(void)
> bitmap_zero(pack->bitmap, bpf_prog_pack_size / BPF_PROG_CHUNK_SIZE);
> list_add_tail(&pack->list, &pack_list);
>
> - set_vm_flush_reset_perms(pack->ptr);
> set_memory_ro((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE);
> set_memory_x((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE);
> return pack;
> @@ -970,7 +969,9 @@ static void bpf_prog_pack_free(struct bpf_binary_header *hdr)
> if (bitmap_find_next_zero_area(pack->bitmap, bpf_prog_chunk_count(), 0,
> bpf_prog_chunk_count(), 0) == 0) {
> list_del(&pack->list);
> - module_memfree(pack->ptr);
> + set_memory_nx((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE);
> + set_memory_rw((unsigned long)pack->ptr, bpf_prog_pack_size / PAGE_SIZE);
> + vfree(pack->ptr);
> kfree(pack);
> }
> out:
> --
> 2.30.2
>
>
next parent reply other threads:[~2022-04-11 23:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220411233549.740157-1-song@kernel.org>
[not found] ` <20220411233549.740157-4-song@kernel.org>
2022-04-11 23:52 ` Song Liu [this message]
[not found] ` <20220411233549.740157-2-song@kernel.org>
2022-04-12 4:18 ` [PATCH v2 bpf 1/3] vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLOW_HUGE_VMAP Christoph Hellwig
2022-04-12 6:00 ` Song Liu
2022-04-21 2:24 ` Nicholas Piggin
2022-04-21 3:35 ` Nicholas Piggin
[not found] ` <20220411233549.740157-3-song@kernel.org>
2022-04-12 4:20 ` [PATCH v2 bpf 2/3] module: introduce module_alloc_huge Christoph Hellwig
2022-04-12 6:11 ` Song Liu
[not found] ` <20220411233549.740157-5-song@kernel.org>
2022-04-12 4:20 ` [PATCH v2 bpf 3/3] bpf: use vmalloc with VM_ALLOW_HUGE_VMAP for bpf_prog_pack Christoph Hellwig
2022-04-12 6:12 ` Song Liu
2022-04-12 17:20 ` Edgecombe, Rick P
2022-04-12 21:00 ` Song Liu
2022-04-13 15:51 ` Edgecombe, Rick P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW6Z1AM=AXtxP5Hk+Xa4yF8r2f0ckOTHDML5A1iRQS8t_w@mail.gmail.com' \
--to=song@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hch@infradead.org \
--cc=imbrenda@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=rick.p.edgecombe@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).