From: Song Liu <song@kernel.org>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Add PROG_TEST_RUN selftest for BPF_PROG_TYPE_KPROBE
Date: Tue, 31 May 2022 10:11:21 -0700 [thread overview]
Message-ID: <CAPhsuW6eQXZrnJdRGUEu6jQAjpXnEB_f4bzBF1rXst4LWBWd=g@mail.gmail.com> (raw)
In-Reply-To: <a8f5faada9b96218d79beb7b7ddebe6a837a5536.1653861287.git.dxu@dxuuu.xyz>
On Sun, May 29, 2022 at 3:06 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> This commit adds a selftest to test that we can both PROG_TEST_RUN a
> kprobe prog and set its context.
nit: per Documentation/process/submitting-patches.rst:
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.
>
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
Other than that,
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> .../selftests/bpf/prog_tests/kprobe_ctx.c | 57 +++++++++++++++++++
> .../testing/selftests/bpf/progs/kprobe_ctx.c | 33 +++++++++++
> 2 files changed, 90 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/kprobe_ctx.c
> create mode 100644 tools/testing/selftests/bpf/progs/kprobe_ctx.c
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/kprobe_ctx.c b/tools/testing/selftests/bpf/prog_tests/kprobe_ctx.c
> new file mode 100644
> index 000000000000..260966fd4506
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/kprobe_ctx.c
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <test_progs.h>
> +#include <linux/ptrace.h>
> +#include "kprobe_ctx.skel.h"
> +
> +/*
> + * x86_64 happens to be one of the architectures that exports the
> + * kernel `struct pt_regs` to userspace ABI. For the architectures
> + * that don't, users will have to extract `struct pt_regs` from vmlinux
> + * BTF in order to use BPF_PROG_TYPE_KPROBE's BPF_PROG_RUN functionality.
> + *
> + * We choose to only test x86 here to keep the test simple.
> + */
> +void test_kprobe_ctx(void)
> +{
> +#ifdef __x86_64__
> + struct pt_regs regs = {
> + .rdi = 1,
> + .rsi = 2,
> + .rdx = 3,
> + .rcx = 4,
> + .r8 = 5,
> + };
> +
> + LIBBPF_OPTS(bpf_test_run_opts, tattr,
> + .ctx_in = ®s,
> + .ctx_size_in = sizeof(regs),
> + );
> +
> + struct kprobe_ctx *skel = NULL;
> + int prog_fd;
> + int err;
> +
> + skel = kprobe_ctx__open_and_load();
> + if (!ASSERT_OK_PTR(skel, "skel_open"))
> + return;
> +
> + skel->bss->expected_p1 = (void *)1;
> + skel->bss->expected_p2 = (void *)2;
> + skel->bss->expected_p3 = (void *)3;
> + skel->bss->expected_p4 = (void *)4;
> + skel->bss->expected_p5 = (void *)5;
> +
> + prog_fd = bpf_program__fd(skel->progs.prog);
> + err = bpf_prog_test_run_opts(prog_fd, &tattr);
> + if (!ASSERT_OK(err, "bpf_prog_test_run"))
> + goto cleanup;
> +
> + if (!ASSERT_TRUE(skel->bss->ret, "ret"))
> + goto cleanup;
> +
> + if (!ASSERT_GT(tattr.duration, 0, "duration"))
> + goto cleanup;
> +cleanup:
> + kprobe_ctx__destroy(skel);
> +#endif
> +}
> diff --git a/tools/testing/selftests/bpf/progs/kprobe_ctx.c b/tools/testing/selftests/bpf/progs/kprobe_ctx.c
> new file mode 100644
> index 000000000000..98063c549930
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/kprobe_ctx.c
> @@ -0,0 +1,33 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include "vmlinux.h"
> +#include <bpf/bpf_helpers.h>
> +#include <bpf/bpf_tracing.h>
> +
> +volatile void *expected_p1;
> +volatile void *expected_p2;
> +volatile void *expected_p3;
> +volatile void *expected_p4;
> +volatile void *expected_p5;
> +volatile bool ret = false;
> +
> +SEC("kprobe/this_function_does_not_exist")
> +int prog(struct pt_regs *ctx)
> +{
> + void *p1, *p2, *p3, *p4, *p5;
> +
> + p1 = (void *)PT_REGS_PARM1(ctx);
> + p2 = (void *)PT_REGS_PARM2(ctx);
> + p3 = (void *)PT_REGS_PARM3(ctx);
> + p4 = (void *)PT_REGS_PARM4(ctx);
> + p5 = (void *)PT_REGS_PARM5(ctx);
> +
> + if (p1 != expected_p1 || p2 != expected_p2 || p3 != expected_p3 ||
> + p4 != expected_p4 || p5 != expected_p5)
> + return 0;
> +
> + ret = true;
> + return 0;
> +}
> +
> +char _license[] SEC("license") = "GPL";
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-05-31 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 22:06 [PATCH bpf-next 0/2] Add PROG_TEST_RUN support to BPF_PROG_TYPE_KPROBE Daniel Xu
2022-05-29 22:06 ` [PATCH bpf-next 1/2] bpf, test_run: Add PROG_TEST_RUN support to kprobe Daniel Xu
2022-05-31 15:12 ` kernel test robot
2022-05-31 17:04 ` Song Liu
2022-05-31 18:07 ` Alexei Starovoitov
2022-06-02 14:37 ` Daniel Xu
2022-06-01 10:36 ` kernel test robot
2022-05-29 22:06 ` [PATCH bpf-next 2/2] selftests/bpf: Add PROG_TEST_RUN selftest for BPF_PROG_TYPE_KPROBE Daniel Xu
2022-05-31 17:11 ` Song Liu [this message]
2022-05-30 6:00 ` [PATCH bpf-next 0/2] Add PROG_TEST_RUN support to BPF_PROG_TYPE_KPROBE Song Liu
2022-05-30 14:56 ` Daniel Xu
2022-05-31 16:47 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPhsuW6eQXZrnJdRGUEu6jQAjpXnEB_f4bzBF1rXst4LWBWd=g@mail.gmail.com' \
--to=song@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dxu@dxuuu.xyz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).