From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 642ACC388F9 for ; Fri, 23 Oct 2020 21:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDB8D24677 for ; Fri, 23 Oct 2020 21:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603487771; bh=qQcFmOGTx12wPD63RiThRe7Vh0MNAYSb3WtVSv6KO9I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=0HZ1KgkJ5iHNK5aqxbrEW7p4qK8xLIsYabqW1hkWE1RiWZb0BWT3aNoAQQiDukFZK QQuKXxRKpC9YnSsiNzpUTt1ENzvt9pRl89cCtN4xCKX0eO2Z2d3U17KT4PlMdAmlPf nIX1UB15ZNLLZLlUauOOJrA7dV41NVkE17zb6jUU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756030AbgJWVQK (ORCPT ); Fri, 23 Oct 2020 17:16:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:40250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755437AbgJWVQI (ORCPT ); Fri, 23 Oct 2020 17:16:08 -0400 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA74F24688; Fri, 23 Oct 2020 21:16:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603487767; bh=qQcFmOGTx12wPD63RiThRe7Vh0MNAYSb3WtVSv6KO9I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ylYjv002r5/d4PJz5MfpZMB4thciSwlk1eXkJiCA3bvenmoPxzuiHjvcXDcackAcE w6VNJ7rBH6083fbGYBlG3chnrNZbtJNPqO54/g2gQKHUjVIOrFDXlaNINXtFbJdoKt OK0nV4hNeaJ18/R+8VfmdHAtYYky9/5RkmV0QCgE= Received: by mail-lj1-f178.google.com with SMTP id h20so3011574lji.9; Fri, 23 Oct 2020 14:16:06 -0700 (PDT) X-Gm-Message-State: AOAM5337x3XfZ2H+iQYCxwVuwsAo2l/BfiG/SaJARh8J72H8DUzAZiGl 2N/bhe5jmH8tCgkklWYJzAiC/vEHWJ8aRCVwm9M= X-Google-Smtp-Source: ABdhPJxMP4Oqfuc0h+oHI0VayAXX1a002RyckvG+CEYT7Qe0w/jJqsSdKxhG124OF9Ag+jl4aWynWIOTPbYK55JDXo0= X-Received: by 2002:a05:651c:cd:: with SMTP id 13mr1498277ljr.392.1603487764782; Fri, 23 Oct 2020 14:16:04 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Song Liu Date: Fri, 23 Oct 2020 14:15:53 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [LTP] mmstress[1309]: segfault at 7f3d71a36ee8 ip 00007f3d77132bdf sp 00007f3d71a36ee8 error 4 in libc-2.27.so[7f3d77058000+1aa000] To: Linus Torvalds Cc: Naresh Kamboju , =?UTF-8?B?RGFuaWVsIETDrWF6?= , Stephen Rothwell , "Matthew Wilcox (Oracle)" , "Peter Zijlstra (Intel)" , Viresh Kumar , X86 ML , open list , lkft-triage@lists.linaro.org, "Eric W. Biederman" , linux-mm , linux-m68k , Linux-Next Mailing List , Thomas Gleixner , kasan-dev , Dmitry Vyukov , Geert Uytterhoeven , Christian Brauner , Ingo Molnar , LTP List , Al Viro Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2020 at 10:51 AM Linus Torvalds wrote: > > On Fri, Oct 23, 2020 at 10:00 AM Naresh Kamboju > wrote: > > > > [Old patch from yesterday] > > > > After applying your patch on top on linux next tag 20201015 > > there are two observations, > > 1) i386 build failed. please find build error build > > Yes, this was expected. That patch explicitly only works on x86-64, > because 32-bit needs the double register handling for 64-bit values > (mainly loff_t). > > > 2) x86_64 kasan test PASS and the reported error not found. > > Ok, good. That confirms that the problem you reported is indeed the > register allocation. > > The patch I sent an hour ago (the one based on Rasmus' one from > yesterday) should fix things too, and - unlike yesterday's - work on > 32-bit. > > But I'll wait for confirmation (and hopefully a sign-off from Rasmus > so that I can give him authorship) before actually committing it. > > Linus My test vm failed to boot since commit d55564cfc222326e944893eff0c4118353e349ec x86: Make __put_user() generate an out-of-line call The patch also fixed it. Thanks! Song